linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Longerbeam <slongerbeam@gmail.com>
To: "Philipp Zabel" <p.zabel@pengutronix.de>,
	"Krzysztof Hałasa" <khalasa@piap.pl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] MEDIA-STAGING: Remove unneeded geometry restrictions from i.MX CSI driver
Date: Fri, 26 Jun 2020 10:16:17 -0700	[thread overview]
Message-ID: <fe1b792e-2cfd-f380-923c-457762280546@gmail.com> (raw)
In-Reply-To: <5d8e8b2b8daf8a44fd9650f08bacb423f4beb940.camel@pengutronix.de>

Hi Krzysztof, Philipp,



On 6/26/20 1:58 AM, Philipp Zabel wrote:
> Hi Krzysztof,
>
> thank you for the patch.
>
> On Thu, 2020-05-14 at 12:00 +0200, Krzysztof Hałasa wrote:
>> I don't know what minimal image dimensions are, but 32x32 appears to
>> be ok according to the docs.
>> This is needed for small sensors like 80x80 thermal imagers.
>>
>> Signed-off-by: Krzysztof Halasa <khalasa@piap.pl>
> This looks fine to me for the CSI. Steve, are you aware of any
> limitations?

I looked at the imx6 ref manual and don't see any limitations in IC or 
VDIC or IDMAC or CPMEM, so this is fine to me as well.

One nitpick, please change the all-caps commit subject to

media: imx: Remove unneeded geometry restrictions from i.MX CSI driver

After that,

Acked-by: Steve Longerbeam <slongerbeam@gmail.com>


> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> Tested-by: Philipp Zabel <p.zabel@pengutronix.de>
> (with CSI crop to 32x32, I have no 32x32 sensors at hand)
>
> regards
> Philipp
>
>> diff --git a/drivers/staging/media/imx/imx-ic-prp.c b/drivers/staging/media/imx/imx-ic-prp.c
>> index 2a4f77e83ed3..622a52c46229 100644
>> --- a/drivers/staging/media/imx/imx-ic-prp.c
>> +++ b/drivers/staging/media/imx/imx-ic-prp.c
>> @@ -26,8 +26,8 @@
>>   /*
>>    * Min/Max supported width and heights.
>>    */
>> -#define MIN_W       176
>> -#define MIN_H       144
>> +#define MIN_W        32
>> +#define MIN_H        32
>>   #define MAX_W      4096
>>   #define MAX_H      4096
>>   #define W_ALIGN    4 /* multiple of 16 pixels */
>> diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c
>> index 09c4e3f33807..cb46455a1a36 100644
>> --- a/drivers/staging/media/imx/imx-ic-prpencvf.c
>> +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c
>> @@ -35,8 +35,8 @@
>>    * has not requested a planar format, we should allow 8 pixel
>>    * alignment at the source pad.
>>    */
>> -#define MIN_W_SINK  176
>> -#define MIN_H_SINK  144
>> +#define MIN_W_SINK   32
>> +#define MIN_H_SINK   32
>>   #define MAX_W_SINK 4096
>>   #define MAX_H_SINK 4096
>>   #define W_ALIGN_SINK  3 /* multiple of 8 pixels */
>> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
>> index e76a6a85baa3..d9e5388ffeb5 100644
>> --- a/drivers/staging/media/imx/imx-media-csi.c
>> +++ b/drivers/staging/media/imx/imx-media-csi.c
>> @@ -33,8 +33,8 @@
>>    * has not requested planar formats, we should allow 8 pixel
>>    * alignment.
>>    */
>> -#define MIN_W       176
>> -#define MIN_H       144
>> +#define MIN_W       32
>> +#define MIN_H       32
>>   #define MAX_W      4096
>>   #define MAX_H      4096
>>   #define W_ALIGN    1 /* multiple of 2 pixels */
>> diff --git a/drivers/staging/media/imx/imx-media-vdic.c b/drivers/staging/media/imx/imx-media-vdic.c
>> index 0d83c2c41606..ee71b70d3544 100644
>> --- a/drivers/staging/media/imx/imx-media-vdic.c
>> +++ b/drivers/staging/media/imx/imx-media-vdic.c
>> @@ -49,8 +49,8 @@ struct vdic_pipeline_ops {
>>   /*
>>    * Min/Max supported width and heights.
>>    */
>> -#define MIN_W       176
>> -#define MIN_H       144
>> +#define MIN_W        32
>> +#define MIN_H        32
>>   #define MAX_W_VDIC  968
>>   #define MAX_H_VDIC 2048
>>   #define W_ALIGN    4 /* multiple of 16 pixels */
>>


      reply	other threads:[~2020-06-26 17:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 10:00 [PATCH] MEDIA-STAGING: Remove unneeded geometry restrictions from i.MX CSI driver Krzysztof Hałasa
2020-06-26  8:58 ` Philipp Zabel
2020-06-26 17:16   ` Steve Longerbeam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe1b792e-2cfd-f380-923c-457762280546@gmail.com \
    --to=slongerbeam@gmail.com \
    --cc=khalasa@piap.pl \
    --cc=linux-media@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).