From: Rui Miguel Silva <rmfrfs@gmail.com>
To: Chinmaya Krishnan Mahesh <chinmaya.mahesh@disroot.org>
Cc: Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: imx7-media-csi: Remove unneeded break after return
Date: Mon, 01 Jul 2019 10:44:07 +0100 [thread overview]
Message-ID: <m3o92egkd4.fsf@gmail.com> (raw)
In-Reply-To: <20190630034905.7124-1-chinmaya.mahesh@disroot.org>
Hi Chinmaya,
Thanks for your patch.
On Sun 30 Jun 2019 at 04:49, Chinmaya Krishnan Mahesh wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: break is not useful after a goto or return
but this is already fixed in the media subsystem tree, by a patch
from Fabio:
964fcacddf media: imx7-media-csi: Remove unneeded break
It is better to use that tree as reference for media fixes,
sometimes some are already fixed there.
Nevertheless many thanks for the patch.
---
Cheers,
Rui
>
> Signed-off-by: Chinmaya Krishnan Mahesh <chinmaya.mahesh@disroot.org>
> ---
> drivers/staging/media/imx/imx7-media-csi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
> index a708a0340eb1..c15acca1dc0d 100644
> --- a/drivers/staging/media/imx/imx7-media-csi.c
> +++ b/drivers/staging/media/imx/imx7-media-csi.c
> @@ -1021,7 +1021,6 @@ static int imx7_csi_try_fmt(struct imx7_csi *csi,
> break;
> default:
> return -EINVAL;
> - break;
> }
> return 0;
> }
prev parent reply other threads:[~2019-07-01 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-30 3:49 [PATCH] media: imx7-media-csi: Remove unneeded break after return Chinmaya Krishnan Mahesh
2019-07-01 9:44 ` Rui Miguel Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3o92egkd4.fsf@gmail.com \
--to=rmfrfs@gmail.com \
--cc=chinmaya.mahesh@disroot.org \
--cc=devel@driverdev.osuosl.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).