From: Takashi Iwai <tiwai@suse.de>
To: Sean Young <sean@mess.org>
Cc: Robert Foss <robert.foss@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media <linux-media@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Stefan Seyfried <seife+kernel@b1-systems.com>
Subject: Re: [PATCH 2/2] media: dvb-usb: Fix use-after-free access
Date: Mon, 01 Feb 2021 09:22:10 +0100 [thread overview]
Message-ID: <s5h4kiwjiz1.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210131150456.GB4886@gofer.mess.org>
On Sun, 31 Jan 2021 16:04:56 +0100,
Sean Young wrote:
>
> Hi Takashi,
>
> On Fri, Jan 22, 2021 at 04:47:44PM +0100, Robert Foss wrote:
> > Hey Takashi,
> >
> > This patch is generating a checkpatch warning, but I think it is
> > spurious and can be ignored.
>
> The checkpatch warning isn't superious and should really be corrected.
It's case-by-case, checkpatch is no bible by itself. In this
particular case, it was rather a false-positive of checkpatch: the
commit reference including a line-break.
This issue has been always annoying and I wish this will be dropped
from checkpatch in near future...
thanks,
Takashi
prev parent reply other threads:[~2021-02-01 8:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 10:20 [PATCH 0/2] media: dvb-usb: Fix UAF and memory leaks Takashi Iwai
2021-01-20 10:20 ` [PATCH 1/2] media: dvb-usb: Fix memory leak at error in dvb_usb_device_init() Takashi Iwai
2021-01-22 9:24 ` Robert Foss
2021-01-31 14:53 ` Sean Young
2021-02-01 8:18 ` Takashi Iwai
2021-01-20 10:20 ` [PATCH 2/2] media: dvb-usb: Fix use-after-free access Takashi Iwai
2021-01-22 15:47 ` Robert Foss
2021-01-31 15:04 ` Sean Young
2021-02-01 8:22 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4kiwjiz1.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robert.foss@linaro.org \
--cc=sean@mess.org \
--cc=seife+kernel@b1-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).