From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50E6FC11F66 for ; Wed, 14 Jul 2021 08:59:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A670613B2 for ; Wed, 14 Jul 2021 08:59:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238697AbhGNJCh (ORCPT ); Wed, 14 Jul 2021 05:02:37 -0400 Received: from mout.gmx.net ([212.227.15.18]:56161 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238643AbhGNJCh (ORCPT ); Wed, 14 Jul 2021 05:02:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1626253159; bh=2PfUJGsN5axf79lyK53KIfWRTeJoSiAoNWHeXAJAm5k=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=ABY8yG3fDvHwhdrriVKsu1KyjPfUEH6xW/YvrAHOvujzOyzGRKiy2dBPle0lASCBo FTWMIPLDMSj9FHlaeVcQrgMGGrer/+CivY/XZabcjrajrSEg47XuH1fqxYNRg+JEt2 SiesIqzE1N5MQ+lQmUEQdMz5rxcbFOtjxgepeOng= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [217.61.152.136] ([217.61.152.136]) by web-mail.gmx.net (3c-app-gmx-bs01.server.lan [172.19.170.50]) (via HTTP); Wed, 14 Jul 2021 10:59:18 +0200 MIME-Version: 1.0 Message-ID: From: Frank Wunderlich To: Yong Wu Cc: Matthias Brugger , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , David Airlie , Mauro Carvalho Chehab , Evan Green , Robin Murphy , Tomasz Figa , Will Deacon , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, yong.wu@mediatek.com, youlin.pei@mediatek.com, Nicolas Boichat , Matthias Kaehlcke , anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, acourbot@chromium.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Chun-Kuang Hu , Philipp Zabel , Xia Jiang , Tiffany Lin , Dafna Hirschfeld , Hsin-Yi Wang , Eizan Miyamoto , anthony.huang@mediatek.com Subject: Aw: [PATCH v6 00/11] Clean up "mediatek,larb" Content-Type: text/plain; charset=UTF-8 Date: Wed, 14 Jul 2021 10:59:18 +0200 Importance: normal Sensitivity: Normal In-Reply-To: <20210714025626.5528-1-yong.wu@mediatek.com> References: <20210714025626.5528-1-yong.wu@mediatek.com> X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K1:41hJo/XYrZUHIeMDY07beGhJR05vkLxAQITh9O1JknXiCDIPb9AnREzqsqzHICRgoA4aX +VAlF3wwHQHbYa/GGCgJhTDtD0i0iZcray5tchmyODDSQBszTPJ8Cg9gg9LgxbFhLS4m04MCLN53 ePdYFNXzAkr1Xvyf64zJFgpHrtCx3fhmT3LqyYxoT0nRDwTxV6UVaYlwijr3k0aNzY44Q9GNsnWw Rl3go4EBz7ULxN81eHdqgXx4wZX5M3IQyIamHA+xF+0G23a388+8tJIl3y+MV5whXMki3Iq+biLW UE= X-UI-Out-Filterresults: notjunk:1;V03:K0:xahsKhf98lg=:Wfje5JxpoANcTNbcmTtKVK VQ+rHW0jjkDG7cM+BrzCqPqYP/W7Q1dk67RH/jENaakUoczFwa3fW3FrkGIkE8iEXSDP0y+iX Ldkppn4aANbjhSEDBEcwvT/JR4ia055MyjoHgIDw88+R+pZWLJS5VDabeYDqYbhwvTccliZyp 5ZOuEK9y2I+3WEqlIALyq4H90JQRlgfv2JMXK56pxhm/7USMsR20jYWECfsusG0aKbfWKSz5l DweHDC9nwaC6TLxhY+erDIbE15qyYxQDlB3mCOEle1bWCQqyOpBxKxvqHPkumeUOCKawIEp+N wdipQ94TPhtjo1lRZS5NeaSPWtZb4TzF0NFu+y+MjaSaC9mfYnPsZ7fBDfdYIbpWV6mWQhsxD wLwxpA6JR7FJa8k18pWGpAdTza2yTr7xbLHQmSVtTQ6xb7z3THroUiIXpu9eKVDCgfVnNXN4k gXyfw7FdiODoTHjK2YhrS2kkJnqop7Ax4FkHKh6zy+U2b0n26wbcmU0Wfk40t5km0pwxw3f0q V4jMISUBOvceIBWVNxuZMPZoeeNJ/1lseOLpWgHlbK/WW6jpCTsRrH0JNTzxgM6S+e3jHL6IV qyt6ZSNcW2Itd4NQsDmMhdkCuz50nuyBKhtqniFkzqPf0W0aXDbpGcdmCtEm9oLaJ+QVfj2T0 KXiq7AM4wtYtVBe7EGPLR23WdO5yz7fSX4QQl0Q5E8wUUwWSGuVT84nIwpQjI8mhzfj1ilUg9 NEVw5SgEn/3reKMV4uhqInc6YYW6Lg5WwQCEP7w6nuVvmv4BZPcvE0PY02uVNxvYpTMQ79gVP w5SwTV/kfrKGrTloRp4qsuf31tzQ2KQVg0453IpWqKtLrpRlpM= Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi, sorry this (or the 2 depency-series) cause a NULL Pointer deref in iommu_g= roup_remove_device on mt7623/bpi-r2 i wonder why on bootup a cleanup is run, but have no hint about this. since "dts: mtk-mdp: remove mediatek, vpu property from primary MDP device= " all is good, i guess problem comes up while removing larb with DT this is backtrace [ 6.274465] PC is at iommu_group_remove_device+0x28/0x148 [ 6.279877] LR is at iommu_release_device+0x4c/0x70 [ 6.674347] Backtrace: [ 6.676797] [] (iommu_group_remove_device) from [] = (iomm) [ 6.686221] r7:00000000 r6:c06bf04c r5:c0d7a1ac r4:c21fc010 [ 6.691883] [] (iommu_release_device) from [] (remo= ve_io) [ 6.700689] r5:00000000 r4:00000000 [ 6.704265] [] (remove_iommu_group) from [] (bus_fo= r_eac) [ 6.712725] [] (bus_for_each_dev) from [] (bus_set_= iommu) [ 6.720753] r6:c331f440 r5:c1406f58 r4:ffffffea [ 6.725370] [] (bus_set_iommu) from [] (mtk_iommu_p= robe+) [ 6.733484] r7:c32db0b8 r6:c21f9c00 r5:c331f1c0 r4:00000000 [ 6.739145] [] (mtk_iommu_probe) from [] (platform_= probe) [ 6.747176] r10:c21f9c10 r9:c2496f54 r8:c14623b8 r7:c14623b8 r6:c1405b= 90 r50 [ 6.755012] r4:00000000 [ 6.757544] [] (platform_probe) from [] (really_pro= be.pa) [ 6.766006] r7:c14623b8 r6:c1405b90 r5:00000000 r4:c21f9c10 [ 6.771667] [] (really_probe.part.0) from [] (reall= y_pro) [ 6.779866] r7:c21f9c10 r6:c2549e74 r5:c1405b90 r4:c21f9c10 [ 6.785527] [] (really_probe) from [] (__driver_pro= be_de) [ 6.793984] r5:c1405b90 r4:c21f9c10 [ 6.797560] [] (__driver_probe_device) from [] (dri= ver_p) [ 6.806543] r9:c2496f54 r8:00000008 r7:c21f9c10 r6:c2549e74 r5:c14c6ec= 8 r4:4 [ 6.814291] [] (driver_probe_device) from [] (__dev= ice_a) [ 6.823448] r9:c2496f54 r8:00000000 r7:c21f9c10 r6:c2549e74 r5:c1405b9= 0 r4:1 [ 6.831196] [] (__device_attach_driver) from [] (bu= s_for) [ 6.840007] r7:c14623b8 r6:c073635c r5:c2549e74 r4:00000000 [ 6.845669] [] (bus_for_each_drv) from [] (__device= _atta) [ 6.854044] r6:00000001 r5:c21f9c54 r4:c21f9c10 [ 6.858662] [] (__device_attach) from [] (device_in= itial) [ 6.867207] r6:c21f9c10 r5:c1406f58 r4:c1406ca0 [ 6.871825] [] (device_initial_probe) from [] (bus_= probe) [ 6.880454] [] (bus_probe_device) from [] (deferred= _prob) bisect shows this commit as breaking: Author: Yong Wu Date: Wed Jul 14 10:56:17 2021 +0800 iommu/mediatek: Add probe_defer for smi-larb Prepare for adding device_link. regards Frank