From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CD1F18EC3 for ; Mon, 4 Mar 2024 09:33:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709544824; cv=none; b=dp7FabvLmve0eoH91dBpyIdZLJA/HZktcdCNNqrh1HoBu0SzhAzu9jb3fhofRLkM4RhljOGCvMkpAcAK7YSwq/dMz98h1sdS3MBdLUPb2MayiM0dHcmzBLiUbIVQxlKfSyqe5toSkNp986H3Non0KKHa7WVWVDgdmjb1x98qWo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709544824; c=relaxed/simple; bh=P999t+mKps2PCoHgqn4r6t0rU007o9bTwwMYcqRbGQo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PjJzadSU1QHjtxthjeE42acJ7XW+NAZRq8Y6rJ7bq+otaYW+d7uVUK/4Kw3CxvuaO5ZmhfSEJASExzVE6w8/f0N6RF1kH0C8pPv2qVEKcg5TTLLhKEfmhEO4oSA42V/IpfmwM5NBLDFgM27SxoYvLcnjTn1VHn8MYTsYZmR7xIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=Pqqj8PzZ; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Pqqj8PzZ" Received: from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 833373871; Mon, 4 Mar 2024 10:33:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1709544804; bh=P999t+mKps2PCoHgqn4r6t0rU007o9bTwwMYcqRbGQo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pqqj8PzZ43MATMUVMklwbGh3AYMT1+6+eJa49cG02wCiecpQz9N+5ujAfcaUAKNDN p9/1ozZc2MhUQlbfVRsE9fnfgor/aOde7QGxLSJdTmGWGoYQdhOXOqKzuP1Mo6iJ0Q /GKjcv0IIs5/u3bImPCAXoKGAtMH91ymOBZOHmS4= Date: Mon, 4 Mar 2024 10:33:37 +0100 From: Jacopo Mondi To: Laurent Pinchart Cc: linux-media@vger.kernel.org, Dave Stevenson , David Plowman , Jean-Michel Hautbois , Hans Verkuil , Naushir Patuck , Sakari Ailus , kernel-list@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v6 04/15] media: i2c: imx219: Report streams using frame descriptors Message-ID: References: <20240301213231.10340-1-laurent.pinchart@ideasonboard.com> <20240301213231.10340-5-laurent.pinchart@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240301213231.10340-5-laurent.pinchart@ideasonboard.com> Hi Laurent On Fri, Mar 01, 2024 at 11:32:19PM +0200, Laurent Pinchart wrote: > Implement the .get_frame_desc() subdev operation to report information > about streams to the connected CSI-2 receiver. This is required to let > the CSI-2 receiver driver know about virtual channels and data types for > each stream. > > Signed-off-by: Laurent Pinchart > --- > drivers/media/i2c/imx219.c | 67 ++++++++++++++++++++++++++++---------- > 1 file changed, 50 insertions(+), 17 deletions(-) > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > index 52afb821f667..6e0232b6772b 100644 > --- a/drivers/media/i2c/imx219.c > +++ b/drivers/media/i2c/imx219.c > @@ -23,6 +23,7 @@ > #include > #include > > +#include > #include > #include > #include > @@ -594,6 +595,24 @@ static void imx219_free_controls(struct imx219 *imx219) > * Subdev operations > */ > > +static int imx219_format_bpp(u32 code) This can be unsigned as the functions does not return errrors Reviewed-by: Jacopo Mondi > +{ > + switch (code) { > + case MEDIA_BUS_FMT_SRGGB8_1X8: > + case MEDIA_BUS_FMT_SGRBG8_1X8: > + case MEDIA_BUS_FMT_SGBRG8_1X8: > + case MEDIA_BUS_FMT_SBGGR8_1X8: > + return 8; > + > + case MEDIA_BUS_FMT_SRGGB10_1X10: > + case MEDIA_BUS_FMT_SGRBG10_1X10: > + case MEDIA_BUS_FMT_SGBRG10_1X10: > + case MEDIA_BUS_FMT_SBGGR10_1X10: > + default: > + return 10; > + } > +} > + > static int imx219_set_framefmt(struct imx219 *imx219, > struct v4l2_subdev_state *state) > { > @@ -605,23 +624,7 @@ static int imx219_set_framefmt(struct imx219 *imx219, > > format = v4l2_subdev_state_get_format(state, IMX219_PAD_SOURCE); > crop = v4l2_subdev_state_get_crop(state, IMX219_PAD_IMAGE); > - > - switch (format->code) { > - case MEDIA_BUS_FMT_SRGGB8_1X8: > - case MEDIA_BUS_FMT_SGRBG8_1X8: > - case MEDIA_BUS_FMT_SGBRG8_1X8: > - case MEDIA_BUS_FMT_SBGGR8_1X8: > - bpp = 8; > - break; > - > - case MEDIA_BUS_FMT_SRGGB10_1X10: > - case MEDIA_BUS_FMT_SGRBG10_1X10: > - case MEDIA_BUS_FMT_SGBRG10_1X10: > - case MEDIA_BUS_FMT_SBGGR10_1X10: > - default: > - bpp = 10; > - break; > - } > + bpp = imx219_format_bpp(format->code); > > cci_write(imx219->regmap, IMX219_REG_X_ADD_STA_A, > crop->left - IMX219_PIXEL_ARRAY_LEFT, &ret); > @@ -1031,6 +1034,35 @@ static int imx219_init_state(struct v4l2_subdev *sd, > return 0; > } > > +static int imx219_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad, > + struct v4l2_mbus_frame_desc *fd) > +{ > + const struct v4l2_mbus_framefmt *fmt; > + struct v4l2_subdev_state *state; > + u32 code; > + > + if (pad != IMX219_PAD_SOURCE) > + return -EINVAL; > + > + state = v4l2_subdev_lock_and_get_active_state(sd); > + fmt = v4l2_subdev_state_get_stream_format(state, IMX219_PAD_SOURCE, 0); > + code = fmt->code; > + v4l2_subdev_unlock_state(state); > + > + fd->type = V4L2_MBUS_FRAME_DESC_TYPE_CSI2; > + fd->num_entries = 1; > + > + memset(fd->entry, 0, sizeof(fd->entry)); > + > + fd->entry[0].pixelcode = code; > + fd->entry[0].stream = 0; > + fd->entry[0].bus.csi2.vc = 0; > + fd->entry[0].bus.csi2.dt = imx219_format_bpp(code) == 8 > + ? MIPI_CSI2_DT_RAW8 : MIPI_CSI2_DT_RAW10; > + > + return 0; > +} > + > static const struct v4l2_subdev_core_ops imx219_core_ops = { > .subscribe_event = v4l2_ctrl_subdev_subscribe_event, > .unsubscribe_event = v4l2_event_subdev_unsubscribe, > @@ -1046,6 +1078,7 @@ static const struct v4l2_subdev_pad_ops imx219_pad_ops = { > .set_fmt = imx219_set_pad_format, > .get_selection = imx219_get_selection, > .enum_frame_size = imx219_enum_frame_size, > + .get_frame_desc = imx219_get_frame_desc, > }; > > static const struct v4l2_subdev_ops imx219_subdev_ops = { > -- > Regards, > > Laurent Pinchart > >