From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5460C2BA19 for ; Mon, 6 Apr 2020 14:06:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9075C23433 for ; Mon, 6 Apr 2020 14:06:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s8e3ot3Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9075C23433 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P0bB1CEQBxPQO4qNmw6aF5r8AnAl8A1YWNT+leafcMM=; b=s8e3ot3QpPHBFsSyC3bekc6Ln /FjbHf3FnsHFt2bHS9j4CCPY0C1D5oNWt2bUIigxIGo2KlpzcRtdioOJbGiIVvfXpOapf6/2P1pAz iC6X0uRk7hV7FFSCAyVzUj5vOpYR9xRnys/mywp8Rs9lmvL+YZ2Pe/mc7f9NflxBwS0wlBgy75ib5 2Ku+g5UKKQ9t2nAhDu6XIZqKLd0aDUDE/UIiQ+kyjtrnkv6yu0NFvMNq1FoBoPqRsIn2uSjWu+m1J gZjCT4SJtA9R3hbjLdhw3OMbOXX94XTVMRX8isxsIGScvS616qIeMPglStCHTx+eQO5DJtg+7ShHT KKY8cU+0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLSO4-0000rq-0K; Mon, 06 Apr 2020 14:06:04 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLSNu-0000jH-PF; Mon, 06 Apr 2020 14:05:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1F809106F; Mon, 6 Apr 2020 07:05:53 -0700 (PDT) Received: from [10.37.12.4] (unknown [10.37.12.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EA1043F73D; Mon, 6 Apr 2020 07:05:42 -0700 (PDT) Subject: Re: [PATCH v5 2/5] OPP: refactor dev_pm_opp_of_register_em() and update related drivers To: Daniel Lezcano , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com References: <20200318114548.19916-1-lukasz.luba@arm.com> <20200318114548.19916-3-lukasz.luba@arm.com> <3ee5dc1a-fdfe-da17-9a62-a5182c1f4d3e@linaro.org> From: Lukasz Luba Message-ID: <00c839d1-2f03-2d3b-5746-95deae30bee3@arm.com> Date: Mon, 6 Apr 2020 15:05:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <3ee5dc1a-fdfe-da17-9a62-a5182c1f4d3e@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200406_070554_865608_A266B20A X-CRM114-Status: GOOD ( 15.28 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, bjorn.andersson@linaro.org, bsegall@google.com, festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org, khilman@kernel.org, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, mgorman@suse.de, rui.zhang@intel.com, alyssa.rosenzweig@collabora.com, orjan.eide@arm.com, daniel@ffwll.ch, b.zolnierkie@samsung.com, s.hauer@pengutronix.de, rostedt@goodmis.org, matthias.bgg@gmail.com, Dietmar.Eggemann@arm.com, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, qperret@google.com, sboyd@kernel.org, mka@chromium.org, rdunlap@infradead.org, rjw@rjwysocki.net, agross@kernel.org, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Daniel, Thank you for your comments. On 4/3/20 5:21 PM, Daniel Lezcano wrote: > On 18/03/2020 12:45, Lukasz Luba wrote: >> The Energy Model framework supports both: CPUs and devfreq devices. Drop >> the CPU specific interface with cpumask and add struct device. Add also a >> return value. This new interface provides easy way to create a simple >> Energy Model, which then might be used in i.e. thermal subsystem. > > This patch contains too many different changes. OK, I will create 4 patches: 1) change with new argument in API function: void dev_pm_opp_of_register_em(dev, cpumask) and updated drivers 2) changes with _get_cpu_power --> _get_power 3) changes adding int return in dev_pm_opp_of_register_em() and updating error handling path inside 4) header changes with new dev_pm_opp_of_unregister_em() > > There are fixes and traces added in addition to a function prototype change. > > Please provide patches separated by logical changes. I will try to make this API change in a safe way, which won't break cpufreq drivers compilation. > > If the cpumask is extracted in the underlying function > em_register_perf_domain() as suggested in the previous patch 1/5, > dev_pm_opp_of_register_em() can be struct device centric only. That would be ideal situation but unfortunately not possible to implement (as responded in 1/5). Regards, Lukasz _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek