From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: matthias.bgg@kernel.org, roger.lu@mediatek.com,
jia-wei.chang@mediatek.com
Cc: nfraprado@collabora.com, khilman@baylibre.com,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH 5/8] soc: mediatek: mtk-svs: Move SoC specific functions to new files
Date: Thu, 29 Sep 2022 10:26:10 +0200 [thread overview]
Message-ID: <050439a2-bd54-54ec-10da-ff8d3a2b50ca@collabora.com> (raw)
In-Reply-To: <20220928155519.31977-6-matthias.bgg@kernel.org>
Il 28/09/22 17:55, matthias.bgg@kernel.org ha scritto:
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> With every SoC added to the driver, it grows. Move SoC specific
> callbacks to a new source files.
>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>
> drivers/soc/mediatek/Makefile | 3 +-
> drivers/soc/mediatek/mt8183-svs.h | 113 ++++
> drivers/soc/mediatek/mt8192-svs.h | 64 ++
> drivers/soc/mediatek/mtk-svs-mt8183.c | 234 ++++++++
> drivers/soc/mediatek/mtk-svs-mt8192.c | 100 ++++
> drivers/soc/mediatek/mtk-svs.c | 831 ++------------------------
> drivers/soc/mediatek/mtk-svs.h | 279 +++++++++
> 7 files changed, 837 insertions(+), 787 deletions(-)
> create mode 100644 drivers/soc/mediatek/mt8183-svs.h
> create mode 100644 drivers/soc/mediatek/mt8192-svs.h
> create mode 100644 drivers/soc/mediatek/mtk-svs-mt8183.c
> create mode 100644 drivers/soc/mediatek/mtk-svs-mt8192.c
> create mode 100644 drivers/soc/mediatek/mtk-svs.h
>
> diff --git a/drivers/soc/mediatek/Makefile b/drivers/soc/mediatek/Makefile
> index 0e9e703c931a..851131638644 100644
> --- a/drivers/soc/mediatek/Makefile
> +++ b/drivers/soc/mediatek/Makefile
> @@ -7,4 +7,5 @@ obj-$(CONFIG_MTK_SCPSYS) += mtk-scpsys.o
> obj-$(CONFIG_MTK_SCPSYS_PM_DOMAINS) += mtk-pm-domains.o
> obj-$(CONFIG_MTK_MMSYS) += mtk-mmsys.o
> obj-$(CONFIG_MTK_MMSYS) += mtk-mutex.o
> -obj-$(CONFIG_MTK_SVS) += mtk-svs.o
> +mtk_svs-objs := mtk-svs.o mtk-svs-mt8183.o mtk-svs-mt8192.o
> +obj-$(CONFIG_MTK_SVS) += mtk_svs.o
> diff --git a/drivers/soc/mediatek/mt8183-svs.h b/drivers/soc/mediatek/mt8183-svs.h
> new file mode 100644
> index 000000000000..89c0deb9fb11
> --- /dev/null
> +++ b/drivers/soc/mediatek/mt8183-svs.h
> @@ -0,0 +1,113 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +
> +#ifndef __DRV_SVS_MT8183_H
> +#define __DRV_SVS_MT8183_H
> +
Please avoid implicit header inclusion (here and in mt8192-svs.h).
#include "mtk-svs.h"
Cheers,
Angelo
next prev parent reply other threads:[~2022-09-29 8:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 15:55 [PATCH 0/8] soc: mediatek: mtk-svs: refactor and cleanup the driver matthias.bgg
2022-09-28 15:55 ` [PATCH 1/8] soc: mediatek: mtk-svs: clean up platform probing matthias.bgg
2022-09-29 8:25 ` AngeloGioacchino Del Regno
2022-09-28 15:55 ` [PATCH 2/8] soc: mediatek: mtk-svs: improve readability of platform_probe matthias.bgg
2022-09-29 8:25 ` AngeloGioacchino Del Regno
2022-09-28 15:55 ` [PATCH 3/8] soc: mediatek: mtk-svs: move svs_platform_probe into probe matthias.bgg
2022-09-29 8:25 ` AngeloGioacchino Del Regno
2022-09-28 15:55 ` [PATCH 4/8] soc: mediatek: mtk-svs: delete superfluous platform data entries matthias.bgg
2022-09-29 8:25 ` AngeloGioacchino Del Regno
2022-10-06 11:43 ` Roger Lu
2022-09-28 15:55 ` [PATCH 5/8] soc: mediatek: mtk-svs: Move SoC specific functions to new files matthias.bgg
2022-09-29 8:26 ` AngeloGioacchino Del Regno [this message]
2022-10-06 11:43 ` Roger Lu
2022-09-28 15:55 ` [PATCH 6/8] soc: mtk-svs: mt8183: Move thermal parsing in new function matthias.bgg
2022-09-29 8:26 ` AngeloGioacchino Del Regno
2022-09-28 15:55 ` [PATCH 7/8] soc: mtk-svs: mt8183: refactor o_slope calculation matthias.bgg
2022-09-28 15:55 ` [PATCH 8/8] soc: mtk-svs: mt8192: fix bank data matthias.bgg
2022-09-29 8:26 ` AngeloGioacchino Del Regno
2022-10-06 11:43 ` Roger Lu
2022-10-06 11:43 ` [PATCH 0/8] soc: mediatek: mtk-svs: refactor and cleanup the driver Roger Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=050439a2-bd54-54ec-10da-ff8d3a2b50ca@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=jia-wei.chang@mediatek.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=roger.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).