Linux-mediatek Archive on lore.kernel.org
 help / color / Atom feed
From: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Jassi Brar <jassisinghbrar@gmail.com>
Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com,
	linux-kernel@vger.kernel.org,
	Houlong Wei <houlong.wei@mediatek.com>,
	Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>,
	linux-mediatek@lists.infradead.org,
	Bibby Hsieh <bibby.hsieh@mediatek.com>,
	CK Hu <ck.hu@mediatek.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 09/14] soc: mediatek: cmdq: add read_s function
Date: Wed, 27 Nov 2019 09:58:52 +0800
Message-ID: <1574819937-6246-11-git-send-email-dennis-yc.hsieh@mediatek.com> (raw)
In-Reply-To: <1574819937-6246-1-git-send-email-dennis-yc.hsieh@mediatek.com>

Add read_s function in cmdq helper functions which support read value from
register or dma physical address into gce internal register.

Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
---
 drivers/soc/mediatek/mtk-cmdq-helper.c   | 20 ++++++++++++++++++++
 include/linux/mailbox/mtk-cmdq-mailbox.h |  1 +
 include/linux/soc/mediatek/mtk-cmdq.h    | 10 ++++++++++
 3 files changed, 31 insertions(+)

diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index 2edbc0954d97..2cd693e34980 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -231,6 +231,26 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys,
 }
 EXPORT_SYMBOL(cmdq_pkt_write_mask);
 
+int cmdq_pkt_read_s(struct cmdq_pkt *pkt, phys_addr_t addr, u16 reg_idx)
+{
+	struct cmdq_instruction inst = { {0} };
+	int err;
+	const u16 src_reg_idx = CMDQ_SPR_TEMP;
+
+	err = cmdq_pkt_assign(pkt, src_reg_idx, CMDQ_ADDR_HIGH(addr));
+	if (err < 0)
+		return err;
+
+	inst.op = CMDQ_CODE_READ_S;
+	inst.dst_t = CMDQ_REG_TYPE;
+	inst.sop = src_reg_idx;
+	inst.reg_dst = reg_idx;
+	inst.arg_b = CMDQ_ADDR_LOW(addr);
+
+	return cmdq_pkt_append_command(pkt, inst);
+}
+EXPORT_SYMBOL(cmdq_pkt_read_s);
+
 int cmdq_pkt_write_s(struct cmdq_pkt *pkt, phys_addr_t addr, u16 reg_idx,
 		     u32 mask)
 {
diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h
index 8ef87e1bd03b..3f6bc0dfd5da 100644
--- a/include/linux/mailbox/mtk-cmdq-mailbox.h
+++ b/include/linux/mailbox/mtk-cmdq-mailbox.h
@@ -59,6 +59,7 @@ enum cmdq_code {
 	CMDQ_CODE_JUMP = 0x10,
 	CMDQ_CODE_WFE = 0x20,
 	CMDQ_CODE_EOC = 0x40,
+	CMDQ_CODE_READ_S = 0x80,
 	CMDQ_CODE_WRITE_S = 0x90,
 	CMDQ_CODE_WRITE_S_MASK = 0x91,
 	CMDQ_CODE_LOGIC = 0xa0,
diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h
index 56ff1970197c..bc28a41d7780 100644
--- a/include/linux/soc/mediatek/mtk-cmdq.h
+++ b/include/linux/soc/mediatek/mtk-cmdq.h
@@ -106,6 +106,16 @@ int cmdq_pkt_write(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value);
 int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys,
 			u16 offset, u32 value, u32 mask);
 
+/**
+ * cmdq_pkt_read_s() - append read_s command to the CMDQ packet
+ * @pkt:	the CMDQ packet
+ * @addr:	the physical address of register or dma to read
+ * @reg_idx:	the CMDQ internal register ID to cache read data
+ *
+ * Return: 0 for success; else the error code is returned
+ */
+int cmdq_pkt_read_s(struct cmdq_pkt *pkt, phys_addr_t addr, u16 reg_idx);
+
 /**
  * cmdq_pkt_write_s_mask() - append write_s command to the CMDQ packet
  * @pkt:	the CMDQ packet
-- 
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  parent reply index

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27  1:58 [PATCH v2] support gce on mt6779 platform Dennis YC Hsieh
2019-11-27  1:58 ` [PATCH v2 00/14] " Dennis YC Hsieh
2019-11-27  1:58 ` [PATCH v2 01/14] dt-binding: gce: add gce header file for mt6779 Dennis YC Hsieh
2019-12-05 20:37   ` Rob Herring
2019-11-27  1:58 ` [PATCH v2 02/14] mailbox: cmdq: variablize address shift in platform Dennis YC Hsieh
2019-12-10  1:55   ` CK Hu
2019-12-12  1:03     ` Dennis-YC Hsieh
2019-11-27  1:58 ` [PATCH v2 03/14] mailbox: cmdq: support mt6779 gce platform definition Dennis YC Hsieh
2019-12-10  2:04   ` CK Hu
2019-11-27  1:58 ` [PATCH v2 04/14] mailbox: mediatek: cmdq: clear task in channel before shutdown Dennis YC Hsieh
2019-12-10  2:49   ` CK Hu
2019-12-12  1:13     ` Dennis-YC Hsieh
2019-12-12  1:31       ` CK Hu
2019-12-12  1:51         ` Dennis-YC Hsieh
2019-12-12  2:03           ` CK Hu
2019-12-12  2:20             ` Dennis-YC Hsieh
2019-11-27  1:58 ` [PATCH v2 05/14] arm64: dts: add gce node for mt6779 Dennis YC Hsieh
2019-12-06  4:05   ` Bibby Hsieh
2019-11-27  1:58 ` [PATCH v2 06/14] soc: mediatek: cmdq: return send msg error code Dennis YC Hsieh
2019-12-06  4:02   ` Bibby Hsieh
2019-12-18  8:00     ` Dennis-YC Hsieh
2019-12-18  8:14       ` Bibby Hsieh
2019-11-27  1:58 ` [PATCH v2 07/14] soc: mediatek: cmdq: add assign function Dennis YC Hsieh
2019-12-10  3:24   ` CK Hu
2019-12-12  1:15     ` Dennis-YC Hsieh
2019-11-27  1:58 ` [PATCH v2 08/14] soc: mediatek: cmdq: add write_s function Dennis YC Hsieh
2019-12-10  5:18   ` CK Hu
2019-12-12  1:31     ` Dennis-YC Hsieh
2019-12-10  7:35   ` Bibby Hsieh
2019-12-12  1:31     ` Dennis-YC Hsieh
2019-11-27  1:58 ` Dennis YC Hsieh [this message]
2019-12-10  7:55   ` [PATCH v2 09/14] soc: mediatek: cmdq: add read_s function CK Hu
2019-12-12  1:33     ` Dennis-YC Hsieh
2019-11-27  1:58 ` [PATCH v2 10/14] soc: mediatek: cmdq: add write_s value function Dennis YC Hsieh
2019-11-27  1:58 ` [PATCH v2 11/14] soc: mediatek: cmdq: export finalize function Dennis YC Hsieh
2019-12-10  7:50   ` CK Hu
2019-11-27  1:58 ` [PATCH v2 12/14] soc: mediatek: cmdq: add loop function Dennis YC Hsieh
2019-12-11  1:48   ` CK Hu
2019-12-12  1:37     ` Dennis-YC Hsieh
2019-11-27  1:58 ` [PATCH v2 13/14] soc: mediatek: cmdq: add wait no clear event function Dennis YC Hsieh
2019-12-11  2:04   ` CK Hu
2019-12-12  1:42     ` Dennis-YC Hsieh
2019-11-27  1:58 ` [PATCH v2 14/14] soc: mediatek: cmdq: add set " Dennis YC Hsieh

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1574819937-6246-11-git-send-email-dennis-yc.hsieh@mediatek.com \
    --to=dennis-yc.hsieh@mediatek.com \
    --cc=bibby.hsieh@mediatek.com \
    --cc=ck.hu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=houlong.wei@mediatek.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mediatek Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mediatek/0 linux-mediatek/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mediatek linux-mediatek/ https://lore.kernel.org/linux-mediatek \
		linux-mediatek@lists.infradead.org
	public-inbox-index linux-mediatek

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mediatek


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git