From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8552C43603 for ; Fri, 6 Dec 2019 04:03:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3D212464E for ; Fri, 6 Dec 2019 04:03:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NA9EMxIe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="je2GzQ3w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3D212464E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I4LTyztY8yqf40zdbSDW66INt31fZrtuA13D6vA3E28=; b=NA9EMxIes4Y8vV aoAHOdmTpShMQRGsfiBwicDczcyhkWg/BTfIT8IVrBUTKRolK0HIGfkQ+BM9pKrK7tSZcqkW0k6vW ivvrvvOp9Pp1mL4860+HYY1yj5+5ad6QvcnZvtjsHVniA10QzmTT7A795xCrrTZZSMh/eCqP2DdPQ 81ArPEhlSQvmphkJG59eoLO2+ZAjEndD3ElCxsmy+YDChpEMI8keDNhZ15/kF6tWcF6yjO7Xn5+0r VkMWDd8f89jy2JVYrNT4F3RydJr3MW9hsNTxCRcHPdpEUNNinsps9GZ5c8sTtJzvhAASC1ha4wt3V xRMwR29kdNpgjECEJ2jA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1id4pc-0003I2-4B; Fri, 06 Dec 2019 04:03:04 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1id4pU-0003CJ-DI; Fri, 06 Dec 2019 04:02:57 +0000 X-UUID: 226768999fd942c885a98923d63a7edc-20191205 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=xM1L7Jfwq/gv/BGLE5pId5BVEEmzAIvJRnTMFQtcXVo=; b=je2GzQ3w3wIwOGnb46+d1zPcyyvWnRWZMqZfYDE8fPemc+HUV6fCuras15LohSMUMJncbRVFqO7f28eTDB2OLKvZabOlwoT2Rh0mvtOEqPn/fwwIOfBSpRsgkaG8nk88xB4jr2DyGptKNOxZuHFYexnGYp757QUS91gCIlYQFzI=; X-UUID: 226768999fd942c885a98923d63a7edc-20191205 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 786847033; Thu, 05 Dec 2019 20:02:49 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 5 Dec 2019 20:03:41 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Dec 2019 12:02:33 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 6 Dec 2019 12:02:32 +0800 Message-ID: <1575604966.6151.1.camel@mtksdaap41> Subject: Re: [PATCH v2 06/14] soc: mediatek: cmdq: return send msg error code From: Bibby Hsieh To: Dennis YC Hsieh Date: Fri, 6 Dec 2019 12:02:46 +0800 In-Reply-To: <1574819937-6246-8-git-send-email-dennis-yc.hsieh@mediatek.com> References: <1574819937-6246-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574819937-6246-8-git-send-email-dennis-yc.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191205_200256_456633_8AF68024 X-CRM114-Status: GOOD ( 11.85 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , CK Hu , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Archived-At: List-Archive: On Wed, 2019-11-27 at 09:58 +0800, Dennis YC Hsieh wrote: > Return error code to client if send message fail, > so that client has chance to error handling. > This patches seems like a fix patch. Please add fixes, thanks. Bibby > Signed-off-by: Dennis YC Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 274f6f311d05..8421b4090304 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -353,11 +353,11 @@ int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb, > spin_unlock_irqrestore(&client->lock, flags); > } > > - mbox_send_message(client->chan, pkt); > + err = mbox_send_message(client->chan, pkt); > /* We can send next packet immediately, so just call txdone. */ > mbox_client_txdone(client->chan, 0); > > - return 0; > + return err; > } > EXPORT_SYMBOL(cmdq_pkt_flush_async); > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek