From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A3C2C2D0C4 for ; Wed, 11 Dec 2019 02:05:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1535620836 for ; Wed, 11 Dec 2019 02:05:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OaEplxR8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="VY3oVp/k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1535620836 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iEfSyYZsheWlB/zWKp6ypYGvNmZ+zkOQgkBw5Wyomoo=; b=OaEplxR8bMTOTw 3xkWQFomMR+9MAp5uERL1X+IXMITAI5nbNzgs8imw5+JkvwnIL3ka37bZuN+BJeYBii+fKQsVwCo6 cbiXno0mqH5do87i4NXHwm7JplHgpW/1cTta2XGkc3Hz+c/di5oFmb/ot+9uaE8iAr67KLeawnee+ GxHZjT62gLaUgfwKUjA/i+Lh8WHh/dIndT6C+VSfN4DB2J7LrxWR2K+YLyiv0GdDYco+PPp68XRZC nrASpjwbmDtX2BPDUdM903A9qQGNcRCbNlVl633/4CKjt5P7RxyEsKq0w+XV9T69wrRYuOZXYUpCM sXGmhF6nEKg5EwHv68Uw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ierNO-0002YP-5e; Wed, 11 Dec 2019 02:05:18 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ierN6-000197-Lp; Wed, 11 Dec 2019 02:05:02 +0000 X-UUID: b34ea2cb1f1047e3987e63d7b74740ca-20191210 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=wg0RWtXnuazbnyWqaYUsInjXzTF5INnndGMTSvzSNXg=; b=VY3oVp/kL+4z2JOIh6bbMIsWlTardtrptRq8k9S4xbwlHMFQhmFX6w1QBYXwA4lPtmAOBafnMXubU2L5qZncv3+adK1yTBkxszBKyb7X1+KbwN9wdT+5UAnkAqyyIE7/RrSrkfKFhR1P8neRM0mH7qGyXWVTwSlhjrWfoAfzhFU=; X-UUID: b34ea2cb1f1047e3987e63d7b74740ca-20191210 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 929821085; Tue, 10 Dec 2019 18:04:58 -0800 Received: from mtkmbs08n1.mediatek.inc (172.21.101.55) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 10 Dec 2019 18:05:59 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Dec 2019 10:04:22 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 11 Dec 2019 10:04:43 +0800 Message-ID: <1576029887.19653.17.camel@mtksdaap41> Subject: Re: [PATCH v2 13/14] soc: mediatek: cmdq: add wait no clear event function From: CK Hu To: Dennis YC Hsieh Date: Wed, 11 Dec 2019 10:04:47 +0800 In-Reply-To: <1574819937-6246-15-git-send-email-dennis-yc.hsieh@mediatek.com> References: <1574819937-6246-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574819937-6246-15-git-send-email-dennis-yc.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191210_180500_720670_64C0F5CC X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Dennis: On Wed, 2019-11-27 at 09:58 +0800, Dennis YC Hsieh wrote: > Add wait no clear event function in cmdq helper functions to wait specific > event without clear to 0 after receive it. > > Signed-off-by: Dennis YC Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 15 +++++++++++++++ > include/linux/soc/mediatek/mtk-cmdq.h | 10 ++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 10a9b4481e58..6f270fadfb50 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -330,6 +330,21 @@ int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event) > } > EXPORT_SYMBOL(cmdq_pkt_wfe); > > +int cmdq_pkt_wait_no_clear(struct cmdq_pkt *pkt, u16 event) > +{ > + struct cmdq_instruction inst = { {0} }; > + > + if (event >= CMDQ_MAX_EVENT) > + return -EINVAL; > + > + inst.op = CMDQ_CODE_WFE; > + inst.value = CMDQ_WFE_WAIT | CMDQ_WFE_WAIT_VALUE; > + inst.event = event; > + > + return cmdq_pkt_append_command(pkt, inst); > +} > +EXPORT_SYMBOL(cmdq_pkt_wait_no_clear); So the wait command has two version, one is wait and then clear event, another is wait and not clear event. The name of cmdq_pkt_wfe() is 'wait for event', so it's trivial that we think it does not clear event. I've three suggestion for this: 1. Let cmdq_pkt_wfe() wait and not clear event, and cmdq_pkt_wfe_clear_event() wait and clear event. or 2. Let cmdq_pkt_wfe() has a parameter to indicate that clear event or not after wait. or 3. Let cmdq_pkt_wfe() wait and not clear event, and not provide wait and clear event version. For DRM and MDP, I think both just need wait and not clear event. Regards, CK > + > int cmdq_pkt_clear_event(struct cmdq_pkt *pkt, u16 event) > { > struct cmdq_instruction inst = { {0} }; > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > index d15d8c941992..40bc61ad8d31 100644 > --- a/include/linux/soc/mediatek/mtk-cmdq.h > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > @@ -149,6 +149,16 @@ int cmdq_pkt_write_s_value(struct cmdq_pkt *pkt, dma_addr_t addr, > */ > int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event); > > +/** > + * cmdq_pkt_wait_no_clear() - Append wait for event command to the CMDQ packet, > + * without update event to 0 after receive it. > + * @pkt: the CMDQ packet > + * @event: the desired event type to wait > + * > + * Return: 0 for success; else the error code is returned > + */ > +int cmdq_pkt_wait_no_clear(struct cmdq_pkt *pkt, u16 event); > + > /** > * cmdq_pkt_clear_event() - append clear event command to the CMDQ packet > * @pkt: the CMDQ packet _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek