From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A6A2C43603 for ; Thu, 12 Dec 2019 02:22:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E29320652 for ; Thu, 12 Dec 2019 02:22:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GGiZDrx7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="YfzqF2gB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E29320652 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KybKAQo7LkhWixIXO4/yS2vhppHUyIVi90BovZjqoWo=; b=GGiZDrx7+342rV /tCwFl2YeJhNoNZhUc64nQfRVTsjghRn2TicmULcliBH3PQhaSyFZzEDD/jQQcXGE2bq3Rm4DjoCu 7pghijt3Yw8pcb7/c1LVBA6sZ2W+iMGHMKRJnqTZaHCn8Q0+wLp8mujliJiNfYQr02HtGnlN23fev BVSU1WQ5JYKdBKMo6RMIP+YS8aotSmeMS+Y2kNgFpmCIVpMurjxFYBatrd8Z+5ZXQvhVqemLhEXJ2 ZoQCT1NhU5NS3TNwxAzejmJ1C1pTmvFSSGzg7L3IVhwODiPJvkAWFMGe/5l6kb+K6Nvg7Dqp8FO1R 2rv6vd+SbR53D7KGmdPw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifE7c-0004Yy-1a; Thu, 12 Dec 2019 02:22:32 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifE7S-0004Qy-V9; Thu, 12 Dec 2019 02:22:24 +0000 X-UUID: 1e6653d561154131aa0d9ab3f4eaf1e1-20191211 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=9c+CKJCw7ds62qe6zhspsMPOjl/4Hp7ooomuS+RoEEI=; b=YfzqF2gBK9cOf3P5+RyjdFs2uoFb9Bzn0jlneCtjpAaRPkqAU+238zimE7sJYgpLtNzYIf8AqphROllQ0il8eJEu+OgkH0YYFBy/wziUGpGE4FmhXkygG0dh1hTAIpkVm2ExDxRGT0um+URS5a9BZYn/hnl18fkE4MF/5c0Hmp4=; X-UUID: 1e6653d561154131aa0d9ab3f4eaf1e1-20191211 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 498437813; Wed, 11 Dec 2019 18:22:20 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Dec 2019 18:20:43 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Dec 2019 10:20:06 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 12 Dec 2019 10:19:58 +0800 Message-ID: <1576117225.21687.6.camel@mtkswgap22> Subject: Re: [PATCH v2 04/14] mailbox: mediatek: cmdq: clear task in channel before shutdown From: Dennis-YC Hsieh To: CK Hu Date: Thu, 12 Dec 2019 10:20:25 +0800 In-Reply-To: <1576116202.16444.4.camel@mtksdaap41> References: <1574819937-6246-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574819937-6246-6-git-send-email-dennis-yc.hsieh@mediatek.com> <1575946181.16676.4.camel@mtksdaap41> <1576113221.17653.6.camel@mtkswgap22> <1576114297.11762.1.camel@mtksdaap41> <1576115494.17653.21.camel@mtkswgap22> <1576116202.16444.4.camel@mtksdaap41> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191211_182223_011370_3ACC6D72 X-CRM114-Status: GOOD ( 17.95 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi CK, On Thu, 2019-12-12 at 10:03 +0800, CK Hu wrote: > Hi, Dennis: > > On Thu, 2019-12-12 at 09:51 +0800, Dennis-YC Hsieh wrote: > > Hi CK, > > > > On Thu, 2019-12-12 at 09:31 +0800, CK Hu wrote: > > > Hi, Dennis: > > > > > > On Thu, 2019-12-12 at 09:13 +0800, Dennis-YC Hsieh wrote: > > > > Hi CK, > > > > > > > > On Tue, 2019-12-10 at 10:49 +0800, CK Hu wrote: > > > > > Hi, Dennis: > > > > > > > > > > On Wed, 2019-11-27 at 09:58 +0800, Dennis YC Hsieh wrote: > > > > > > Do success callback in channel when shutdown. For those task not finish, > > > > > > callback with error code thus client has chance to cleanup or reset. > > > > > > > > > > > > Signed-off-by: Dennis YC Hsieh > > > > > > --- > > > > > > drivers/mailbox/mtk-cmdq-mailbox.c | 26 ++++++++++++++++++++++++++ > > > > > > 1 file changed, 26 insertions(+) > > > > > > > > > > > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > > > > > > index fd519b6f518b..c12a768d1175 100644 > > > > > > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > > > > > > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > > > > > > @@ -450,6 +450,32 @@ static int cmdq_mbox_startup(struct mbox_chan *chan) > > > > > > > > > > > > static void cmdq_mbox_shutdown(struct mbox_chan *chan) > > > > > > { > > > > > > + struct cmdq_thread *thread = (struct cmdq_thread *)chan->con_priv; > > > > > > + struct cmdq *cmdq = dev_get_drvdata(chan->mbox->dev); > > > > > > + struct cmdq_task *task, *tmp; > > > > > > + unsigned long flags; > > > > > > + > > > > > > + spin_lock_irqsave(&thread->chan->lock, flags); > > > > > > + if (list_empty(&thread->task_busy_list)) > > > > > > + goto done; > > > > > > + > > > > > > + WARN_ON(cmdq_thread_suspend(cmdq, thread) < 0); > > > > > > + > > > > > > + /* make sure executed tasks have success callback */ > > > > > > + cmdq_thread_irq_handler(cmdq, thread); > > > > > > + if (list_empty(&thread->task_busy_list)) > > > > > > + goto done; > > > > > > + > > > > > > + list_for_each_entry_safe(task, tmp, &thread->task_busy_list, > > > > > > + list_entry) { > > > > > > + cmdq_task_exec_done(task, -ECONNABORTED); > > > > > > + kfree(task); > > > > > > + } > > > > > > + > > > > > > + cmdq_thread_disable(cmdq, thread); > > > > > > + clk_disable(cmdq->clock); > > > > > > +done: > > > > > > > > > > cmdq_thread_resume(thread); > > > > > > > > > > Regards, > > > > > CK > > > > > > > > > > > > > Call resume here will cause violation. The thread->task_busy_list empty > > > > means no task work in gce and thread state should already disable > > > > without clock, which is what we want since client try to shut down this > > > > mbox channel. So I think we don't need resume here. > > > > > > > > > > OK. When client free channel, thread is suspended. Then client request > > > channel, where do you resume thread? > > > > > > > when client send new pkt to new channel, cmdq_mbox_send_data() will > > enable thread. > > in cmdq_mbox_send_data(), it would run below command: > > WARN_ON(clk_enable(cmdq->clock) < 0); > WARN_ON(cmdq_thread_reset(cmdq, thread) < 0); > > writel(task->pa_base, thread->base + CMDQ_THR_CURR_ADDR); > writel(task->pa_base + pkt->cmd_buf_size, > thread->base + CMDQ_THR_END_ADDR); > writel(thread->priority, thread->base + CMDQ_THR_PRIORITY); > writel(CMDQ_THR_IRQ_EN, thread->base + CMDQ_THR_IRQ_ENABLE); > writel(CMDQ_THR_ENABLED, thread->base + CMDQ_THR_ENABLE_TASK); > > Do you mean CMDQ_THR_ENABLE_TASK is set to CMDQ_THR_ENABLED, then > CMDQ_THR_SUSPEND_TASK would be automatically set to CMDQ_THR_RESUME? If > this hardware work in so special behavior, please add comment for this. > > Regards, > CK > sorry for not clearly explain before call to cmdq_thread_reset() will reset thread status, which include suspend state. the CMDQ_THR_SUSPEND_TASK will be clear after reset, thus we can simply set CMDQ_THR_ENABLE_TASK to CMDQ_THR_ENABLED and then thread running again. I will add comment in both cmdq_mbox_send_data() and cmdq_mbox_shutdown() to clarify this hardware behavior. Regards, Dennis > > > > > > Regards, > > Dennis > > > > > Regards, > > > CK > > > > > > > > > > > Regards, > > > > Dennis > > > > > > > > > > + spin_unlock_irqrestore(&thread->chan->lock, flags); > > > > > > } > > > > > > > > > > > > static const struct mbox_chan_ops cmdq_mbox_chan_ops = { > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek