From: Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>
Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com,
Jassi Brar <jassisinghbrar@gmail.com>,
linux-kernel@vger.kernel.org,
Houlong Wei <houlong.wei@mediatek.com>,
CK Hu <ck.hu@mediatek.com>, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 06/14] soc: mediatek: cmdq: return send msg error code
Date: Wed, 18 Dec 2019 16:00:06 +0800
Message-ID: <1576656006.5933.3.camel@mtkswgap22> (raw)
In-Reply-To: <1575604966.6151.1.camel@mtksdaap41>
Hi Bibby,
On Fri, 2019-12-06 at 12:02 +0800, Bibby Hsieh wrote:
> On Wed, 2019-11-27 at 09:58 +0800, Dennis YC Hsieh wrote:
> > Return error code to client if send message fail,
> > so that client has chance to error handling.
> >
> This patches seems like a fix patch.
> Please add fixes, thanks.
>
> Bibby
Do you mean add *fixes* in title?
How about *fixes flush async function return error when send fail* ?
Regards,
Dennis
> > Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
> > ---
> > drivers/soc/mediatek/mtk-cmdq-helper.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> > index 274f6f311d05..8421b4090304 100644
> > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> > @@ -353,11 +353,11 @@ int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb,
> > spin_unlock_irqrestore(&client->lock, flags);
> > }
> >
> > - mbox_send_message(client->chan, pkt);
> > + err = mbox_send_message(client->chan, pkt);
> > /* We can send next packet immediately, so just call txdone. */
> > mbox_client_txdone(client->chan, 0);
> >
> > - return 0;
> > + return err;
> > }
> > EXPORT_SYMBOL(cmdq_pkt_flush_async);
> >
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply index
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 1:58 [PATCH v2] support gce on mt6779 platform Dennis YC Hsieh
2019-11-27 1:58 ` [PATCH v2 00/14] " Dennis YC Hsieh
2019-11-27 1:58 ` [PATCH v2 01/14] dt-binding: gce: add gce header file for mt6779 Dennis YC Hsieh
2019-12-05 20:37 ` Rob Herring
2019-11-27 1:58 ` [PATCH v2 02/14] mailbox: cmdq: variablize address shift in platform Dennis YC Hsieh
2019-12-10 1:55 ` CK Hu
2019-12-12 1:03 ` Dennis-YC Hsieh
2019-11-27 1:58 ` [PATCH v2 03/14] mailbox: cmdq: support mt6779 gce platform definition Dennis YC Hsieh
2019-12-10 2:04 ` CK Hu
2019-11-27 1:58 ` [PATCH v2 04/14] mailbox: mediatek: cmdq: clear task in channel before shutdown Dennis YC Hsieh
2019-12-10 2:49 ` CK Hu
2019-12-12 1:13 ` Dennis-YC Hsieh
2019-12-12 1:31 ` CK Hu
2019-12-12 1:51 ` Dennis-YC Hsieh
2019-12-12 2:03 ` CK Hu
2019-12-12 2:20 ` Dennis-YC Hsieh
2019-11-27 1:58 ` [PATCH v2 05/14] arm64: dts: add gce node for mt6779 Dennis YC Hsieh
2019-12-06 4:05 ` Bibby Hsieh
2019-11-27 1:58 ` [PATCH v2 06/14] soc: mediatek: cmdq: return send msg error code Dennis YC Hsieh
2019-12-06 4:02 ` Bibby Hsieh
2019-12-18 8:00 ` Dennis-YC Hsieh [this message]
2019-12-18 8:14 ` Bibby Hsieh
2019-11-27 1:58 ` [PATCH v2 07/14] soc: mediatek: cmdq: add assign function Dennis YC Hsieh
2019-12-10 3:24 ` CK Hu
2019-12-12 1:15 ` Dennis-YC Hsieh
2019-11-27 1:58 ` [PATCH v2 08/14] soc: mediatek: cmdq: add write_s function Dennis YC Hsieh
2019-12-10 5:18 ` CK Hu
2019-12-12 1:31 ` Dennis-YC Hsieh
2019-12-10 7:35 ` Bibby Hsieh
2019-12-12 1:31 ` Dennis-YC Hsieh
2019-11-27 1:58 ` [PATCH v2 09/14] soc: mediatek: cmdq: add read_s function Dennis YC Hsieh
2019-12-10 7:55 ` CK Hu
2019-12-12 1:33 ` Dennis-YC Hsieh
2019-11-27 1:58 ` [PATCH v2 10/14] soc: mediatek: cmdq: add write_s value function Dennis YC Hsieh
2019-11-27 1:58 ` [PATCH v2 11/14] soc: mediatek: cmdq: export finalize function Dennis YC Hsieh
2019-12-10 7:50 ` CK Hu
2019-11-27 1:58 ` [PATCH v2 12/14] soc: mediatek: cmdq: add loop function Dennis YC Hsieh
2019-12-11 1:48 ` CK Hu
2019-12-12 1:37 ` Dennis-YC Hsieh
2019-11-27 1:58 ` [PATCH v2 13/14] soc: mediatek: cmdq: add wait no clear event function Dennis YC Hsieh
2019-12-11 2:04 ` CK Hu
2019-12-12 1:42 ` Dennis-YC Hsieh
2019-11-27 1:58 ` [PATCH v2 14/14] soc: mediatek: cmdq: add set " Dennis YC Hsieh
Reply instructions:
You may reply publically to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1576656006.5933.3.camel@mtkswgap22 \
--to=dennis-yc.hsieh@mediatek.com \
--cc=bibby.hsieh@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=houlong.wei@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-mediatek Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-mediatek/0 linux-mediatek/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-mediatek linux-mediatek/ https://lore.kernel.org/linux-mediatek \
linux-mediatek@lists.infradead.org
public-inbox-index linux-mediatek
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mediatek
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git