Linux-mediatek Archive on lore.kernel.org
 help / color / Atom feed
* [RESEND,v2,0/1] Add mt7629 pwm support
@ 2020-02-12  2:35 Sam Shih
  2020-02-12  2:35 ` [RESEND,v2,1/1] arm: dts: mediatek: add " Sam Shih
  0 siblings, 1 reply; 3+ messages in thread
From: Sam Shih @ 2020-02-12  2:35 UTC (permalink / raw)
  To: Matthias Brugger, Rob Herring, Mark Rutland
  Cc: devicetree, linux-mediatek, linux-kernel, linux-arm-kernel, Sam Shih

A gentle ping on this whole patch series

This adds pwm support for MT7629.

Change since v1:
remove unused property num-pwm

Used:
https://patchwork.kernel.org/patch/11160851/

Related dependent driver updates have been merged into maintainer's kernel
source tree.


Sam Shih (1):
  arm: dts: mediatek: add mt7629 pwm support

 arch/arm/boot/dts/mt7629.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

-- 
2.17.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [RESEND,v2,1/1] arm: dts: mediatek: add mt7629 pwm support
  2020-02-12  2:35 [RESEND,v2,0/1] Add mt7629 pwm support Sam Shih
@ 2020-02-12  2:35 ` " Sam Shih
  2020-02-12 10:15   ` Matthias Brugger
  0 siblings, 1 reply; 3+ messages in thread
From: Sam Shih @ 2020-02-12  2:35 UTC (permalink / raw)
  To: Matthias Brugger, Rob Herring, Mark Rutland
  Cc: devicetree, linux-mediatek, linux-kernel, linux-arm-kernel, Sam Shih

This adds pwm support for MT7629.
Used:
https://patchwork.kernel.org/patch/11160851/

Change since v1:
remove unused property num-pwm

Signed-off-by: Sam Shih <sam.shih@mediatek.com>
---
 arch/arm/boot/dts/mt7629.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi
index 867b88103b9d..ce2a30a24017 100644
--- a/arch/arm/boot/dts/mt7629.dtsi
+++ b/arch/arm/boot/dts/mt7629.dtsi
@@ -241,6 +241,20 @@
 			status = "disabled";
 		};
 
+		pwm: pwm@11006000 {
+			compatible = "mediatek,mt7629-pwm";
+			reg = <0x11006000 0x1000>;
+			interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
+			clocks = <&topckgen CLK_TOP_PWM_SEL>,
+				 <&pericfg CLK_PERI_PWM_PD>,
+				 <&pericfg CLK_PERI_PWM1_PD>;
+			clock-names = "top", "main", "pwm1";
+			assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
+			assigned-clock-parents =
+					<&topckgen CLK_TOP_UNIVPLL2_D4>;
+			status = "disabled";
+		};
+
 		i2c: i2c@11007000 {
 			compatible = "mediatek,mt7629-i2c",
 				     "mediatek,mt2712-i2c";
-- 
2.17.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RESEND,v2,1/1] arm: dts: mediatek: add mt7629 pwm support
  2020-02-12  2:35 ` [RESEND,v2,1/1] arm: dts: mediatek: add " Sam Shih
@ 2020-02-12 10:15   ` Matthias Brugger
  0 siblings, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2020-02-12 10:15 UTC (permalink / raw)
  To: Sam Shih, Rob Herring, Mark Rutland
  Cc: devicetree, linux-mediatek, linux-kernel, linux-arm-kernel



On 12/02/2020 03:35, Sam Shih wrote:
> This adds pwm support for MT7629.

The information below should not be part of the commit message, the next time
please put it below the line "---".

> Used:
> https://patchwork.kernel.org/patch/11160851/
> 
> Change since v1:
> remove unused property num-pwm
> 
> Signed-off-by: Sam Shih <sam.shih@mediatek.com>
> ---
>  arch/arm/boot/dts/mt7629.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi
> index 867b88103b9d..ce2a30a24017 100644
> --- a/arch/arm/boot/dts/mt7629.dtsi
> +++ b/arch/arm/boot/dts/mt7629.dtsi
> @@ -241,6 +241,20 @@
>  			status = "disabled";
>  		};
>  
> +		pwm: pwm@11006000 {
> +			compatible = "mediatek,mt7629-pwm";
> +			reg = <0x11006000 0x1000>;
> +			interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
> +			clocks = <&topckgen CLK_TOP_PWM_SEL>,
> +				 <&pericfg CLK_PERI_PWM_PD>,
> +				 <&pericfg CLK_PERI_PWM1_PD>;
> +			clock-names = "top", "main", "pwm1";
> +			assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
> +			assigned-clock-parents =
> +					<&topckgen CLK_TOP_UNIVPLL2_D4>;
> +			status = "disabled";
> +		};
> +

This does not match the binding description.
Please fix that.


>  		i2c: i2c@11007000 {
>  			compatible = "mediatek,mt7629-i2c",
>  				     "mediatek,mt2712-i2c";
> 

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12  2:35 [RESEND,v2,0/1] Add mt7629 pwm support Sam Shih
2020-02-12  2:35 ` [RESEND,v2,1/1] arm: dts: mediatek: add " Sam Shih
2020-02-12 10:15   ` Matthias Brugger

Linux-mediatek Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mediatek/0 linux-mediatek/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mediatek linux-mediatek/ https://lore.kernel.org/linux-mediatek \
		linux-mediatek@lists.infradead.org
	public-inbox-index linux-mediatek

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mediatek


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git