* [PATCH] soc: mediatek: knows_txdone needs to be set in Mediatek CMDQ helper
@ 2020-02-14 4:35 Bibby Hsieh
2020-02-14 6:23 ` CK Hu
2020-02-14 10:15 ` Matthias Brugger
0 siblings, 2 replies; 3+ messages in thread
From: Bibby Hsieh @ 2020-02-14 4:35 UTC (permalink / raw)
To: Jassi Brar, Matthias Brugger, Rob Herring, CK HU
Cc: devicetree, Nicolas Boichat, srv_heupstream, linux-kernel,
Houlong Wei, Dennis-YC Hsieh, linux-mediatek, Bibby Hsieh,
linux-arm-kernel
Mediatek CMDQ driver have a mechanism to do TXDONE_BY_ACK,
so we should set knows_txdone.
Fixes:576f1b4bc802 ("soc: mediatek: Add Mediatek CMDQ helper")
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
---
drivers/soc/mediatek/mtk-cmdq-helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index 9add0fd5fa6c..2ca1a759a347 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -80,6 +80,7 @@ struct cmdq_client *cmdq_mbox_create(struct device *dev, int index, u32 timeout)
client->pkt_cnt = 0;
client->client.dev = dev;
client->client.tx_block = false;
+ client->client.knows_txdone = true;
client->chan = mbox_request_channel(&client->client, index);
if (IS_ERR(client->chan)) {
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: mediatek: knows_txdone needs to be set in Mediatek CMDQ helper
2020-02-14 4:35 [PATCH] soc: mediatek: knows_txdone needs to be set in Mediatek CMDQ helper Bibby Hsieh
@ 2020-02-14 6:23 ` CK Hu
2020-02-14 10:15 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: CK Hu @ 2020-02-14 6:23 UTC (permalink / raw)
To: Bibby Hsieh
Cc: devicetree, Nicolas Boichat, srv_heupstream, Jassi Brar,
linux-kernel, Houlong Wei, Dennis-YC Hsieh, Rob Herring,
linux-mediatek, Matthias Brugger, linux-arm-kernel
Hi, Bibby:
On Fri, 2020-02-14 at 12:35 +0800, Bibby Hsieh wrote:
> Mediatek CMDQ driver have a mechanism to do TXDONE_BY_ACK,
> so we should set knows_txdone.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Fixes:576f1b4bc802 ("soc: mediatek: Add Mediatek CMDQ helper")
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
> drivers/soc/mediatek/mtk-cmdq-helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 9add0fd5fa6c..2ca1a759a347 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -80,6 +80,7 @@ struct cmdq_client *cmdq_mbox_create(struct device *dev, int index, u32 timeout)
> client->pkt_cnt = 0;
> client->client.dev = dev;
> client->client.tx_block = false;
> + client->client.knows_txdone = true;
> client->chan = mbox_request_channel(&client->client, index);
>
> if (IS_ERR(client->chan)) {
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: mediatek: knows_txdone needs to be set in Mediatek CMDQ helper
2020-02-14 4:35 [PATCH] soc: mediatek: knows_txdone needs to be set in Mediatek CMDQ helper Bibby Hsieh
2020-02-14 6:23 ` CK Hu
@ 2020-02-14 10:15 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2020-02-14 10:15 UTC (permalink / raw)
To: Bibby Hsieh, Jassi Brar, Rob Herring, CK HU
Cc: devicetree, Nicolas Boichat, srv_heupstream, linux-kernel,
Houlong Wei, Dennis-YC Hsieh, linux-mediatek, linux-arm-kernel
On 14/02/2020 05:35, Bibby Hsieh wrote:
> Mediatek CMDQ driver have a mechanism to do TXDONE_BY_ACK,
> so we should set knows_txdone.
>
> Fixes:576f1b4bc802 ("soc: mediatek: Add Mediatek CMDQ helper")
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
I added a tag:
Cc: stable@vger.kernel.org # v5.0+
and applied it to v5.6-next/soc
Thanks
> drivers/soc/mediatek/mtk-cmdq-helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 9add0fd5fa6c..2ca1a759a347 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -80,6 +80,7 @@ struct cmdq_client *cmdq_mbox_create(struct device *dev, int index, u32 timeout)
> client->pkt_cnt = 0;
> client->client.dev = dev;
> client->client.tx_block = false;
> + client->client.knows_txdone = true;
> client->chan = mbox_request_channel(&client->client, index);
>
> if (IS_ERR(client->chan)) {
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-14 10:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-14 4:35 [PATCH] soc: mediatek: knows_txdone needs to be set in Mediatek CMDQ helper Bibby Hsieh
2020-02-14 6:23 ` CK Hu
2020-02-14 10:15 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).