From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CE08C3B18F for ; Fri, 14 Feb 2020 06:24:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33BFA2187F for ; Fri, 14 Feb 2020 06:24:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WIK9JGd6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Ocmec2C4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33BFA2187F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QhDoJ5jOc9XGmEzR5LkIZqPZUClTsgf5KkOkisXVu6w=; b=WIK9JGd67m4YKj rHECJC0m7ySJW/vro5Fe4MhekHk7Nt2CjJ2ekpGLyDNVv90R8pd+R5ez+ktnLo7vidNgI/O7uEoOg 29V3s520S3AoZ2YkZwks6TqowjvXM8M5tbim1COJLc2tOe9FUyw3ce5SR8L12FvKHVbUCJ8+kRAqG 6whlXivPw//0cDZRlh9Mz+nlPPpRe/kjVDD65eWVlhiV1aFGAKI24tV3TqgCAZzV13sQgy8NW/sD9 2REeIj/cHOWxM83JaEcNLt5bIhKtm0DWKqBSoVOGJNKYnvfabgv91d1BZV1Py+7V5HkDI+/CzyZ9o F05dByhByWg8ZqVTLTDw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2UOY-0000p7-S2; Fri, 14 Feb 2020 06:24:10 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2UOV-0000oD-7l; Fri, 14 Feb 2020 06:24:08 +0000 X-UUID: d45e58ba65754133ad0b8a9a99ffac24-20200213 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=mJEdOBJrDxxHAkQhloAsNjKpaHcV9joa9xc+Z06QjCA=; b=Ocmec2C4uJn1VHMiRGwWoV+jBtk2k31FbI/Bcxy0ZbHJ4B1W4bkfy/ILRXsK5LG6Hf2BjM7xo/CrpiiHhbmxuiOcippNW/j95z0KiLssEgonPX9GYuIIqdUpfd7fhSqe3vMyMBxf4LKKqJOS+mraBp7+bVfJv3LcvWHXdSyW84I=; X-UUID: d45e58ba65754133ad0b8a9a99ffac24-20200213 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 741567612; Thu, 13 Feb 2020 22:24:00 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 13 Feb 2020 22:23:57 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 14 Feb 2020 14:23:05 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 14 Feb 2020 14:23:28 +0800 Message-ID: <1581661437.16618.0.camel@mtksdaap41> Subject: Re: [PATCH] soc: mediatek: knows_txdone needs to be set in Mediatek CMDQ helper From: CK Hu To: Bibby Hsieh Date: Fri, 14 Feb 2020 14:23:57 +0800 In-Reply-To: <20200214043545.16713-1-bibby.hsieh@mediatek.com> References: <20200214043545.16713-1-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200213_222407_285661_47C66BA4 X-CRM114-Status: GOOD ( 12.67 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Dennis-YC Hsieh , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Fri, 2020-02-14 at 12:35 +0800, Bibby Hsieh wrote: > Mediatek CMDQ driver have a mechanism to do TXDONE_BY_ACK, > so we should set knows_txdone. > Reviewed-by: CK Hu > Fixes:576f1b4bc802 ("soc: mediatek: Add Mediatek CMDQ helper") > > Signed-off-by: Bibby Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 9add0fd5fa6c..2ca1a759a347 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -80,6 +80,7 @@ struct cmdq_client *cmdq_mbox_create(struct device *dev, int index, u32 timeout) > client->pkt_cnt = 0; > client->client.dev = dev; > client->client.tx_block = false; > + client->client.knows_txdone = true; > client->chan = mbox_request_channel(&client->client, index); > > if (IS_ERR(client->chan)) { _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek