From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D6BC2BA80 for ; Tue, 7 Apr 2020 13:37:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76397206F7 for ; Tue, 7 Apr 2020 13:37:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C1KimMis"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="lDksy6K4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76397206F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LG5w2K2D0ZaIpPUfmITcsEI5naQ54LJrNPG2gO1iMSA=; b=C1KimMisl6qBVJ T7PKVOQbngI/xEbZfPYB/wmIKo2LfWfr2S7OsWvAjAdc7cH9P23MdMcdcIxzHqpDuxivHYV2Z/74I 4L2mCLKilZ8wbi3i5ylP4s2Zx2nnBoRNO8duHTmHKOAVPJe28IwD2tevd7dwIHz9WLlU2YshC6jC4 LqszOeUQ732mQZCUsjAPQXZ7F1DIaIi4Npr6jC3qm3C4hnYQD5o3mCTALs+15YxSYHC6AMFMqPbUq o3YF7jXTZd7lNEIn5IM0/FvDQRlJMqA70wDhJ2ygzwEh6MpYN9vsHXZ9CeJ6S5N7Y8N4cPnzH3655 K4REOV/CXTUAXtGlOOgQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLoQ4-000197-ED; Tue, 07 Apr 2020 13:37:36 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLoQ1-000184-Bi for linux-mediatek@lists.infradead.org; Tue, 07 Apr 2020 13:37:35 +0000 X-UUID: 7bba737f981f4ca6ab50f8ae39fda00b-20200407 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=RdRXX8sbx8HHYtoWDp4+BPvE2rMumZFXzEadK6V6dIU=; b=lDksy6K4DK1XyRS8e0PdFfIXujIgPFm/VGtUri29z71t1yAdTuiBZrKANH7cnfcqQzXFmcAr/B/2rc9dJsCuycXZrbZDsV4wze79KnAYCLgf7GPu8Dw8cLEYFhujIkRUQYXWLgHAt8v3ekT15W1K6mUSDEWk4qXpotxq18V8ZME=; X-UUID: 7bba737f981f4ca6ab50f8ae39fda00b-20200407 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1280132738; Tue, 07 Apr 2020 05:37:50 -0800 Received: from MTKMBS02N2.mediatek.inc (172.21.101.101) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Apr 2020 06:37:19 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Apr 2020 21:37:11 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 7 Apr 2020 21:37:10 +0800 Message-ID: <1586266634.2221.0.camel@mtkswgap22> Subject: Re: [PATCH v1 1/1] pinctrl: mediatek: remove shadow variable declaration From: Stanley Chu To: "light.hsieh@mediatek.com" Date: Tue, 7 Apr 2020 21:37:14 +0800 In-Reply-To: <1586255632-27528-1-git-send-email-light.hsieh@mediatek.com> References: <1586255632-27528-1-git-send-email-light.hsieh@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: C46968FC8DEA5F527A542FEB4FA622A3AA2E7B501EEE4D5BA8AE4EEE90C277142000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200407_063733_405235_85437D50 X-CRM114-Status: GOOD ( 11.10 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linus.walleij@linaro.org" , "sean.wang@kernel.org" , Kuohong Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=8B=E9=B4=BB=29?= , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-mediatek@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Light, On Tue, 2020-04-07 at 18:33 +0800, light.hsieh@mediatek.com wrote: > From: Light Hsieh > > Remove shadow declaration of variable 'pullup' in mtk_pinconf_get() > > Signed-off-by: Light Hsieh > --- > drivers/pinctrl/mediatek/pinctrl-paris.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c > index 83bf29c..8f75115 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-paris.c > +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c > @@ -164,8 +164,6 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev, > case MTK_PIN_CONFIG_PU_ADV: > case MTK_PIN_CONFIG_PD_ADV: > if (hw->soc->adv_pull_get) { > - bool pullup; > - > pullup = param == MTK_PIN_CONFIG_PU_ADV; > err = hw->soc->adv_pull_get(hw, desc, pullup, &ret); > } else Reviewed-by: Stanley Chu _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek