linux-mediatek.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: fengping.yu <fengping.yu@mediatek.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org,
	Yingjoe Chen <yingjoe.chen@mediatek.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10] Add matrix keypad driver support for Mediatek SoCs
Date: Thu, 28 May 2020 16:21:01 +0800	[thread overview]
Message-ID: <1590654061.15483.5.camel@mbjsdccf07> (raw)
In-Reply-To: <20200528071916.2zxch46lbimxet2u@pengutronix.de>

Hi Marco:

I am sorry, I think I misunderstand your suggestion about wakeup member
in patch v9.

Keypad is a wakeup source, so I mis-remove wakeup source setting in the
probe function. 

I will modify this in the next patch.

Thanks.


On Thu, 2020-05-28 at 09:19 +0200, Marco Felsch wrote:
> Hi,
> 
> this version looks nice to me =) One last question.
> 
> On 20-05-28 13:33, Fengping Yu wrote:
> > 
> > Change since v9:
> > - modify KEYBOARD_MTK_KPD config dependent item
> > - remove wakeup member of mtk_keypad struct
> 
> You also removed the device wakeup capability completely, was this
> intended? What I mean is that we don't need that member within the
> driver state struct.
> 
> Regards,
>   Marco
> 
> > - remove default pinctrl state set
> > - modify request irq failed return value
> > - add space of kepad matching table
> > - modify align issue
> > 
> > fengping.yu (3):
> >   dt-bindings: Add keypad devicetree documentation
> >   drivers: input: keyboard: Add mtk keypad driver
> >   configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=m
> > 
> >  .../devicetree/bindings/input/mtk-kpd.yaml    |  95 +++++++++
> >  arch/arm64/configs/defconfig                  |   1 +
> >  drivers/input/keyboard/Kconfig                |  11 +
> >  drivers/input/keyboard/Makefile               |   1 +
> >  drivers/input/keyboard/mtk-kpd.c              | 201 ++++++++++++++++++
> >  5 files changed, 309 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.yaml
> >  create mode 100644 drivers/input/keyboard/mtk-kpd.c
> > 
> > -- 
> > 2.18.0
> > 
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

      reply	other threads:[~2020-05-28  8:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28  5:33 [PATCH v10] Add matrix keypad driver support for Mediatek SoCs Fengping Yu
2020-05-28  5:33 ` [PATCH v10 1/3] dt-bindings: Add keypad devicetree documentation Fengping Yu
2020-05-28  5:33 ` [PATCH v10 2/3] drivers: input: keyboard: Add mtk keypad driver Fengping Yu
2020-05-28  5:33 ` [PATCH v10 3/3] configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=m Fengping Yu
2020-05-28  7:19 ` [PATCH v10] Add matrix keypad driver support for Mediatek SoCs Marco Felsch
2020-05-28  8:21   ` fengping.yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1590654061.15483.5.camel@mbjsdccf07 \
    --to=fengping.yu@mediatek.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).