From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74036C433E0 for ; Mon, 1 Jun 2020 10:38:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 465612065C for ; Mon, 1 Jun 2020 10:38:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="B39VUWMx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="JwJrvLD0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 465612065C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zcGQGOhQ4+H27EvlgOqCN+Ubh2E6+b981RM7ydZASkY=; b=B39VUWMx/bwoA7 Qpf0DUPFllWjaxrFb2B/mYwlyA47Homrts24d47QFcRB0W0vMiwn+QKizH1V1AQ9w5pCbGPQHe+br idU38PNjh0pFvxBpYlqQPCRo11ZZO2F/Tw6rhJ8WPkXjXA5US8rv9s7K740o6ttJX9bpA/aUBSi8I 5wMN2Pb42N2VQncAnNKcdcL23cHZwvpkdGOw+BEBMsT1fwyc0uw5L7hsbJF13iUUJH07Z5MUuCkiS swg0bxSdK6680fvlSqBZpvFQOIEtgNrFEJGK4jGQkYyQeTD3+oPEPE7HZWNm83FmvsgbWOC8d+/c/ FW8fgjrP8GuTiZY4SEIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jfhpf-0002em-KZ; Mon, 01 Jun 2020 10:38:15 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jfhpV-0002dP-5C; Mon, 01 Jun 2020 10:38:06 +0000 X-UUID: 46976730ff844c8c84d13c0a7b67df10-20200601 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=1ubZI9bQ8AA1BT1/8Z5X+IHX0+39sOSJHMhP1+hac8k=; b=JwJrvLD0tfBria8+P0LqvTUZNX2OOQUBkUk3JyVOFYTqjxX+y/VmVk1gujPtezIq5k/u/q5I+nh7ekmnCvnTupoceD/bnYfVy+Zeme6sNnE36APbCDdqODdzuxY754tv0J4CPJYG1dguVbqhpabQXWlO5jMu/fwaaBE+iFbQFYI=; X-UUID: 46976730ff844c8c84d13c0a7b67df10-20200601 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1925492756; Mon, 01 Jun 2020 02:37:53 -0800 Received: from mtkmbs08n1.mediatek.inc (172.21.101.55) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 1 Jun 2020 03:37:55 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 1 Jun 2020 18:37:42 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 1 Jun 2020 18:37:41 +0800 Message-ID: <1591007863.15207.1.camel@mtksdccf07> Subject: Re: [RFC PATCH V4 4/4] platform: mtk-isp: Add Mediatek FD driver From: Jerry-ch Chen To: Tomasz Figa Date: Mon, 1 Jun 2020 18:37:43 +0800 In-Reply-To: References: <20191204124732.10932-1-Jerry-Ch.chen@mediatek.com> <20191204124732.10932-5-Jerry-Ch.chen@mediatek.com> <20200521182825.GA249683@chromium.org> <1590156658.27807.84.camel@mtksdccf07> <1590755163.23156.24.camel@mtksdccf07> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200601_033805_221254_CB53C65B X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-devicetree , Sean Cheng =?UTF-8?Q?=28=E9=84=AD=E6=98=87=E5=BC=98=29?= , Laurent Pinchart , zwisler@chromium.org, srv_heupstream , Christie Yu =?UTF-8?Q?=28=E6=B8=B8=E9=9B=85=E6=83=A0=29?= , Hans Verkuil , Jungo Lin =?UTF-8?Q?=28=E6=9E=97=E6=98=8E=E4=BF=8A=29?= , Sj Huang , yuzhao@chromium.org, Hans Verkuil , Pi-Hsun Shih , Frederic Chen =?UTF-8?Q?=28=E9=99=B3=E4=BF=8A=E5=85=83=29?= , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2020-05-29 at 14:59 +0200, Tomasz Figa wrote: > On Fri, May 29, 2020 at 2:26 PM Jerry-ch Chen > wrote: > > > > Hi Tomasz, > > > > I Appreciate your review comments, here's the reply. > > > > On Mon, 2020-05-25 at 14:24 +0200, Tomasz Figa wrote: > > > r > > > > > > On Fri, May 22, 2020 at 4:11 PM Jerry-ch Chen > > > wrote: > > > > > > > > Hi Tomasz, > > > > > > > > On Thu, 2020-05-21 at 18:28 +0000, Tomasz Figa wrote: > > > > > Hi Jerry, > > > > > > > > > > On Wed, Dec 04, 2019 at 08:47:32PM +0800, Jerry-ch Chen wrote: > [snip] > > > Isn't still a need to clamp() width and height to min/max, though? > > Yes, I'll add them back. > > > > This function will be refined as : > > > > static void mtk_fd_fill_pixfmt_mp(struct v4l2_pix_format_mplane *dfmt, > > u32 pixfmt) > > { > > v4l2_fill_pixfmt_mp(dfmt, pixfmt, dfmt->width, dfmt->height); > > > > dfmt->field = V4L2_FIELD_NONE; > > dfmt->colorspace = V4L2_COLORSPACE_BT2020; > > dfmt->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT; > > dfmt->quantization = V4L2_QUANTIZATION_DEFAULT; > > dfmt->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(dfmt->colorspace); > > > > /* Keep user setting as possible */ > > dfmt->width = clamp(dfmt->width, > > MTK_FD_OUTPUT_MIN_WIDTH, > > MTK_FD_OUTPUT_MAX_WIDTH); > > dfmt->height = clamp(dfmt->height, > > MTK_FD_OUTPUT_MIN_HEIGHT, > > MTK_FD_OUTPUT_MAX_HEIGHT); > > Note that this would cause the other fields of dfmt to be inconsistent > with width and height. The correct way to do this would be to first > clamp and then call v4l2_fill_pixfmt_mp(). > Ok, I will fix it. Thanks and Best regards, Jerry > Best regards, > Tomasz _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek