From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E13A6C433DF for ; Wed, 10 Jun 2020 06:30:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF18320760 for ; Wed, 10 Jun 2020 06:30:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ptgaR7V/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="oX5oBBIM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF18320760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PCrJnfAunRrM3QYFXenZITm47j9t7ANwe2IYk9Pzmj4=; b=ptgaR7V/ryxRre Elles/36PiKF5u6l/QgphhtEvWQu9Zy4ahxul54WabN/9RPq7WLMyFFRnl+16/Q/3d8fDaFW5cyCJ 1YtrwgZruGu8EOoFUj2tEX3Zy8uxJGzQCrukMNd/nIqy1H/t/P/wPvwIK4FQCn6ZtWo3Cn8O8KFd0 T+kd8IzUOAuLV7i4cX2CsXDCMI1anr9SX9jaKhjs3gw3BY1gAdILZh6l+oubH9cWAup67IBceKu6a sE227/0ryRVmRcPFKE9DdIu1pQNvTBi/6Z39MbTp2NF6O/SMotkrYFILTTt20QcmucFYJGDcFyZEs 08eVXfT0RopTBkwVhYOw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiuFo-0003aK-LF; Wed, 10 Jun 2020 06:30:28 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiuFl-0003Zl-H6; Wed, 10 Jun 2020 06:30:27 +0000 X-UUID: 9c9460f743cd4054a13ab65342c47468-20200609 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=hdgI+fXHtKacXru8/dXUuE3zpRMIWvgQyNSpZ1nA1Ys=; b=oX5oBBIM4ItBDoymUnE0/6Ay/jMClwsCW0zcdpVwWlHcroH8SnaiXS4UDX9U1pbj0zHmh3I5UPHZQFmC/pSh0ZE9uOn0IViBRKLJysjidN2K2usrJIEdg6qDHYAtblwOWUhX0w2W3c/vYaROCN/FKVdANnZ6ozdXGuB0qUD95wk=; X-UUID: 9c9460f743cd4054a13ab65342c47468-20200609 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 172310158; Tue, 09 Jun 2020 22:30:06 -0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 9 Jun 2020 23:20:22 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Jun 2020 14:20:19 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 10 Jun 2020 14:20:19 +0800 Message-ID: <1591770020.5047.5.camel@mtksdaap41> Subject: Re: [PATCH v4 09/17] media: mtk-vcodec: Get rid of mtk_smi_larb_get/put From: Tiffany Lin To: CK Hu Date: Wed, 10 Jun 2020 14:20:20 +0800 In-Reply-To: <1591768038.527.6.camel@mtksdaap41> References: <1590826218-23653-1-git-send-email-yong.wu@mediatek.com> <1590826218-23653-10-git-send-email-yong.wu@mediatek.com> <1591768038.527.6.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200609_233025_575804_BC2D04AF X-CRM114-Status: GOOD ( 15.10 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maoguang Meng , Will Deacon , youlin.pei@mediatek.com, Nicolas Boichat , Joerg Roedel , Evan Green , eizan@chromium.org, Matthias Kaehlcke , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, cui.zhang@mediatek.com, Tomasz Figa , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , ming-fan.chen@mediatek.com, Yong Wu , anan.sun@mediatek.com, acourbot@chromium.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, chao.hao@mediatek.com, iommu@lists.linux-foundation.org, Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2020-06-10 at 13:47 +0800, CK Hu wrote: > + Tiffany & Maoguang. > > On Sat, 2020-05-30 at 16:10 +0800, Yong Wu wrote: > > MediaTek IOMMU has already added the device_link between the consumer > > and smi-larb device. If the vcodec device call the pm_runtime_get_sync, > > the smi-larb's pm_runtime_get_sync also be called automatically. > > Acked-by: Tiffany Lin > > CC: Tiffany Lin > > Signed-off-by: Yong Wu > > Reviewed-by: Evan Green > > --- > > .../media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 19 --------------- > > drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 3 --- > > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 1 - > > .../media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c | 27 ---------------------- > > 4 files changed, 50 deletions(-) > > > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c > > index 36dfe3f..1d7d14d 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c > > @@ -8,14 +8,12 @@ > > #include > > #include > > #include > > -#include > > > > #include "mtk_vcodec_dec_pm.h" > > #include "mtk_vcodec_util.h" > > > > int mtk_vcodec_init_dec_pm(struct mtk_vcodec_dev *mtkdev) > > { > > - struct device_node *node; > > struct platform_device *pdev; > > struct mtk_vcodec_pm *pm; > > struct mtk_vcodec_clk *dec_clk; > > @@ -26,18 +24,7 @@ int mtk_vcodec_init_dec_pm(struct mtk_vcodec_dev *mtkdev) > > pm = &mtkdev->pm; > > pm->mtkdev = mtkdev; > > dec_clk = &pm->vdec_clk; > > - node = of_parse_phandle(pdev->dev.of_node, "mediatek,larb", 0); > > - if (!node) { > > - mtk_v4l2_err("of_parse_phandle mediatek,larb fail!"); > > - return -1; > > - } > > > > - pdev = of_find_device_by_node(node); > > - of_node_put(node); > > - if (WARN_ON(!pdev)) { > > - return -1; > > - } > > - pm->larbvdec = &pdev->dev; > > pdev = mtkdev->plat_dev; > > pm->dev = &pdev->dev; > > > > @@ -113,11 +100,6 @@ void mtk_vcodec_dec_clock_on(struct mtk_vcodec_pm *pm) > > } > > } > > > > - ret = mtk_smi_larb_get(pm->larbvdec); > > - if (ret) { > > - mtk_v4l2_err("mtk_smi_larb_get larbvdec fail %d", ret); > > - goto error; > > - } > > return; > > > > error: > > @@ -130,7 +112,6 @@ void mtk_vcodec_dec_clock_off(struct mtk_vcodec_pm *pm) > > struct mtk_vcodec_clk *dec_clk = &pm->vdec_clk; > > int i = 0; > > > > - mtk_smi_larb_put(pm->larbvdec); > > for (i = dec_clk->clk_num - 1; i >= 0; i--) > > clk_disable_unprepare(dec_clk->clk_info[i].vcodec_clk); > > } > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > index 52d1ce1..7d3966a 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > @@ -190,10 +190,7 @@ struct mtk_vcodec_clk { > > */ > > struct mtk_vcodec_pm { > > struct mtk_vcodec_clk vdec_clk; > > - struct device *larbvdec; > > - > > struct mtk_vcodec_clk venc_clk; > > - struct device *larbvenc; > > struct device *dev; > > struct mtk_vcodec_dev *mtkdev; > > }; > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > > index 5301dca..18025f7 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > > @@ -8,7 +8,6 @@ > > #include > > #include > > #include > > -#include > > #include > > > > #include "mtk_vcodec_drv.h" > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c > > index 01c6a55..047919e 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c > > @@ -8,44 +8,25 @@ > > #include > > #include > > #include > > -#include > > > > #include "mtk_vcodec_enc_pm.h" > > #include "mtk_vcodec_util.h" > > > > int mtk_vcodec_init_enc_pm(struct mtk_vcodec_dev *mtkdev) > > { > > - struct device_node *node; > > struct platform_device *pdev; > > struct mtk_vcodec_pm *pm; > > struct mtk_vcodec_clk *enc_clk; > > struct mtk_vcodec_clk_info *clk_info; > > int ret = 0, i = 0; > > - struct device *dev; > > > > pdev = mtkdev->plat_dev; > > pm = &mtkdev->pm; > > memset(pm, 0, sizeof(struct mtk_vcodec_pm)); > > pm->mtkdev = mtkdev; > > pm->dev = &pdev->dev; > > - dev = &pdev->dev; > > enc_clk = &pm->venc_clk; > > > > - node = of_parse_phandle(dev->of_node, "mediatek,larb", 0); > > - if (!node) { > > - mtk_v4l2_err("no mediatek,larb found"); > > - return -ENODEV; > > - } > > - pdev = of_find_device_by_node(node); > > - of_node_put(node); > > - if (!pdev) { > > - mtk_v4l2_err("no mediatek,larb device found"); > > - return -ENODEV; > > - } > > - pm->larbvenc = &pdev->dev; > > - pdev = mtkdev->plat_dev; > > - pm->dev = &pdev->dev; > > - > > enc_clk->clk_num = of_property_count_strings(pdev->dev.of_node, > > "clock-names"); > > if (enc_clk->clk_num > 0) { > > @@ -93,13 +74,6 @@ void mtk_vcodec_enc_clock_on(struct mtk_vcodec_pm *pm) > > } > > } > > > > - ret = mtk_smi_larb_get(pm->larbvenc); > > - if (ret) { > > - mtk_v4l2_err("mtk_smi_larb_get larb3 fail %d", ret); > > - goto clkerr; > > - } > > - return; > > - > > clkerr: > > for (i -= 1; i >= 0; i--) > > clk_disable_unprepare(enc_clk->clk_info[i].vcodec_clk); > > @@ -110,7 +84,6 @@ void mtk_vcodec_enc_clock_off(struct mtk_vcodec_pm *pm) > > struct mtk_vcodec_clk *enc_clk = &pm->venc_clk; > > int i = 0; > > > > - mtk_smi_larb_put(pm->larbvenc); > > for (i = enc_clk->clk_num - 1; i >= 0; i--) > > clk_disable_unprepare(enc_clk->clk_info[i].vcodec_clk); > > } > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek