From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BB84C433E0 for ; Thu, 18 Jun 2020 03:43:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C40621707 for ; Thu, 18 Jun 2020 03:43:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Af1gXNv4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="uwL64kzb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C40621707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tOwzSxyS1TKsIbZ0poY57EZFZJRAp1t65DtGauhYQfE=; b=Af1gXNv4VtuthZ tXRkqA1eZ7+dwzcV7BNSEhWUCjs/cmlfSJWEkN3p3AxOfkQVdbqPKYiVqm33zsluouzqMmMelHHu6 YYzdAL8D2HPxzu60l3HbkJeI0p2rQp9Qp0aQDlAdahHr17cstBOwC5pebqpbPmmkcuY5Pzs3jvSl6 xb4XDqLR08HDTLMmqg7yqRhhpygD9BnYxenJwgwxve7iqElKLb+y41L1mK0x4q5NYqNISa2pOjQFM WjRyoUOZrvs7A5UrcaP4EFZpHG0ogvxvslDgy1noFIisGc6lntMxVhV4PJyBlt6AzOyK4ZvZgLAhp OpLjrKwIWClrIueLO+EQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jllS9-0002dB-Ua; Thu, 18 Jun 2020 03:43:01 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jllS5-0002c4-UL; Thu, 18 Jun 2020 03:42:59 +0000 X-UUID: f028bdd505e34a80973fcb25899d2a27-20200617 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=i4jSTDSTh0GaOSOIPc+y2DdxkaaCQiUZ9e4P/5TV8Tc=; b=uwL64kzbKtCqafMZJaBJO8Dg+HDeUyDHDTrUpi6lT6q0IVvr9OXI2lFFS+87Ms+NfaOvfTD6ZIS0l4p90+mQv8+bKJrxXYuHg/3fTcT0eYmJ1DoeRgU7VcxLDxThlK/r6K3Sii1s9H4FZ3p4wBfGeEr4rwPYNm2enP7Tz4tuwkI=; X-UUID: f028bdd505e34a80973fcb25899d2a27-20200617 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1946055112; Wed, 17 Jun 2020 19:42:49 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 17 Jun 2020 20:42:49 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 18 Jun 2020 11:42:47 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 18 Jun 2020 11:42:45 +0800 Message-ID: <1592451616.15355.25.camel@mhfsdcap03> Subject: Re: [PATCH v8 11/14] media: dt-bindings: Add jpeg enc device tree node document From: Xia Jiang To: Tomasz Figa Date: Thu, 18 Jun 2020 11:40:16 +0800 In-Reply-To: <20200521160046.GJ209565@chromium.org> References: <20200403094033.8288-1-xia.jiang@mediatek.com> <20200403094033.8288-12-xia.jiang@mediatek.com> <20200521160046.GJ209565@chromium.org> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: E100C0680B0A813F09A9DC10EAB829B13E2B394890EB73037F1C971D096F1A762000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200617_204257_981281_AE2E2B3A X-CRM114-Status: GOOD ( 21.98 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, devicetree@vger.kernel.org, mojahsu@chromium.org, srv_heupstream@mediatek.com, Rick Chang , senozhatsky@chromium.org, linux-kernel@vger.kernel.org, maoguang.meng@mediatek.com, Mauro Carvalho Chehab , sj.huang@mediatek.com, Rob Herring , Matthias Brugger , yong.wu@mediatek.com, Hans Verkuil , linux-mediatek@lists.infradead.org, Marek Szyprowski , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2020-05-21 at 16:00 +0000, Tomasz Figa wrote: > Hi Xia, > > On Fri, Apr 03, 2020 at 05:40:30PM +0800, Xia Jiang wrote: > > Add jpeg enc device tree node document > > > > Reviewed-by: Rob Herring > > Signed-off-by: Xia Jiang > > --- > > v8: no changes > > > > v7: no changes > > > > v6: no changes > > > > v5: no changes > > > > v4: no changes > > > > v3: change compatible to SoC specific compatible > > > > v2: no changes > > --- > > .../bindings/media/mediatek-jpeg-encoder.txt | 37 +++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.txt > > > > Thank you for the patch. Please see my comments inline. Dear Tomasz, Sorry for missing this message. Replied below. > > > diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.txt b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.txt > > new file mode 100644 > > index 000000000000..fa8da699493b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.txt > > @@ -0,0 +1,37 @@ > > +* MediaTek JPEG Encoder > > + > > +MediaTek JPEG Encoder is the JPEG encode hardware present in MediaTek SoCs > > + > > +Required properties: > > +- compatible : should be one of: > > + "mediatek,mt2701-jpgenc" > > + ... > > What does this "..." mean? "..." means that compatible name is not just "mediatek,mt2701-jpgenc", different project has different compatible name(for example the MT8173's compatible name may be "mediatek,mt8173-jpgenc"). > > > + followed by "mediatek,mtk-jpgenc" > > +- reg : physical base address of the JPEG encoder registers and length of > > + memory mapped region. > > +- interrupts : interrupt number to the interrupt controller. > > +- clocks: device clocks, see > > + Documentation/devicetree/bindings/clock/clock-bindings.txt for details. > > +- clock-names: must contain "jpgenc". It is the clock of JPEG encoder. > > nit: In principle the clocks should be named after the function the clock > performs on the consumer side, i.e. the JPEG block in this case, I guess > here it's just a generic clock that does everything, but I guess it comes > from somewhere. Is it the AHB clock or something? In that case it would > normally be called "ahb". I have confirmed with hardware designer that the jpeg clock is not AHB clock,it follows subsys clock(because 2701 is the old IC,I didn't get the source name).It has the same source with venc clock.We can see that the clocks = , Should I name it "venc" or the orignal "jpgenc"? > > > +- power-domains: a phandle to the power domain, see > > + Documentation/devicetree/bindings/power/power_domain.txt for details. > > +- mediatek,larb: must contain the local arbiters in the current SoCs, see > > + Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt > > + for details. > > I believe this isn't necessary anymore, because larbs are added > automatically by the MTK IOMMU driver using device links. +CC Yong who > worked on that. Yes,I have confirmed with Yong that he will help me to modify this.Is it ok that I keep the orignal larb code? Best Regards, Xia Jiang > > > +- iommus: should point to the respective IOMMU block with master port as > > + argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > + for details. > > + > > +Example: > > + jpegenc: jpegenc@1500a000 { > > + compatible = "mediatek,mt2701-jpgenc", > > + "mediatek,mtk-jpgenc"; > > + reg = <0 0x1500a000 0 0x1000>; > > + interrupts = ; > > + clocks = <&imgsys CLK_IMG_VENC>; > > + clock-names = "jpgenc"; > > + power-domains = <&scpsys MT2701_POWER_DOMAIN_ISP>; > > + mediatek,larb = <&larb2>; > > Ditto. > > Best regards, > Tomasz _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek