From: Stanley Chu <stanley.chu@mediatek.com>
To: Can Guo <cang@codeaurora.org>
Cc: jiajie.hao@mediatek.com, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, andy.teng@mediatek.com,
jejb@linux.ibm.com, chun-hung.wu@mediatek.com,
kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org,
asutoshd@codeaurora.org, avri.altman@wdc.com,
linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
alim.akhtar@samsung.com, matthias.bgg@gmail.com,
beanhuo@micron.com, chaotian.jing@mediatek.com,
cc.chou@mediatek.com, linux-arm-kernel@lists.infradead.org,
bvanassche@acm.org
Subject: Re: [PATCH v6] scsi: ufs: Quiesce all scsi devices before shutdown
Date: Mon, 3 Aug 2020 17:58:04 +0800 [thread overview]
Message-ID: <1596448684.32283.25.camel@mtkswgap22> (raw)
In-Reply-To: <d85cdb877bced2d6b0a8ba67670271f2@codeaurora.org>
Hi Can,
On Mon, 2020-08-03 at 13:03 +0800, Can Guo wrote:
> Hi Stanley,
>
> On 2020-08-03 12:25, Stanley Chu wrote:
> > Currently I/O request could be still submitted to UFS device while
> > UFS is working on shutdown flow. This may lead to racing as below
> > scenarios and finally system may crash due to unclocked register
> > accesses.
> >
> > To fix this kind of issues, in ufshcd_shutdown(),
> >
> > 1. Use pm_runtime_get_sync() instead of resuming UFS device by
> > ufshcd_runtime_resume() "internally" to let runtime PM framework
> > manage and prevent concurrent runtime operations by incoming I/O
> > requests.
> >
> > 2. Specifically quiesce all SCSI devices to block all I/O requests
> > after device is resumed.
> >
> > Example of racing scenario: While UFS device is runtime-suspended
> >
> > Thread #1: Executing UFS shutdown flow, e.g.,
> > ufshcd_suspend(UFS_SHUTDOWN_PM)
> >
> > Thread #2: Executing runtime resume flow triggered by I/O request,
> > e.g., ufshcd_resume(UFS_RUNTIME_PM)
> >
> > This breaks the assumption that UFS PM flows can not be running
> > concurrently and some unexpected racing behavior may happen.
> >
> > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> > ---
> > Changes:
> > - Since v4: Use pm_runtime_get_sync() instead of resuming UFS device
> > by ufshcd_runtime_resume() "internally".
> > ---
> > drivers/scsi/ufs/ufshcd.c | 39 ++++++++++++++++++++++++++++++++++-----
> > 1 file changed, 34 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> > index 307622284239..fc01171d13b1 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -159,6 +159,12 @@ struct ufs_pm_lvl_states ufs_pm_lvl_states[] = {
> > {UFS_POWERDOWN_PWR_MODE, UIC_LINK_OFF_STATE},
> > };
> >
> > +#define ufshcd_scsi_for_each_sdev(fn) \
> > + list_for_each_entry(starget, &hba->host->__targets, siblings) { \
> > + __starget_for_each_device(starget, NULL, \
> > + fn); \
> > + }
> > +
> > static inline enum ufs_dev_pwr_mode
> > ufs_get_pm_lvl_to_dev_pwr_mode(enum ufs_pm_level lvl)
> > {
> > @@ -8629,6 +8635,13 @@ int ufshcd_runtime_idle(struct ufs_hba *hba)
> > }
> > EXPORT_SYMBOL(ufshcd_runtime_idle);
> >
> > +static void ufshcd_quiesce_sdev(struct scsi_device *sdev, void *data)
> > +{
> > + /* Suspended devices are already quiesced so can be skipped */
>
> Why can runtime suspended sdevs be skipped? Block layer can still resume
> them at any time, no?
Thanks for reminding.
Yes, this check is wrong. All SCSI devices shall be applied
scsi_device_quiesce() here so I will fix it in next version.
>
> > + if (!pm_runtime_suspended(&sdev->sdev_gendev))
> > + scsi_device_quiesce(sdev);
> > +}
> > +
> > /**
> > * ufshcd_shutdown - shutdown routine
> > * @hba: per adapter instance
> > @@ -8640,6 +8653,7 @@ EXPORT_SYMBOL(ufshcd_runtime_idle);
> > int ufshcd_shutdown(struct ufs_hba *hba)
> > {
> > int ret = 0;
> > + struct scsi_target *starget;
> >
> > if (!hba->is_powered)
> > goto out;
> > @@ -8647,11 +8661,26 @@ int ufshcd_shutdown(struct ufs_hba *hba)
> > if (ufshcd_is_ufs_dev_poweroff(hba) && ufshcd_is_link_off(hba))
> > goto out;
> >
> > - if (pm_runtime_suspended(hba->dev)) {
> > - ret = ufshcd_runtime_resume(hba);
> > - if (ret)
> > - goto out;
> > - }
> > + /*
> > + * Let runtime PM framework manage and prevent concurrent runtime
> > + * operations with shutdown flow.
> > + */
> > + pm_runtime_get_sync(hba->dev);
> > +
> > + /*
> > + * Quiesce all SCSI devices to prevent any non-PM requests sending
> > + * from block layer during and after shutdown.
> > + *
> > + * Here we can not use blk_cleanup_queue() since PM requests
> > + * (with BLK_MQ_REQ_PREEMPT flag) are still required to be sent
> > + * through block layer. Therefore SCSI command queued after the
> > + * scsi_target_quiesce() call returned will block until
> > + * blk_cleanup_queue() is called.
> > + *
> > + * Besides, scsi_target_"un"quiesce (e.g., scsi_target_resume) can
> > + * be ignored since shutdown is one-way flow.
> > + */
> > + ufshcd_scsi_for_each_sdev(ufshcd_quiesce_sdev);
>
> Any reasons why don't use scsi_target_quiesce() here?
As above, now all SCSI devices shall be quiesced here, so I could use
the way in v2: using scsi_target_quiesce() directly here.
Thanks,
Stanley Chu
>
> Thanks,
>
> Can Guo.
>
> >
> > ret = ufshcd_suspend(hba, UFS_SHUTDOWN_PM);
> > out:
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2020-08-03 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 4:25 [PATCH v6] scsi: ufs: Quiesce all scsi devices before shutdown Stanley Chu
2020-08-03 5:03 ` Can Guo
2020-08-03 9:58 ` Stanley Chu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1596448684.32283.25.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).