From: Frankie Chang <Frankie.Chang@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org,
"Arve Hjønnevåg" <arve@android.com>,
"Jian-Min Liu" <Jian-Min.Liu@mediatek.com>,
linux-mediatek@lists.infradead.org,
"Joel Fernandes" <joel@joelfernandes.org>,
"Martijn Coenen" <maco@android.com>,
"Christian Brauner" <christian@brauner.io>,
"Todd Kjos" <tkjos@google.com>
Subject: Re: [PATCH v8 3/3] binder: add transaction latency tracer
Date: Mon, 7 Sep 2020 21:51:15 +0800 [thread overview]
Message-ID: <1599486675.16905.34.camel@mtkswgap22> (raw)
In-Reply-To: <20200907122557.GC2029056@kroah.com>
On Mon, 2020-09-07 at 14:25 +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 07, 2020 at 08:00:55PM +0800, Frankie Chang wrote:
> > From: "Frankie.Chang" <Frankie.Chang@mediatek.com>
> >
> > Record start/end timestamp for binder transaction.
> > When transaction is completed or transaction is free,
> > it would be checked if transaction latency over threshold
> > (default 2 sec), if yes, printing related information for tracing.
> >
> > /* Implement details */
> > - Add latency tracer module to monitor transaction
> > by attaching to new tracepoints introduced
> > when transactions are allocated and freed.
> > The trace_binder_txn_latency_free would not be enabled
> > by default. Monitoring which transaction is too slow to
> > cause some of exceptions is important. So we hook the
> > tracepoint to call the monitor function.
> >
> > - Since some of modules would trigger timeout NE
> > if their binder transaction don't finish in time,
> > such as audio timeout (5 sec), even BT command
> > timeout (2 sec), etc.
> > Therefore, setting the timeout threshold as default
> > 2 seconds could be helpful to debug.
> > But this timeout threshold is configurable, to let
> > all users determine the more suitable threshold.
> >
> > - The reason why printing the related information to
> > kernel information log but not trace buffer is that
> > some abnormal transactions may be pending for a long
> > time ago, they could not be recorded due to buffer
> > limited.
> >
> > Signed-off-by: Frankie.Chang <Frankie.Chang@mediatek.com>
> > Acked-by: Todd Kjos <tkjos@google.com>
> > ---
> > drivers/android/Kconfig | 8 +++
> > drivers/android/Makefile | 1 +
> > drivers/android/binder.c | 6 ++
> > drivers/android/binder_internal.h | 13 ++++
> > drivers/android/binder_latency_tracer.c | 112 +++++++++++++++++++++++++++++++
> > drivers/android/binder_trace.h | 26 ++++++-
> > 6 files changed, 163 insertions(+), 3 deletions(-)
> > create mode 100644 drivers/android/binder_latency_tracer.c
> >
> > diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig
> > index 53b22e2..8aadaf4 100644
> > --- a/drivers/android/Kconfig
> > +++ b/drivers/android/Kconfig
> > @@ -54,6 +54,14 @@ config ANDROID_BINDER_IPC_SELFTEST
> > exhaustively with combinations of various buffer sizes and
> > alignments.
> >
> > +config BINDER_TRANSACTION_LATENCY_TRACKING
> > + tristate "Android Binder transaction tracking"
> > + help
> > + Used for track abnormal binder transaction which is over threshold,
> > + when the transaction is done or be free, this transaction would be
> > + checked whether it executed overtime.
> > + If yes, printing out the detailed info.
> > +
> > endif # if ANDROID
> >
> > endmenu
> > diff --git a/drivers/android/Makefile b/drivers/android/Makefile
> > index c9d3d0c9..c2ffdb6 100644
> > --- a/drivers/android/Makefile
> > +++ b/drivers/android/Makefile
> > @@ -4,3 +4,4 @@ ccflags-y += -I$(src) # needed for trace events
> > obj-$(CONFIG_ANDROID_BINDERFS) += binderfs.o
> > obj-$(CONFIG_ANDROID_BINDER_IPC) += binder.o binder_alloc.o
> > obj-$(CONFIG_ANDROID_BINDER_IPC_SELFTEST) += binder_alloc_selftest.o
> > +obj-$(CONFIG_BINDER_TRANSACTION_LATENCY_TRACKING) += binder_latency_tracer.o
> > diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> > index 0cab900..65ad38c 100644
> > --- a/drivers/android/binder.c
> > +++ b/drivers/android/binder.c
> > @@ -2674,6 +2674,7 @@ static void binder_transaction(struct binder_proc *proc,
> > return_error_line = __LINE__;
> > goto err_alloc_t_failed;
> > }
> > + trace_binder_txn_latency_alloc(t);
> > INIT_LIST_HEAD(&t->fd_fixups);
> > binder_stats_created(BINDER_STAT_TRANSACTION);
> > spin_lock_init(&t->lock);
> > @@ -5177,6 +5178,7 @@ static void print_binder_transaction_ilocked(struct seq_file *m,
> > to_proc ? to_proc->pid : 0,
> > t->to_thread ? t->to_thread->pid : 0,
> > t->code, t->flags, t->priority, t->need_reply);
> > + trace_binder_txn_latency_info(m, t);
> > spin_unlock(&t->lock);
> >
> > if (proc != to_proc) {
> > @@ -5818,4 +5820,8 @@ static int __init binder_init(void)
> > #define CREATE_TRACE_POINTS
> > #include "binder_trace.h"
> >
> > +EXPORT_TRACEPOINT_SYMBOL(binder_txn_latency_alloc);
> > +EXPORT_TRACEPOINT_SYMBOL(binder_txn_latency_info);
> > +EXPORT_TRACEPOINT_SYMBOL(binder_txn_latency_free);
> > +
> > MODULE_LICENSE("GPL v2");
> > diff --git a/drivers/android/binder_internal.h b/drivers/android/binder_internal.h
> > index 872232f..309d1b10 100644
> > --- a/drivers/android/binder_internal.h
> > +++ b/drivers/android/binder_internal.h
> > @@ -15,6 +15,11 @@
> > #include <uapi/linux/android/binderfs.h>
> > #include "binder_alloc.h"
> >
> > +#if IS_ENABLED(CONFIG_BINDER_TRANSACTION_LATENCY_TRACKING)
> > +#include <uapi/linux/time_types.h>
> > +#include <linux/rtc.h>
> > +#endif
> > +
> > struct binder_context {
> > struct binder_node *binder_context_mgr_node;
> > struct mutex context_mgr_node_lock;
> > @@ -524,6 +529,14 @@ struct binder_transaction {
> > * during thread teardown
> > */
> > spinlock_t lock;
> > + /**
> > + * @timestamp and @tv are used to record the time
> > + * that the binder transaction startup
> > + */
> > +#if IS_ENABLED(CONFIG_BINDER_TRANSACTION_LATENCY_TRACKING)
> > + struct timespec64 timestamp;
> > + struct __kernel_old_timeval tv;
>
> As I stated in the 0/3 email, please use the correct in-kernel structure
> for this. That structure is _ONLY_ for old userspace api compatibility
> issues. Which is not the case here at all.
>
> thanks,
> greg k-h
Since it's not proper to use timeval & __kernel_old_timeval.
The remaining structure with tv_usec that I found is
__kernel_timex_timeval, but I'm not sure if this is proper one or not.
All I can see is in
https://lwn.net/ml/linux-kernel/20180705213604.18883-6-deepa.kernel@gmail.com/
I'm afraid of using wrong structure again.
Could you give me some advices about this?
Or is there another suitable way to replace timeval
Many thanks,
Frankie
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-09-07 13:52 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 6:52 [PATCH v1 1/1] binder: transaction latency tracking for user build Frankie Chang
2020-02-05 9:36 ` Greg Kroah-Hartman
2020-02-05 15:49 ` Joel Fernandes
2020-02-07 3:10 ` Frankie Chang
2020-02-07 3:17 ` Joel Fernandes
2020-02-07 6:28 ` Frankie Chang
2020-02-07 13:26 ` Joel Fernandes
2020-04-13 6:24 ` Frankie Chang
2020-04-15 5:37 ` [PATCH v2] " Frankie Chang
2020-04-15 5:37 ` [PATCH v2 1/1] " Frankie Chang
2020-04-15 22:25 ` Todd Kjos
2020-04-29 8:32 ` Frankie Chang
2020-04-30 8:13 ` Frankie Chang
2020-04-30 8:13 ` [PATCH v3 1/1] " Frankie Chang
2020-04-30 8:50 ` Greg Kroah-Hartman
2020-04-30 8:51 ` Greg Kroah-Hartman
2020-05-07 8:10 ` Frankie Chang
2020-05-07 8:10 ` [PATCH v4 1/3] binder: move structs from core file to header file Frankie Chang
2020-05-07 8:10 ` [PATCH v4 2/3] binder: add trace at free transaction Frankie Chang
2020-05-07 8:10 ` [PATCH v4 3/3] binder: add transaction latency tracer Frankie Chang
2020-05-07 8:55 ` Greg Kroah-Hartman
2020-05-11 12:32 ` Frankie Chang
2020-06-10 12:23 ` [PATCH v5] binder: transaction latency tracking for user build Frankie Chang
2020-06-10 12:23 ` [PATCH v5 1/3] binder: move structs from core file to header file Frankie Chang
2020-06-10 12:23 ` [PATCH v5 2/3] binder: add trace at free transaction Frankie Chang
2020-07-20 18:23 ` Todd Kjos
2020-07-23 2:47 ` Frankie Chang
2020-06-10 12:23 ` [PATCH v5 3/3] binder: add transaction latency tracer Frankie Chang
2020-07-20 18:56 ` Todd Kjos
2020-07-23 3:01 ` Frankie Chang
2020-07-02 13:25 ` [PATCH v5] binder: transaction latency tracking for user build Frankie Chang
2020-07-20 13:40 ` Frankie Chang
2020-07-28 3:19 ` [PATCH v6] " Frankie Chang
2020-07-28 3:19 ` [PATCH v6 1/3] binder: move structs from core file to header file Frankie Chang
2020-07-28 3:20 ` [PATCH v6 2/3] binder: add trace at free transaction Frankie Chang
2020-07-31 18:50 ` Todd Kjos
2020-08-03 3:11 ` Frankie Chang
2020-08-03 15:12 ` Todd Kjos
2020-08-04 2:45 ` Frankie Chang
2020-08-04 13:59 ` [PATCH v7] binder: transaction latency tracking for user build Frankie Chang
2020-08-04 13:59 ` [PATCH v7 1/3] binder: move structs from core file to header file Frankie Chang
2020-08-04 15:24 ` Todd Kjos
2020-08-04 13:59 ` [PATCH v7 2/3] binder: add trace at free transaction Frankie Chang
2020-08-04 15:26 ` Todd Kjos
2020-08-04 13:59 ` [PATCH v7 3/3] binder: add transaction latency tracer Frankie Chang
2020-08-04 15:28 ` Todd Kjos
2020-09-07 14:41 ` peter enderborg
2020-09-03 16:21 ` [PATCH v7] binder: transaction latency tracking for user build Greg Kroah-Hartman
2020-09-07 6:49 ` Frankie Chang
2020-09-07 7:00 ` Greg Kroah-Hartman
2020-09-07 12:00 ` [PATCH v8] " Frankie Chang
2020-09-07 12:00 ` [PATCH v8 1/3] binder: move structs from core file to header file Frankie Chang
2020-09-07 12:00 ` [PATCH v8 2/3] binder: add trace at free transaction Frankie Chang
2020-09-07 12:00 ` [PATCH v8 3/3] binder: add transaction latency tracer Frankie Chang
2020-09-07 12:25 ` Greg Kroah-Hartman
2020-09-07 13:51 ` Frankie Chang [this message]
2020-09-07 14:09 ` Greg Kroah-Hartman
2020-09-08 5:38 ` Frankie Chang
2020-09-08 14:06 ` [PATCH v9] binder: transaction latency tracking for user build Frankie Chang
2020-09-08 14:06 ` [PATCH v9 1/3] binder: move structs from core file to header file Frankie Chang
2020-09-08 14:06 ` [PATCH v9 2/3] binder: add trace at free transaction Frankie Chang
2020-09-08 14:06 ` [PATCH v9 3/3] binder: add transaction latency tracer Frankie Chang
2020-09-16 17:38 ` Greg Kroah-Hartman
2020-10-15 17:02 ` [PATCH v10 " Frankie Chang
2020-10-15 17:02 ` [PATCH v10 1/3] binder: move structs from core file to header file Frankie Chang
2020-10-15 17:02 ` [PATCH v10 2/3] binder: add trace at free transaction Frankie Chang
2020-10-15 17:02 ` [PATCH v10 3/3] binder: add transaction latency tracer Frankie Chang
2020-09-16 15:29 ` [PATCH v9] binder: transaction latency tracking for user build Greg Kroah-Hartman
2020-09-07 12:24 ` [PATCH v8] " Greg Kroah-Hartman
2020-07-28 3:20 ` [PATCH v6 3/3] binder: add transaction latency tracer Frankie Chang
2020-05-07 18:21 ` [PATCH v4 " Todd Kjos
2020-05-11 12:35 ` Frankie Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1599486675.16905.34.camel@mtkswgap22 \
--to=frankie.chang@mediatek.com \
--cc=Jian-Min.Liu@mediatek.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maco@android.com \
--cc=tkjos@google.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).