Re: [PATCH 16/22] drm/tidss: Use simple encoder

From: Jyri Sarha <jsarha@ti.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, <airlied@linux.ie>,
	<daniel@ffwll.ch>, <sam@ravnborg.org>, <abrodkin@synopsys.com>,
	<bbrezillon@kernel.org>, <nicolas.ferre@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<ludovic.desroches@microchip.com>,
	<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
	<jingoohan1@gmail.com>, <inki.dae@samsung.com>,
	<jy0922.shim@samsung.com>, <sw0312.kim@samsung.com>,
	<kyungmin.park@samsung.com>, <kgene@kernel.org>,
	<krzk@kernel.org>, <stefan@agner.ch>, <alison.wang@nxp.com>,
	<patrik.r.jakobsson@gmail.com>, <xinliang.liu@linaro.org>,
	<zourongrong@gmail.com>, <john.stultz@linaro.org>,
	<kong.kongxinwei@hisilicon.com>, <puck.chen@hisilicon.com>,
	<linux@armlinux.org.uk>, <p.zabel@pengutronix.de>,
	<shawnguo@kernel.org>, <s.hauer@pengutronix.de>,
	<kernel@pengutronix.de>, <festevam@gmail.com>,
	<linux-imx@nxp.com>, <paul@crapouillou.net>, <ck.hu@mediatek.com>,
	<matthias.bgg@gmail.com>, <laurent.pinchart@ideasonboard.com>,
	<kieran.bingham+renesas@ideasonboard.com>, <hjc@rock-chips.com>,
	<heiko@sntech.de>, <wens@csie.org>, <jernej.skrabec@siol.net>,
	<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
	<tomi.valkeinen@ti.com>, <eric@anholt.net>, <kraxel@redhat.com>,
	<rodrigosiqueiramelo@gmail.com>, <hamohammed.sa@gmail.com>,
	<sebastian.reichel@collabora.com>
Cc: linux-samsung-soc@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	linux-rockchip@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 16/22] drm/tidss: Use simple encoder
Date: Fri, 6 Mar 2020 18:02:15 +0200	[thread overview]
Message-ID: <15f51fa1-d3c3-3381-4d0b-a54ee9f21e1a@ti.com> (raw)
In-Reply-To: <20200305155950.2705-17-tzimmermann@suse.de>

On 05/03/2020 17:59, Thomas Zimmermann wrote:
> The tidss driver uses an empty implementation for its encoder. Replace
> the code with the generic simple encoder.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

Acked-by: Jyri Sarha <jsarha@ti.com>

> ---
>  drivers/gpu/drm/tidss/tidss_encoder.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tidss/tidss_encoder.c b/drivers/gpu/drm/tidss/tidss_encoder.c
> index 83785b0a66a9..4c0558286f5e 100644
> --- a/drivers/gpu/drm/tidss/tidss_encoder.c
> +++ b/drivers/gpu/drm/tidss/tidss_encoder.c
> @@ -8,8 +8,9 @@
>  
>  #include <drm/drm_crtc.h>
>  #include <drm/drm_crtc_helper.h>
> -#include <drm/drm_panel.h>
>  #include <drm/drm_of.h>
> +#include <drm/drm_panel.h>
> +#include <drm/drm_simple_kms_helper.h>
>  
>  #include "tidss_crtc.h"
>  #include "tidss_drv.h"
> @@ -59,10 +60,6 @@ static const struct drm_encoder_helper_funcs encoder_helper_funcs = {
>  	.atomic_check = tidss_encoder_atomic_check,
>  };
>  
> -static const struct drm_encoder_funcs encoder_funcs = {
> -	.destroy = drm_encoder_cleanup,
> -};
> -
>  struct drm_encoder *tidss_encoder_create(struct tidss_device *tidss,
>  					 u32 encoder_type, u32 possible_crtcs)
>  {
> @@ -75,8 +72,7 @@ struct drm_encoder *tidss_encoder_create(struct tidss_device *tidss,
>  
>  	enc->possible_crtcs = possible_crtcs;
>  
> -	ret = drm_encoder_init(&tidss->ddev, enc, &encoder_funcs,
> -			       encoder_type, NULL);
> +	ret = drm_simple_encoder_init(&tidss->ddev, enc, encoder_type);
>  	if (ret < 0)
>  		return ERR_PTR(ret);
>  
> 


-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek