From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 407D6C433E2 for ; Wed, 16 Sep 2020 09:09:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7C0C2087D for ; Wed, 16 Sep 2020 09:09:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZIm062lL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="ePcc68cA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7C0C2087D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TuUdHcQ1x6E8SBSNSyCZ5fhYg2uCf6UwkRPeK/W5m8Y=; b=ZIm062lLxDrNPUKVwEY7tckS4 Q0K/Zt1NeVasSysAv1lNyvSBx2UXPmVguTzFEl5efB1SAwqH0rOSaFCqrITHuOrNGqvd+pvYmVrjk ed9aAcOMzrw5fPLRZCtKnhNyJqKuwEZjBlkPel3wOidiTkwv0ZlRQ8DV7+gutF25vtHM78ig5A44k 3LwKn4a2T6HZ08Wb3hu+Gh/+mN7CbdJk8ImW8xhKh2HZCygOL+8/MFaKVxXwbfhptdU77NTjDZ4cT TRikCtQfjqGyUy5vZiJrNrkjcfxBKNLgfmExlgfo1hoU+965Yz7qVC7/egKgrB6VbK8REnJAzzvYO UE1DfiiZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kITRE-00072g-5H; Wed, 16 Sep 2020 09:09:16 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kITR6-00070M-Jk; Wed, 16 Sep 2020 09:09:12 +0000 X-UUID: 7aff3da3e9f6471aafbb385f4df9a6f2-20200916 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=6/Tv0FndX29EmMtcgOUoLXSwSSkphI8VR0atrPZZgPQ=; b=ePcc68cAqwZlX+YDeW3Mwfw89EPll3Xlg10AGizm8HWlBN1e+aW6j/bmfL8GeMZfwr6OfLY4TUBbqLw69l4WOsMrskRnOsXGXd1c12PhVgxoqu3zLPzvr5kiIGUwhWgM8RsUv4wPoUAmVnnTvyNfJTxY1qHa/9X7yGxT6y/aTyE=; X-UUID: 7aff3da3e9f6471aafbb385f4df9a6f2-20200916 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 163843518; Wed, 16 Sep 2020 01:09:00 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 16 Sep 2020 01:58:58 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 16 Sep 2020 16:58:55 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 16 Sep 2020 16:58:55 +0800 Message-ID: <1600246737.14155.3.camel@mtkswgap22> Subject: Re: [PATCH v7] Add MediaTek MT6779 devapc driver From: Neal Liu To: Rob Herring , Chun-Kuang Hu , Matthias Brugger Date: Wed, 16 Sep 2020 16:58:57 +0800 In-Reply-To: <1599640627.6370.3.camel@mtkswgap22> References: <1598497593-15781-1-git-send-email-neal.liu@mediatek.com> <1599028813.32069.1.camel@mtkswgap22> <1599640627.6370.3.camel@mtkswgap22> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_050908_833917_8930750E X-CRM114-Status: GOOD ( 23.90 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , wsd_upstream , lkml , "linux-mediatek@lists.infradead.org" , Neal Liu , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Rob, Matthias, Chun-Kuang, Sorry for pushing you so hard. May I know is this patch set is comfortable to apply on latest kernel? Thanks -Neal On Wed, 2020-09-09 at 16:37 +0800, Neal Liu wrote: > Hi Rob, Matthias, Chun-Kuang, > > Please kindly let me know your comments about this patch set. > Thanks > > -Neal > > On Wed, 2020-09-02 at 14:40 +0800, Neal Liu wrote: > > Hi Rob, Matthias, Chun-Kuang, > > > > Gentle ping for this patch set. > > Thanks > > > > -Neal > > > > On Thu, 2020-08-27 at 11:06 +0800, Neal Liu wrote: > > > These patch series introduce a MediaTek MT6779 devapc driver. > > > > > > MediaTek bus fabric provides TrustZone security support and data protection to prevent slaves from being accessed by unexpected masters. > > > The security violation is logged and sent to the processor for further analysis or countermeasures. > > > > > > Any occurrence of security violation would raise an interrupt, and it will be handled by mtk-devapc driver. > > > The violation information is printed in order to find the murderer. > > > > > > changes since v6: > > > - remove unnecessary mask/unmask module irq during ISR. > > > > > > changes since v5: > > > - remove redundant write reg operation. > > > - use static variable of vio_dbgs instead. > > > - add stop_devapc() if driver is removed. > > > > > > changes since v4: > > > - refactor data structure. > > > - merge two simple functions into one. > > > - refactor register setting to prevent too many function call overhead. > > > > > > changes since v3: > > > - revise violation handling flow to make it more easily to understand > > > hardware behavior. > > > - add more comments to understand how hardware works. > > > > > > changes since v2: > > > - pass platform info through DT data. > > > - remove unnecessary function. > > > - remove slave_type because it always equals to 1 in current support SoC. > > > - use vio_idx_num instread of list all devices' index. > > > - add more comments to describe hardware behavior. > > > > > > changes since v1: > > > - move SoC specific part to DT data. > > > - remove unnecessary boundary check. > > > - remove unnecessary data type declaration. > > > - use read_poll_timeout() instread of for loop polling. > > > - revise coding style elegantly. > > > > > > > > > *** BLURB HERE *** > > > > > > Neal Liu (2): > > > dt-bindings: devapc: add bindings for mtk-devapc > > > soc: mediatek: add mt6779 devapc driver > > > > > > .../bindings/soc/mediatek/devapc.yaml | 58 ++++ > > > drivers/soc/mediatek/Kconfig | 9 + > > > drivers/soc/mediatek/Makefile | 1 + > > > drivers/soc/mediatek/mtk-devapc.c | 305 ++++++++++++++++++ > > > 4 files changed, 373 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/devapc.yaml > > > create mode 100644 drivers/soc/mediatek/mtk-devapc.c > > > > > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek