From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D835DC4727F for ; Fri, 25 Sep 2020 10:25:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74F292075E for ; Fri, 25 Sep 2020 10:25:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P+G8kTky"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="N8wJCbgX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74F292075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=omLNq2zwkAgJm6uvAfJ3V0PhPUGKD8koD0zS0q2wtfU=; b=P+G8kTkymSYM+8fNUcKz3jF0v KCcRjmo/FRIxjU3pqUB2pBOYDEl9Ll6+1/9ES0RcTr5fhlSBrktQ0iK7pCn56b5e50/bFIENn4xKz TipHZn4vV+8kogBC1PLUd24mvRVaAHUu4wFkYMLeMfeu2ujRwJpgHzTZYnhcjdyurGSsxPNe0JWPq GnjRN/zHXLb2YZqwpErfte4xiTIyqm8MGDLb80e0y5NT3oP+SCLv73vRaeUATFO9xDIAU0vDZnIAo 6lNhb6JcS0okYJaBmFqI9gPXZsvQsa7VZipoH1CGQXR9Grd+mIAG9GLOgHsLa5QziuHafTNvq7oUC sqcDlVi9Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLkv1-0005at-6L; Fri, 25 Sep 2020 10:25:35 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLkux-0005a9-Ip; Fri, 25 Sep 2020 10:25:33 +0000 X-UUID: cd54fcda55e44bac996c6519d506c8c7-20200925 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=furd6J9lKYw7rEQJct0IXtstQo7k4wrpljtEUJ2R3XM=; b=N8wJCbgXUmJTijCMnBU1JdtQUxzkc8/F7ijdUUzpmXT+UInL5DGxgRg/K6Zo235bcYtcKD51h3aPta8hspDOLVgtQylyyWtuCRjHSdXkgjIxxM95GM+FJ3iPyZOMJ4djGyc+IyPVcLLb8vknBZuOUBbQjU/X0BFlCWc3lNotLIM=; X-UUID: cd54fcda55e44bac996c6519d506c8c7-20200925 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 815120003; Fri, 25 Sep 2020 02:25:25 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Sep 2020 03:25:23 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Sep 2020 18:25:21 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 25 Sep 2020 18:25:21 +0800 Message-ID: <1601029522.1346.53.camel@mtksdaap41> Subject: Re: [PATCH 02/12] soc: mediatek: Add MediaTek SCPSYS power domains From: Weiyi Lu To: Enric Balletbo i Serra Date: Fri, 25 Sep 2020 18:25:22 +0800 In-Reply-To: <20200910172826.3074357-3-enric.balletbo@collabora.com> References: <20200910172826.3074357-1-enric.balletbo@collabora.com> <20200910172826.3074357-3-enric.balletbo@collabora.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200925_062531_877383_7D18C8FF X-CRM114-Status: GOOD ( 28.18 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, linux-kernel@vger.kernel.org, fparent@baylibre.com, Matthias Brugger , linux-mediatek@lists.infradead.org, hsinyi@chromium.org, matthias.bgg@gmail.com, Collabora Kernel ML , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2020-09-10 at 19:28 +0200, Enric Balletbo i Serra wrote: > The System Control Processor System (SCPSYS) has several power management > related tasks in the system. This driver implements support to handle > the different power domains supported in order to meet high performance > and low power requirements. > > Co-developed-by: Matthias Brugger > Signed-off-by: Matthias Brugger > Signed-off-by: Enric Balletbo i Serra > --- > > drivers/soc/mediatek/Kconfig | 13 + > drivers/soc/mediatek/Makefile | 1 + > drivers/soc/mediatek/mtk-pm-domains.c | 626 ++++++++++++++++++++++++++ > 3 files changed, 640 insertions(+) > create mode 100644 drivers/soc/mediatek/mtk-pm-domains.c > > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig > index 59a56cd790ec..68d800f9e4a5 100644 > --- a/drivers/soc/mediatek/Kconfig > +++ b/drivers/soc/mediatek/Kconfig > @@ -44,6 +44,19 @@ config MTK_SCPSYS > Say yes here to add support for the MediaTek SCPSYS power domain > driver. > > +config MTK_SCPSYS_PM_DOMAINS > + bool "MediaTek SCPSYS generic power domain" > + default ARCH_MEDIATEK > + depends on PM > + depends on MTK_INFRACFG > + select PM_GENERIC_DOMAINS > + select REGMAP > + help > + Say y here to enable power domain support. > + In order to meet high performance and low power requirements, the System > + Control Processor System (SCPSYS) has several power management related > + tasks in the system. > + > config MTK_MMSYS > bool "MediaTek MMSYS Support" > default ARCH_MEDIATEK > diff --git a/drivers/soc/mediatek/Makefile b/drivers/soc/mediatek/Makefile > index 01f9f873634a..1e60fb4f89d4 100644 > --- a/drivers/soc/mediatek/Makefile > +++ b/drivers/soc/mediatek/Makefile > @@ -3,4 +3,5 @@ obj-$(CONFIG_MTK_CMDQ) += mtk-cmdq-helper.o > obj-$(CONFIG_MTK_INFRACFG) += mtk-infracfg.o > obj-$(CONFIG_MTK_PMIC_WRAP) += mtk-pmic-wrap.o > obj-$(CONFIG_MTK_SCPSYS) += mtk-scpsys.o > +obj-$(CONFIG_MTK_SCPSYS_PM_DOMAINS) += mtk-pm-domains.o > obj-$(CONFIG_MTK_MMSYS) += mtk-mmsys.o > diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c > new file mode 100644 > index 000000000000..db631dbaf2e3 > --- /dev/null > +++ b/drivers/soc/mediatek/mtk-pm-domains.c > @@ -0,0 +1,626 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2020 Collabora Ltd. > + */ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +#define MTK_POLL_DELAY_US 10 > +#define MTK_POLL_TIMEOUT USEC_PER_SEC > + > +#define MTK_SCPD_ACTIVE_WAKEUP BIT(0) > +#define MTK_SCPD_FWAIT_SRAM BIT(1) > +#define MTK_SCPD_CAPS(_scpd, _x) ((_scpd)->data->caps & (_x)) > + > +#define SPM_VDE_PWR_CON 0x0210 > +#define SPM_MFG_PWR_CON 0x0214 > +#define SPM_VEN_PWR_CON 0x0230 > +#define SPM_ISP_PWR_CON 0x0238 > +#define SPM_DIS_PWR_CON 0x023c > +#define SPM_VEN2_PWR_CON 0x0298 > +#define SPM_AUDIO_PWR_CON 0x029c > +#define SPM_MFG_2D_PWR_CON 0x02c0 > +#define SPM_MFG_ASYNC_PWR_CON 0x02c4 > +#define SPM_USB_PWR_CON 0x02cc > + If me, I'd choose to write directly into the data of each SoC now because it's inconsistent on most MediatTek chips. > +#define SPM_PWR_STATUS 0x060c > +#define SPM_PWR_STATUS_2ND 0x0610 > + > +#define PWR_RST_B_BIT BIT(0) > +#define PWR_ISO_BIT BIT(1) > +#define PWR_ON_BIT BIT(2) > +#define PWR_ON_2ND_BIT BIT(3) > +#define PWR_CLK_DIS_BIT BIT(4) > + > +#define PWR_STATUS_DISP BIT(3) > +#define PWR_STATUS_MFG BIT(4) > +#define PWR_STATUS_ISP BIT(5) > +#define PWR_STATUS_VDEC BIT(7) > +#define PWR_STATUS_VENC_LT BIT(20) > +#define PWR_STATUS_VENC BIT(21) > +#define PWR_STATUS_MFG_2D BIT(22) > +#define PWR_STATUS_MFG_ASYNC BIT(23) > +#define PWR_STATUS_AUDIO BIT(24) > +#define PWR_STATUS_USB BIT(25) > + same here for the status bits. > +struct scpsys_bus_prot_data { > + u32 bus_prot_mask; > + bool bus_prot_reg_update; > +}; > + > +/** > + * struct scpsys_domain_data - scp domain data for power on/off flow > + * @sta_mask: The mask for power on/off status bit. > + * @ctl_offs: The offset for main power control register. > + * @sram_pdn_bits: The mask for sram power control bits. > + * @sram_pdn_ack_bits: The mask for sram power control acked bits. > + * @caps: The flag for active wake-up action. > + * @bp_infracfg: bus protection for infracfg subsystem > + */ > +struct scpsys_domain_data { > + u32 sta_mask; > + int ctl_offs; > + u32 sram_pdn_bits; > + u32 sram_pdn_ack_bits; > + u8 caps; > + const struct scpsys_bus_prot_data bp_infracfg; > +}; > + > +struct scpsys_domain { > + struct generic_pm_domain genpd; > + const struct scpsys_domain_data *data; > + struct scpsys *scpsys; > + int num_clks; > + struct clk_bulk_data *clks; > + struct regmap *infracfg; Could we move struct regmap *infracfg; back to struct scpsys? It seems we need to set this property many times under each power domain sub node in device tree? > +}; > + > +struct scpsys_soc_data { > + const struct scpsys_domain_data *domains; > + int num_domains; > + int pwr_sta_offs; > + int pwr_sta2nd_offs; > +}; > + > +struct scpsys { > + struct device *dev; > + void __iomem *base; > + const struct scpsys_soc_data *soc_data; > + struct genpd_onecell_data pd_data; > + struct generic_pm_domain *domains[]; > +}; > + > +#define to_scpsys_domain(gpd) container_of(gpd, struct scpsys_domain, genpd) > + > +static int scpsys_domain_is_on(struct scpsys_domain *pd) > +{ > + struct scpsys *scpsys = pd->scpsys; > + > + u32 status = readl(scpsys->base + scpsys->soc_data->pwr_sta_offs) & pd->data->sta_mask; > + u32 status2 = readl(scpsys->base + scpsys->soc_data->pwr_sta2nd_offs) & pd->data->sta_mask; > + > + /* > + * A domain is on when both status bits are set. If only one is set > + * return an error. This happens while powering up a domain > + */ > + > + if (status && status2) > + return true; > + if (!status && !status2) > + return false; > + > + return -EINVAL; > +} > + > +static int scpsys_sram_enable(struct scpsys_domain *pd, void __iomem *ctl_addr) > +{ > + u32 pdn_ack = pd->data->sram_pdn_ack_bits; > + u32 val; > + int tmp; > + int ret; > + > + val = readl(ctl_addr); > + val &= ~pd->data->sram_pdn_bits; > + writel(val, ctl_addr); > + > + /* Either wait until SRAM_PDN_ACK all 1 or 0 */ > + ret = readl_poll_timeout(ctl_addr, tmp, (tmp & pdn_ack) == 0, MTK_POLL_DELAY_US, > + MTK_POLL_TIMEOUT); > + if (ret < 0) > + return ret; > + > + return 0; > +} > + > +static int scpsys_sram_disable(struct scpsys_domain *pd, void __iomem *ctl_addr) > +{ > + u32 pdn_ack = pd->data->sram_pdn_ack_bits; > + u32 val; > + int tmp; > + > + val = readl(ctl_addr); > + val |= pd->data->sram_pdn_bits; > + writel(val, ctl_addr); > + > + /* Either wait until SRAM_PDN_ACK all 1 or 0 */ > + return readl_poll_timeout(ctl_addr, tmp, (tmp & pdn_ack) == pdn_ack, MTK_POLL_DELAY_US, > + MTK_POLL_TIMEOUT); > +} > + > +static int scpsys_bus_protect_enable(struct scpsys_domain *pd) > +{ > + const struct scpsys_bus_prot_data *bp_data = &pd->data->bp_infracfg; > + > + if (!bp_data->bus_prot_mask) > + return 0; > + > + return mtk_infracfg_set_bus_protection(pd->infracfg, bp_data->bus_prot_mask, > + bp_data->bus_prot_reg_update); > +} > + > +static int scpsys_bus_protect_disable(struct scpsys_domain *pd) > +{ > + const struct scpsys_bus_prot_data *bp_data = &pd->data->bp_infracfg; > + > + if (!bp_data->bus_prot_mask) > + return 0; > + > + return mtk_infracfg_clear_bus_protection(pd->infracfg, bp_data->bus_prot_mask, > + bp_data->bus_prot_reg_update); > +} > + > +static int scpsys_power_on(struct generic_pm_domain *genpd) > +{ > + struct scpsys_domain *pd = container_of(genpd, struct scpsys_domain, genpd); > + struct scpsys *scpsys = pd->scpsys; > + void __iomem *ctl_addr = scpsys->base + pd->data->ctl_offs; > + int ret, tmp; > + u32 val; > + > + ret = clk_bulk_enable(pd->num_clks, pd->clks); > + if (ret) > + return ret; > + > + /* subsys power on */ > + val = readl(ctl_addr); > + val |= PWR_ON_BIT; > + writel(val, ctl_addr); > + val |= PWR_ON_2ND_BIT; > + writel(val, ctl_addr); > + > + /* wait until PWR_ACK = 1 */ > + ret = readx_poll_timeout(scpsys_domain_is_on, pd, tmp, tmp > 0, MTK_POLL_DELAY_US, > + MTK_POLL_TIMEOUT); > + if (ret < 0) > + goto err_pwr_ack; > + > + val &= ~PWR_CLK_DIS_BIT; > + writel(val, ctl_addr); > + > + val &= ~PWR_ISO_BIT; > + writel(val, ctl_addr); > + > + val |= PWR_RST_B_BIT; > + writel(val, ctl_addr); > + > + ret = scpsys_sram_enable(pd, ctl_addr); > + if (ret < 0) > + goto err_pwr_ack; > + > + ret = scpsys_bus_protect_disable(pd); > + if (ret < 0) > + goto err_pwr_ack; > + > + return 0; > + > +err_pwr_ack: > + clk_bulk_disable(pd->num_clks, pd->clks); > + dev_err(scpsys->dev, "Failed to power on domain %s\n", genpd->name); > + > + return ret; > +} > + > +static int scpsys_power_off(struct generic_pm_domain *genpd) > +{ > + struct scpsys_domain *pd = container_of(genpd, struct scpsys_domain, genpd); > + struct scpsys *scpsys = pd->scpsys; > + void __iomem *ctl_addr = scpsys->base + pd->data->ctl_offs; > + int ret, tmp; > + u32 val; > + > + ret = scpsys_bus_protect_enable(pd); > + if (ret < 0) > + return ret; > + > + ret = scpsys_sram_disable(pd, ctl_addr); > + if (ret < 0) > + return ret; > + > + /* subsys power off */ > + val = readl(ctl_addr); > + val |= PWR_ISO_BIT; > + writel(val, ctl_addr); > + > + val &= ~PWR_RST_B_BIT; > + writel(val, ctl_addr); > + > + val |= PWR_CLK_DIS_BIT; > + writel(val, ctl_addr); > + > + val &= ~PWR_ON_BIT; > + writel(val, ctl_addr); > + > + val &= ~PWR_ON_2ND_BIT; > + writel(val, ctl_addr); > + > + /* wait until PWR_ACK = 0 */ > + ret = readx_poll_timeout(scpsys_domain_is_on, pd, tmp, tmp == 0, MTK_POLL_DELAY_US, > + MTK_POLL_TIMEOUT); > + if (ret < 0) > + return ret; > + > + clk_bulk_disable(pd->num_clks, pd->clks); > + > + return 0; > +} > + > +static int scpsys_add_one_domain(struct scpsys *scpsys, struct device_node *node) > +{ > + const struct scpsys_domain_data *domain_data; > + struct scpsys_domain *pd; > + int i, ret; > + u32 id; > + > + ret = of_property_read_u32(node, "reg", &id); > + if (ret) { > + dev_err(scpsys->dev, "%pOFn: failed to retrieve domain id from reg: %d\n", node, > + ret); > + return -EINVAL; > + } > + > + if (id >= scpsys->soc_data->num_domains) { > + dev_err(scpsys->dev, "%pOFn: invalid domain id %d\n", node, id); > + return -EINVAL; > + } > + > + domain_data = &scpsys->soc_data->domains[id]; > + if (!domain_data) { > + dev_err(scpsys->dev, "%pOFn: undefined domain id %d\n", node, id); > + return -EINVAL; > + } > + > + pd = devm_kzalloc(scpsys->dev, sizeof(*pd), GFP_KERNEL); > + if (!pd) > + return -ENOMEM; > + > + pd->data = domain_data; > + pd->scpsys = scpsys; > + > + pd->infracfg = syscon_regmap_lookup_by_phandle(node, "mediatek,infracfg"); > + if (IS_ERR(pd->infracfg)) > + pd->infracfg = NULL; > + > + pd->num_clks = of_clk_get_parent_count(node); > + if (pd->num_clks > 0) { > + pd->clks = devm_kcalloc(scpsys->dev, pd->num_clks, sizeof(*pd->clks), GFP_KERNEL); > + if (!pd->clks) > + return -ENOMEM; > + } else { > + pd->num_clks = 0; > + } > + > + for (i = 0; i < pd->num_clks; i++) { > + pd->clks[i].clk = of_clk_get(node, i); Is it possible to have a better way that we could use of_clk_bulk_get()? > + if (IS_ERR(pd->clks[i].clk)) { > + ret = PTR_ERR(pd->clks[i].clk); > + dev_err(scpsys->dev, "%pOFn: failed to get clk at index %d: %d\n", node, i, > + ret); > + return ret; > + } > + } > + > + ret = clk_bulk_prepare(pd->num_clks, pd->clks); > + if (ret) > + goto err_put_clocks; > + > + /* > + * Initially turn on all domains to make the domains usable > + * with !CONFIG_PM and to get the hardware in sync with the > + * software. The unused domains will be switched off during > + * late_init time. > + */ > + ret = scpsys_power_on(&pd->genpd); > + if (ret < 0) { > + dev_err(scpsys->dev, "failed to power on domain %pOFN with error %d\n", node, ret); > + goto err_unprepare_clocks; > + } > + > + pd->genpd.name = node->name; > + pd->genpd.power_off = scpsys_power_off; > + pd->genpd.power_on = scpsys_power_on; > + > + pm_genpd_init(&pd->genpd, NULL, false); > + > + scpsys->domains[id] = &pd->genpd; > + return 0; > + > +err_unprepare_clocks: > + clk_bulk_unprepare(pd->num_clks, pd->clks); > +err_put_clocks: > + clk_bulk_put(pd->num_clks, pd->clks); > + devm_kfree(scpsys->dev, pd->clks); > + pd->num_clks = 0; > + return ret; > +} > + > +static int scpsys_add_subdomain(struct scpsys *scpsys, struct device_node *parent) > +{ > + struct device_node *child; > + struct generic_pm_domain *child_pd, *parent_pd; > + int ret; > + > + for_each_child_of_node(parent, child) { > + u32 id; > + > + ret = of_property_read_u32(parent, "reg", &id); > + if (ret) { > + dev_err(scpsys->dev, "%pOFn: failed to get parent domain id: %d\n", child, > + ret); > + goto err_put_node; > + } > + parent_pd = scpsys->pd_data.domains[id]; > + nit. Could we move parent outside(in front of) the loop? > + ret = scpsys_add_one_domain(scpsys, child); > + if (ret) { > + dev_err(scpsys->dev, "error adding power domain for %pOFn: %d\n", child, > + ret); > + goto err_put_node; > + } > + > + ret = of_property_read_u32(child, "reg", &id); > + if (ret) { > + dev_err(scpsys->dev, "%pOFn: failed to get child domain id: %d\n", child, > + ret); > + goto err_put_node; > + } > + child_pd = scpsys->pd_data.domains[id]; > + > + ret = pm_genpd_add_subdomain(parent_pd, child_pd); > + if (ret) { > + dev_err(scpsys->dev, "failed to add %s subdomain to parent %s\n", > + child_pd->name, parent_pd->name); > + goto err_put_node; > + } else { > + dev_dbg(scpsys->dev, "%s add subdomain: %s\n", parent_pd->name, > + child_pd->name); > + } > + > + /* recursive call to add all subdomains */ > + ret = scpsys_add_subdomain(scpsys, child); > + if (ret) > + goto err_put_node; > + } > + > + return 0; > + > +err_put_node: > + of_node_put(child); > + return ret; > +} > + > +static void scpsys_remove_one_domain(struct scpsys_domain *pd) > +{ > + int ret; > + > + /* > + * We're in the error cleanup already, so we only complain, > + * but won't emit another error on top of the original one. > + */ > + ret = pm_genpd_remove(&pd->genpd); > + if (ret < 0) > + dev_err(pd->scpsys->dev, > + "failed to remove domain '%s' : %d - state may be inconsistent\n", > + pd->genpd.name, ret); > + > + scpsys_power_off(&pd->genpd); > + > + clk_bulk_unprepare(pd->num_clks, pd->clks); > + clk_bulk_put(pd->num_clks, pd->clks); > + pd->num_clks = 0; > +} > + > +static void scpsys_domain_cleanup(struct scpsys *scpsys) > +{ > + struct generic_pm_domain *genpd; > + struct scpsys_domain *pd; > + int i; > + > + for (i = scpsys->pd_data.num_domains - 1; i >= 0; i--) { > + genpd = scpsys->pd_data.domains[i]; > + if (genpd) { > + pd = to_scpsys_domain(genpd); > + scpsys_remove_one_domain(pd); > + } > + } > +} > + > +/* > + * MT8173 power domain support > + */ > + > +static const struct scpsys_domain_data scpsys_domain_data_mt8173[] = { > + [MT8173_POWER_DOMAIN_VDEC] = { > + .sta_mask = PWR_STATUS_VDEC, > + .ctl_offs = SPM_VDE_PWR_CON, > + .sram_pdn_bits = GENMASK(11, 8), > + .sram_pdn_ack_bits = GENMASK(12, 12), > + }, > + [MT8173_POWER_DOMAIN_VENC] = { > + .sta_mask = PWR_STATUS_VENC, > + .ctl_offs = SPM_VEN_PWR_CON, > + .sram_pdn_bits = GENMASK(11, 8), > + .sram_pdn_ack_bits = GENMASK(15, 12), > + }, > + [MT8173_POWER_DOMAIN_ISP] = { > + .sta_mask = PWR_STATUS_ISP, > + .ctl_offs = SPM_ISP_PWR_CON, > + .sram_pdn_bits = GENMASK(11, 8), > + .sram_pdn_ack_bits = GENMASK(13, 12), > + }, > + [MT8173_POWER_DOMAIN_MM] = { > + .sta_mask = PWR_STATUS_DISP, > + .ctl_offs = SPM_DIS_PWR_CON, > + .sram_pdn_bits = GENMASK(11, 8), > + .sram_pdn_ack_bits = GENMASK(12, 12), > + .bp_infracfg = { > + .bus_prot_reg_update = true, > + .bus_prot_mask = MT8173_TOP_AXI_PROT_EN_MM_M0 | > + MT8173_TOP_AXI_PROT_EN_MM_M1, > + }, > + }, > + [MT8173_POWER_DOMAIN_VENC_LT] = { > + .sta_mask = PWR_STATUS_VENC_LT, > + .ctl_offs = SPM_VEN2_PWR_CON, > + .sram_pdn_bits = GENMASK(11, 8), > + .sram_pdn_ack_bits = GENMASK(15, 12), > + }, > + [MT8173_POWER_DOMAIN_AUDIO] = { > + .sta_mask = PWR_STATUS_AUDIO, > + .ctl_offs = SPM_AUDIO_PWR_CON, > + .sram_pdn_bits = GENMASK(11, 8), > + .sram_pdn_ack_bits = GENMASK(15, 12), > + }, > + [MT8173_POWER_DOMAIN_USB] = { > + .sta_mask = PWR_STATUS_USB, > + .ctl_offs = SPM_USB_PWR_CON, > + .sram_pdn_bits = GENMASK(11, 8), > + .sram_pdn_ack_bits = GENMASK(15, 12), > + .caps = MTK_SCPD_ACTIVE_WAKEUP, > + }, > + [MT8173_POWER_DOMAIN_MFG_ASYNC] = { > + .sta_mask = PWR_STATUS_MFG_ASYNC, > + .ctl_offs = SPM_MFG_ASYNC_PWR_CON, > + .sram_pdn_bits = GENMASK(11, 8), > + .sram_pdn_ack_bits = 0, > + }, > + [MT8173_POWER_DOMAIN_MFG_2D] = { > + .sta_mask = PWR_STATUS_MFG_2D, > + .ctl_offs = SPM_MFG_2D_PWR_CON, > + .sram_pdn_bits = GENMASK(11, 8), > + .sram_pdn_ack_bits = GENMASK(13, 12), > + }, > + [MT8173_POWER_DOMAIN_MFG] = { > + .sta_mask = PWR_STATUS_MFG, > + .ctl_offs = SPM_MFG_PWR_CON, > + .sram_pdn_bits = GENMASK(13, 8), > + .sram_pdn_ack_bits = GENMASK(21, 16), > + .bp_infracfg = { > + .bus_prot_reg_update = true, > + .bus_prot_mask = MT8173_TOP_AXI_PROT_EN_MFG_S | > + MT8173_TOP_AXI_PROT_EN_MFG_M0 | > + MT8173_TOP_AXI_PROT_EN_MFG_M1 | > + MT8173_TOP_AXI_PROT_EN_MFG_SNOOP_OUT, > + }, > + }, > +}; > + > +static const struct scpsys_soc_data mt8173_scpsys_data = { > + .domains = scpsys_domain_data_mt8173, > + .num_domains = ARRAY_SIZE(scpsys_domain_data_mt8173), > + .pwr_sta_offs = SPM_PWR_STATUS, > + .pwr_sta2nd_offs = SPM_PWR_STATUS_2ND, > +}; > + > +static const struct of_device_id scpsys_of_match[] = { > + { > + .compatible = "mediatek,mt8173-power-controller", > + .data = &mt8173_scpsys_data, > + }, > + { } > +}; > + > +static int scpsys_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct device_node *np = dev->of_node; > + const struct scpsys_soc_data *soc; > + struct device_node *node; > + struct scpsys *scpsys; > + struct resource *res; > + int ret; > + > + soc = of_device_get_match_data(&pdev->dev); > + if (!soc) { > + dev_err(&pdev->dev, "no power controller data\n"); > + return -EINVAL; > + } > + > + scpsys = devm_kzalloc(dev, struct_size(scpsys, domains, soc->num_domains), GFP_KERNEL); > + if (!scpsys) > + return -ENOMEM; > + > + scpsys->dev = dev; > + scpsys->soc_data = soc; > + > + scpsys->pd_data.domains = scpsys->domains; > + scpsys->pd_data.num_domains = soc->num_domains; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + scpsys->base = devm_ioremap_resource(dev, res); > + if (IS_ERR(scpsys->base)) > + return -ENODEV; > + > + ret = -ENODEV; > + for_each_available_child_of_node(np, node) { > + ret = scpsys_add_one_domain(scpsys, node); > + if (ret) { > + dev_err(dev, "failed to handle node %pOFN: %d\n", node, ret); > + of_node_put(node); > + goto err_cleanup_domains; > + } > + > + ret = scpsys_add_subdomain(scpsys, node); > + if (ret) { > + dev_err(dev, "failed to add subdomain node %pOFn: %d\n", node, ret); > + of_node_put(node); > + goto err_cleanup_domains; > + } > + } > + > + if (ret) { > + dev_dbg(dev, "no power domains present\n"); > + return ret; > + } > + > + ret = of_genpd_add_provider_onecell(np, &scpsys->pd_data); > + if (ret) { > + dev_err(dev, "failed to add provider: %d\n", ret); > + goto err_cleanup_domains; > + } > + > + return 0; > + > +err_cleanup_domains: > + scpsys_domain_cleanup(scpsys); > + return ret; > +} > + > +static struct platform_driver scpsys_pm_domain_driver = { > + .probe = scpsys_probe, > + .driver = { > + .name = "mtk-power-controller", > + .suppress_bind_attrs = true, > + .of_match_table = scpsys_of_match, > + }, > +}; > +builtin_platform_driver(scpsys_pm_domain_driver); _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek