From: Yongqiang Niu <yongqiang.niu@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
"Rob Herring" <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-mediatek@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>,
Hsin-Yi Wang <hsinyi@chromium.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9, 09/11] drm/mediatek: enable dither function
Date: Thu, 7 Jan 2021 11:11:19 +0800 [thread overview]
Message-ID: <1609989081-29353-10-git-send-email-yongqiang.niu@mediatek.com> (raw)
In-Reply-To: <1609989081-29353-1-git-send-email-yongqiang.niu@mediatek.com>
for 5 or 6 bpc panel, we need enable dither function
to improve the display quality
Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 38 ++++++++++++++++++++++++++++-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
index 03589c9..81ed076 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
@@ -53,7 +53,9 @@
#define DITHER_EN BIT(0)
#define DISP_DITHER_CFG 0x0020
#define DITHER_RELAY_MODE BIT(0)
+#define DITHER_ENGINE_EN BIT(1)
#define DISP_DITHER_SIZE 0x0030
+#define DITHER_REG(idx) (0x100 + (idx) * 4)
#define LUT_10BIT_MASK 0x03ff
@@ -258,8 +260,42 @@ static void mtk_dither_config(struct mtk_ddp_comp *comp, unsigned int w,
unsigned int h, unsigned int vrefresh,
unsigned int bpc, struct cmdq_pkt *cmdq_pkt)
{
+ bool enable = true;
+
+ const u32 dither_setting[] = {
+ 0x00000000, /* 5 */
+ 0x00003002, /* 6 */
+ 0x00000000, /* 7 */
+ 0x00000000, /* 8 */
+ 0x00000000, /* 9 */
+ 0x00000000, /* 10 */
+ 0x00000000, /* 11 */
+ 0x00000011, /* 12 */
+ 0x00000000, /* 13 */
+ 0x00000000, /* 14 */
+ };
+
+ if (bpc == 6) {
+ mtk_ddp_write(cmdq_pkt, 0x40400001, comp, DITHER_REG(15));
+ mtk_ddp_write(cmdq_pkt, 0x40404040, comp, DITHER_REG(16));
+ } else if (bpc == 5) {
+ mtk_ddp_write(cmdq_pkt, 0x50500001, comp, DITHER_REG(15));
+ mtk_ddp_write(cmdq_pkt, 0x50504040, comp, DITHER_REG(16));
+ } else {
+ enable = false;
+ }
+
+ if (enable) {
+ u32 idx;
+
+ for (idx = 0; idx < ARRAY_SIZE(dither_setting); idx++)
+ mtk_ddp_write(cmdq_pkt, dither_setting[idx], comp,
+ DITHER_REG(idx + 5));
+ }
+
mtk_ddp_write(cmdq_pkt, h << 16 | w, comp, DISP_DITHER_SIZE);
- mtk_ddp_write(cmdq_pkt, DITHER_RELAY_MODE, comp, DISP_DITHER_CFG);
+ mtk_ddp_write(cmdq_pkt, enable ? DITHER_ENGINE_EN : DITHER_RELAY_MODE,
+ comp, DISP_DITHER_CFG);
}
static void mtk_dither_start(struct mtk_ddp_comp *comp)
--
1.8.1.1.dirty
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-01-07 3:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 3:11 [PATCH v9, 00/11] drm/mediatek: add support for mediatek SOC MT8183 Yongqiang Niu
2021-01-07 3:11 ` [PATCH v9, 01/11] dt-bindings: mediatek: add rdma-fifo-size description for mt8183 display Yongqiang Niu
2021-01-07 9:54 ` Chun-Kuang Hu
2021-01-12 14:49 ` Rob Herring
2021-01-13 15:28 ` Chun-Kuang Hu
2021-01-07 3:11 ` [PATCH v9, 02/11] dt-bindings: mediatek: add " Yongqiang Niu
2021-01-07 10:17 ` Chun-Kuang Hu
2021-01-07 3:11 ` [PATCH v9, 03/11] arm64: dts: mt8183: rename rdma fifo size Yongqiang Niu
2021-01-07 9:58 ` Chun-Kuang Hu
2021-01-07 3:11 ` [PATCH v9, 04/11] arm64: dts: mt8183: refine gamma compatible name Yongqiang Niu
2021-01-07 3:11 ` [PATCH v9, 05/11] drm/mediatek: add fifo_size into rdma private data Yongqiang Niu
2021-01-07 10:05 ` Chun-Kuang Hu
2021-01-14 23:27 ` Chun-Kuang Hu
2021-01-07 3:11 ` [PATCH v9, 06/11] drm/mediatek: add RDMA fifo size error handle Yongqiang Niu
2021-01-07 3:11 ` [PATCH v9, 07/11] drm/mediatek: separate gamma module Yongqiang Niu
2021-01-07 10:25 ` Chun-Kuang Hu
2021-01-07 3:11 ` [PATCH v9, 08/11] drm/mediatek: add has_dither private data for gamma Yongqiang Niu
2021-01-07 10:29 ` Chun-Kuang Hu
2021-01-07 3:11 ` Yongqiang Niu [this message]
2021-01-07 3:11 ` [PATCH v9, 10/11] drm/mediatek: add DDP support for MT8183 Yongqiang Niu
2021-01-07 12:08 ` Chun-Kuang Hu
2021-01-07 3:11 ` [PATCH v9, 11/11] This patch add support for mediatek SOC MT8183 Yongqiang Niu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1609989081-29353-10-git-send-email-yongqiang.niu@mediatek.com \
--to=yongqiang.niu@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).