linux-mediatek.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: DTML <devicetree@vger.kernel.org>, Min Guo <min.guo@mediatek.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH next 04/15] dt-bindings: phy: mediatek: hdmi-phy: modify compatible items
Date: Tue, 19 Jan 2021 10:57:23 +0800	[thread overview]
Message-ID: <1611025043.11995.20.camel@mhfsdcap03> (raw)
In-Reply-To: <CAAOTY__DtGc85JNyxWcebof5h3_Os2ugyy1P0jZsOs0Yzj2miw@mail.gmail.com>

On Mon, 2021-01-18 at 23:05 +0800, Chun-Kuang Hu wrote:
> Hi, Chunfeng:
> 
> Chunfeng Yun <chunfeng.yun@mediatek.com> 於 2021年1月16日 週六 下午5:07寫道:
> >
> > The compatilbe "mediatek,mt7623-hdmi-tx" is not supported in driver,
> > and in fact uses "mediatek,mt2701-hdmi-tx" instead on MT7623, so changes
> > the compatible items to make dependence clear.
> >
> > Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> >  .../devicetree/bindings/phy/mediatek,hdmi-phy.yaml    | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml
> > index 4752517a1446..0d94950b84ca 100644
> > --- a/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml
> > @@ -21,10 +21,13 @@ properties:
> >      pattern: "^hdmi-phy@[0-9a-f]+$"
> >
> >    compatible:
> > -    enum:
> > -      - mediatek,mt2701-hdmi-phy
> > -      - mediatek,mt7623-hdmi-phy
> > -      - mediatek,mt8173-hdmi-phy
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - mediatek,mt7623-hdmi-phy
> > +          - const: mediatek,mt2701-hdmi-phy
> > +      - const: mediatek,mt2701-hdmi-phy
> > +      - const: mediatek,mt8173-hdmi-phy
> >
> 
> I like move 'items' to the bottom.
I follow the same style as other bindings

> 
> - const: mediatek,mt2701-hdmi-phy
> - const: mediatek,mt8173-hdmi-phy
> 
> - items:
>   - enum:
>       - mediatek,mt7623-hdmi-phy
>   - const: mediatek,mt2701-hdmi-phy
> 
> Regards,
> Chun-Kuang.
> 
> >    reg:
> >      maxItems: 1
> > --
> > 2.18.0

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  reply	other threads:[~2021-01-19  2:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-16  9:06 [PATCH next 01/15] dt-bindings: usb: fix yamllint check warning Chunfeng Yun
2021-01-16  9:06 ` [PATCH next 02/15] dt-bindings: usb: mediatek: " Chunfeng Yun
2021-01-16  9:06 ` [PATCH next 03/15] dt-bindings: phy: mediatek: dsi-phy: modify compatible dependence Chunfeng Yun
2021-01-18 14:56   ` Chun-Kuang Hu
2021-01-19  2:56     ` Chunfeng Yun
2021-01-16  9:06 ` [PATCH next 04/15] dt-bindings: phy: mediatek: hdmi-phy: modify compatible items Chunfeng Yun
2021-01-18 15:05   ` Chun-Kuang Hu
2021-01-19  2:57     ` Chunfeng Yun [this message]
2021-01-16  9:06 ` [PATCH next 05/15] dt-bindings: phy: mediatek: tphy: change patternProperties Chunfeng Yun
2021-01-16  9:06 ` [PATCH next 06/15] dt-bindings: usb: mtk-xhci: add support mt2701 and mt7623 Chunfeng Yun
2021-02-08 21:55   ` Rob Herring
2021-01-16  9:06 ` [PATCH next 07/15] dt-bindings: usb: mediatek: musb: add mt8516 compatbile Chunfeng Yun
2021-01-16  9:06 ` [PATCH next 08/15] arm64: dts: mediatek: mt8173: fix dtbs_check warning Chunfeng Yun
2021-01-16  9:06 ` [PATCH next 09/15] arm64: dts: mediatek: mt2712: harmonize node names Chunfeng Yun
2021-01-16  9:06 ` [PATCH next 10/15] arm64: dts: mediatek: mt8516: harmonize node names and compatibles Chunfeng Yun
2021-01-16  9:06 ` [PATCH next 11/15] arm64: dts: mediatek: mt7622: " Chunfeng Yun
2021-01-16  9:36   ` Sergei Shtylyov
2021-01-19  2:45     ` Chunfeng Yun
2021-01-16  9:06 ` [PATCH next 12/15] arm64: dts: mediatek: mt8183: fix dtbs_check warning Chunfeng Yun
2021-01-16  9:43   ` Sergei Shtylyov
2021-01-19  2:55     ` Chunfeng Yun
2021-01-17  1:58   ` Nicolas Boichat
2021-01-17  5:42     ` Nicolas Boichat
2021-01-16  9:06 ` [PATCH next 13/15] arm: dts: mt7629: harmonize node names and compatibles Chunfeng Yun
2021-01-16  9:06 ` [PATCH next 14/15] arm: dts: mt7623: " Chunfeng Yun
2021-01-16  9:06 ` [PATCH next 15/15] arm: dts: mt2701: " Chunfeng Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1611025043.11995.20.camel@mhfsdcap03 \
    --to=chunfeng.yun@mediatek.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=min.guo@mediatek.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).