From: Matthias Brugger <matthias.bgg@gmail.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-kernel@vger.kernel.org
Cc: chunkuang.hu@kernel.org, drinkcat@chromium.org,
linux-mediatek@lists.infradead.org, yongqiang.niu@mediatek.com,
hsinyi@chromium.org, Collabora Kernel ML <kernel@collabora.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] soc: mediatek: mmsys: Use devm_platform_ioremap_resource()
Date: Sat, 28 Nov 2020 00:35:33 +0100 [thread overview]
Message-ID: <188d0079-1fa8-8d43-97f1-33480ffc5c8e@gmail.com> (raw)
In-Reply-To: <20201006193320.405529-3-enric.balletbo@collabora.com>
On 06/10/2020 21:33, Enric Balletbo i Serra wrote:
> For the common platform_get_resource()+devm_platform_ioremap() combination,
> there is a helper, so use it and make the code a bit more compact.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Applied to v5.10-next/soc
Thanks!
> ---
>
> drivers/soc/mediatek/mtk-mmsys.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index 36ad66bb221b..18f93979e14a 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -306,15 +306,12 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
> struct platform_device *clks;
> struct platform_device *drm;
> void __iomem *config_regs;
> - struct resource *mem;
> int ret;
>
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - config_regs = devm_ioremap_resource(dev, mem);
> + config_regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(config_regs)) {
> ret = PTR_ERR(config_regs);
> - dev_err(dev, "Failed to ioremap mmsys-config resource: %d\n",
> - ret);
> + dev_err(dev, "Failed to ioremap mmsys registers: %d\n", ret);
> return ret;
> }
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-11-27 23:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 19:33 [PATCH 0/4] soc: mediatek: Prepare MMSYS for DDP routing using tables Enric Balletbo i Serra
2020-10-06 19:33 ` [PATCH 1/4] soc / drm: mediatek: Move DDP component defines into mtk-mmsys.h Enric Balletbo i Serra
2020-11-27 23:35 ` Matthias Brugger
2020-10-06 19:33 ` [PATCH 2/4] soc: mediatek: mmsys: Use devm_platform_ioremap_resource() Enric Balletbo i Serra
2020-10-06 23:21 ` Chun-Kuang Hu
2020-10-07 0:01 ` Chun-Kuang Hu
2020-11-27 23:35 ` Matthias Brugger [this message]
2020-10-06 19:33 ` [PATCH 3/4] soc: mediatek: mmsys: Create struct mtk_mmsys to store context data Enric Balletbo i Serra
2020-10-06 23:24 ` Chun-Kuang Hu
2020-10-07 0:00 ` Chun-Kuang Hu
2020-10-06 19:33 ` [PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the routing registers Enric Balletbo i Serra
2020-10-07 0:02 ` Chun-Kuang Hu
2020-10-08 0:01 ` Chun-Kuang Hu
2020-10-08 7:49 ` Enric Balletbo i Serra
2020-10-08 10:53 ` Matthias Brugger
2020-10-08 10:22 ` Matthias Brugger
2020-10-11 2:22 ` Chun-Kuang Hu
2020-10-15 13:32 ` Enric Balletbo i Serra
2020-11-04 10:43 ` [PATCH 0/4] soc: mediatek: Prepare MMSYS for DDP routing using tables Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=188d0079-1fa8-8d43-97f1-33480ffc5c8e@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=chunkuang.hu@kernel.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=hsinyi@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).