From: <frederic.chen@mediatek.com>
To: hans.verkuil@cisco.com,
laurent.pinchart+renesas@ideasonboard.com, tfiga@chromium.org,
matthias.bgg@gmail.com, mchehab@kernel.org
Cc: shik@chromium.org, devicetree@vger.kernel.org,
Sean.Cheng@mediatek.com, Rynn.Wu@mediatek.com,
Allan.Yang@mediatek.com, srv_heupstream@mediatek.com,
holmes.chiou@mediatek.com, suleiman@chromium.org,
Jerry-ch.Chen@mediatek.com, jungo.lin@mediatek.com,
sj.huang@mediatek.com, yuzhao@chromium.org,
linux-mediatek@lists.infradead.org, zwisler@chromium.org,
christie.yu@mediatek.com, frederic.chen@mediatek.com,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: [RFC PATCH V3 5/5] media: platform: mtk-mdp3: Add struct tuning_addr and img_sw_buffer
Date: Tue, 10 Sep 2019 03:22:44 +0800 [thread overview]
Message-ID: <20190909192244.9367-6-frederic.chen@mediatek.com> (raw)
In-Reply-To: <20190909192244.9367-1-frederic.chen@mediatek.com>
From: Frederic Chen <frederic.chen@mediatek.com>
We added a struct tuning_addr which contains a field "present"
so that the driver can tell the firmware if we have user tuning
dataor not.
The strcut img_sw_buffer is also added. This struct has no cpu address
field and uses a handle instead so that we don't pass a cpu address
to co-processor.
Signed-off-by: Frederic Chen <frederic.chen@mediatek.com>
---
drivers/media/platform/mtk-mdp3/mtk-img-ipi.h | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/mtk-mdp3/mtk-img-ipi.h b/drivers/media/platform/mtk-mdp3/mtk-img-ipi.h
index 9fabe7e8b71d..f61e61faf636 100644
--- a/drivers/media/platform/mtk-mdp3/mtk-img-ipi.h
+++ b/drivers/media/platform/mtk-mdp3/mtk-img-ipi.h
@@ -38,6 +38,12 @@ struct img_addr {
u32 iova; /* Used by IOMMU HW access */
} __attribute__ ((__packed__));
+struct tuning_addr {
+ u32 present;
+ u32 pa; /* Used by CM4 access */
+ u32 iova; /* Used by IOMMU HW access */
+} __attribute__ ((__packed__));
+
struct img_sw_addr {
u64 va; /* Used by APMCU access */
u32 pa; /* Used by CM4 access */
@@ -105,16 +111,21 @@ struct img_ipi_frameparam {
u64 drv_data;
struct img_input inputs[IMG_MAX_HW_INPUTS];
struct img_output outputs[IMG_MAX_HW_OUTPUTS];
- struct img_addr tuning_data;
+ struct tuning_addr tuning_data;
struct img_addr subfrm_data;
struct img_sw_addr config_data;
struct img_sw_addr self_data;
/* u8 pq_data[]; */
} __attribute__ ((__packed__));
+struct img_sw_buffer {
+ u64 handle; /* Used by APMCU access */
+ u32 scp_addr; /* Used by CM4 access */
+} __attribute__ ((__packed__));
+
struct img_ipi_param {
u8 usage;
- struct img_sw_addr frm_param;
+ struct img_sw_buffer frm_param;
} __attribute__ ((__packed__));
struct img_frameparam {
--
2.18.0
next prev parent reply other threads:[~2019-09-09 19:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 19:22 [RFC PATCH V3 0/5] media: platform: Add support for Digital Image Processing (DIP) on mt8183 SoC frederic.chen-NuS5LvNUpcJWk0Htik3J/w
2019-09-09 19:22 ` [RFC PATCH V3 1/5] dt-bindings: mt8183: Added DIP dt-bindings frederic.chen
2019-09-13 21:48 ` Rob Herring
2019-10-02 9:22 ` Sakari Ailus
2019-09-09 19:22 ` [RFC PATCH V3 2/5] dts: arm64: mt8183: Add DIP nodes frederic.chen
2019-09-09 19:22 ` [RFC PATCH V3 3/5] media: platform: Add Mediatek DIP driver KConfig frederic.chen
2019-10-02 9:20 ` Sakari Ailus
[not found] ` <20190909192244.9367-1-frederic.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-09-09 19:22 ` [RFC PATCH V3 4/5] platform: mtk-isp: Add Mediatek DIP driver frederic.chen-NuS5LvNUpcJWk0Htik3J/w
[not found] ` <20190909192244.9367-5-frederic.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-09-10 4:04 ` Tomasz Figa
2019-09-11 17:41 ` Frederic Chen
2019-09-12 5:58 ` Tomasz Figa
2019-09-19 9:41 ` Frederic Chen
2019-09-19 9:44 ` Tomasz Figa
2019-09-23 12:23 ` Sakari Ailus
2019-11-14 4:58 ` Pi-Hsun Shih
2019-09-09 19:22 ` frederic.chen [this message]
2019-10-02 9:21 ` [RFC PATCH V3 5/5] media: platform: mtk-mdp3: Add struct tuning_addr and img_sw_buffer Sakari Ailus
2019-09-23 12:11 ` [RFC PATCH V3 0/5] media: platform: Add support for Digital Image Processing (DIP) on mt8183 SoC Sakari Ailus
2023-08-19 5:43 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909192244.9367-6-frederic.chen@mediatek.com \
--to=frederic.chen@mediatek.com \
--cc=Allan.Yang@mediatek.com \
--cc=Jerry-ch.Chen@mediatek.com \
--cc=Rynn.Wu@mediatek.com \
--cc=Sean.Cheng@mediatek.com \
--cc=christie.yu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=holmes.chiou@mediatek.com \
--cc=jungo.lin@mediatek.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=shik@chromium.org \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=suleiman@chromium.org \
--cc=tfiga@chromium.org \
--cc=yuzhao@chromium.org \
--cc=zwisler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).