Linux-mediatek Archive on
 help / color / Atom feed
* [PATCH] mt76: fix possible undetected invalid MAC address
@ 2019-11-26 13:15 Shayne Chen
  0 siblings, 0 replies; only message in thread
From: Shayne Chen @ 2019-11-26 13:15 UTC (permalink / raw)
  To: Felix Fietkau
  Cc: Ryder Lee, linux-wireless, linux-mediatek, Roy Luo,
	Lorenzo Bianconi, Lorenzo Bianconi, Shayne Chen

Make sure the MAC address is checked before function returns.

If CONFIG_OF is set and the device node is null, the function will 
return directly, and an invalid MAC address will not be checked.

Signed-off-by: Shayne Chen <>
 drivers/net/wireless/mediatek/mt76/eeprom.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c
index 804224e81103..358fb0a1e523 100644
--- a/drivers/net/wireless/mediatek/mt76/eeprom.c
+++ b/drivers/net/wireless/mediatek/mt76/eeprom.c
@@ -80,13 +80,14 @@ mt76_eeprom_override(struct mt76_dev *dev)
 	const u8 *mac;
 	if (!np)
-		return;
+		goto out;
 	mac = of_get_mac_address(np);
 	if (!IS_ERR(mac))
 		ether_addr_copy(dev->macaddr, mac);
 	if (!is_valid_ether_addr(dev->macaddr)) {
Linux-mediatek mailing list

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26 13:15 [PATCH] mt76: fix possible undetected invalid MAC address Shayne Chen

Linux-mediatek Archive on

Archives are clonable:
	git clone --mirror linux-mediatek/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mediatek linux-mediatek/ \
	public-inbox-index linux-mediatek

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone