From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD2F3C432C0 for ; Tue, 3 Dec 2019 07:17:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F257206DF for ; Tue, 3 Dec 2019 07:17:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fltplFlU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="bPWhZrNr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F257206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SMPUEqH6UI+jVn7iJZNSim43Pvjz9KY6HsQSdQ2+Qcc=; b=fltplFlUEvl0dR CyTcacrmq4lR3aHhiDqLgHbj17YZajD4wkJqEVohbhfHR1UV2FLyXmjKQq73CUw59UuW0mici+B+l 9oIWnCFkzPCpox1su4Pwn+cungBMAcEGVpwtUKv6x+Zwbym4JV0TCWsqkqfqQl9lqwdxnu4jBXefU DGXPUs2l0Us/fwJfx9ODpgSIpCGeWm5kfHjOibM8Djs1RJhv11N4qEHbu8n8xP1p5k34ElO/jflPJ 9UElvpm/dJWsyX6VWUbO2vdnXZkcT1IH4L9t3/sgV4hQQtPdE2f/lnDizyqEASgk0s1MR1fvUgEb5 UJB8NKjKwRVID1Uj+oSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic2Qq-0001ET-W0; Tue, 03 Dec 2019 07:17:12 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic2Qj-00015t-3U; Tue, 03 Dec 2019 07:17:06 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 71191309; Tue, 3 Dec 2019 08:17:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575357423; bh=2sS2BNdYv6fX1ZVYfHwfsift774drFxDzzXfy61j3mo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bPWhZrNrgOWtYf8bWSO9OXFRAzb0KzASqB+zcaGgwB8egLfVpmjpHb99ocat/HVZ2 KXP6LctrJxUyHcBA8x+LtERl6X5lfcld+a+pF6yK2NbTsQYBNyZReQFnyJF+++NUfS WDvTL4PNlJKHLKW1i522QTbrUwCqyUerScR5JFEU= Date: Tue, 3 Dec 2019 09:16:56 +0200 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v1 25/26] drm/panel: tpo-td028ttec1: use drm_panel backlight support Message-ID: <20191203071656.GJ4730@pendragon.ideasonboard.com> References: <20191202193230.21310-1-sam@ravnborg.org> <20191202193230.21310-26-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191202193230.21310-26-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_231705_435138_B1A23A59 X-CRM114-Status: GOOD ( 14.69 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Benjamin Gaignard , Stefan Agner , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , Maarten Lankhorst , Maxime Ripard , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:29PM +0100, Sam Ravnborg wrote: > Use the backlight support in drm_panel to simplify the driver > > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Sam Ravnborg Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/panel/panel-tpo-td028ttec1.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c > index 37252590b541..cf29405a2dbe 100644 > --- a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c > +++ b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c > @@ -17,7 +17,6 @@ > * H. Nikolaus Schaller > */ > > -#include > #include > #include > #include > @@ -83,7 +82,6 @@ struct td028ttec1_panel { > struct drm_panel panel; > > struct spi_device *spi; > - struct backlight_device *backlight; > }; > > #define to_td028ttec1_device(p) container_of(p, struct td028ttec1_panel, panel) > @@ -243,8 +241,6 @@ static int td028ttec1_enable(struct drm_panel *panel) > if (ret) > return ret; > > - backlight_enable(lcd->backlight); > - > return 0; > } > > @@ -252,8 +248,6 @@ static int td028ttec1_disable(struct drm_panel *panel) > { > struct td028ttec1_panel *lcd = to_td028ttec1_device(panel); > > - backlight_disable(lcd->backlight); > - > jbt_ret_write_0(lcd, JBT_REG_DISPLAY_OFF, NULL); > > return 0; > @@ -334,10 +328,6 @@ static int td028ttec1_probe(struct spi_device *spi) > spi_set_drvdata(spi, lcd); > lcd->spi = spi; > > - lcd->backlight = devm_of_find_backlight(&spi->dev); > - if (IS_ERR(lcd->backlight)) > - return PTR_ERR(lcd->backlight); > - > spi->mode = SPI_MODE_3; > spi->bits_per_word = 9; > > @@ -350,6 +340,10 @@ static int td028ttec1_probe(struct spi_device *spi) > drm_panel_init(&lcd->panel, &lcd->spi->dev, &td028ttec1_funcs, > DRM_MODE_CONNECTOR_DPI); > > + ret = drm_panel_of_backlight(&lcd->panel); > + if (ret) > + return ret; > + > return drm_panel_add(&lcd->panel); > } > -- Regards, Laurent Pinchart _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek