From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2B45C2D0C3 for ; Sat, 21 Dec 2019 23:47:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71EB8206D3 for ; Sat, 21 Dec 2019 23:47:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AKQaShDR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K2F08+kb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71EB8206D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alum.mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t5S0CmNl42H0NU7up9bDZi1+NeVPSE5vRdMMh9qWi1k=; b=AKQaShDRXVUUiK YEIX1rj3CwyeHzaj8CUVsTgaT84ZaTeY/ZaOOhhuBpr81M4Zf1n+O8JYYvbBPuOYrZjxyiJow1v+N 1b20GqYduj2tiDAacxDv5PHtVSeiEfQSj50jlNiuZcsUaGUxnMTm7J1wjLP2PLmxyAUwTYgQn2AaN Jdl/VUwyCSDmqp1+Bs1SywDf/q+ok40MdYzBqgXmqs8loXue+7V/t3yTGDQePkwkh1kRgfusqeCyW DO58ysQAL2BqchVoAWIs5SIOr4+d5A4KFw2ohHo4kp30yfoEkqnfGCHnHEYwcHL5eEeIA9AHC0ZvU ZwHz621ryUFix1AplkhQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iioSU-0007YT-OJ; Sat, 21 Dec 2019 23:46:54 +0000 Received: from mail-qv1-xf42.google.com ([2607:f8b0:4864:20::f42]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iioSJ-0007QF-MZ; Sat, 21 Dec 2019 23:46:45 +0000 Received: by mail-qv1-xf42.google.com with SMTP id p2so5055134qvo.10; Sat, 21 Dec 2019 15:46:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DZy1sByRbPp81Fc4unsIfUDkM1speXohHbJEFLa+79Y=; b=K2F08+kbBOHpEb5GI2snEkwsgZNjaPXWMKDftdpnSDrNjdoFsaU7mJy1E8X+UN6pTF CqMGQGTCVzkASTJTbCKGzwmcE+xGW9X9DoBShnHYBHrUjwA2y0thgfSaIDeXsAsxh80K Lzsw/9ErY21ZUOic82HoE2snRWWJy1wLWDPwW7IWmh5yvrdgv4rUVX4xVE004OheL+PI /8AUmTvOKwGIU5Ku/sIm9m5U0rOim/SPjYy3gzVxef0QWGwTj1JJt9SDEH83TWoChVOq wLkEyhYrjgWcWjYym7iQAuL3qcxgGsX3JQNmgv7pU5p9IHVMooy6My1cg5SbonFnCmxX Fqwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:date:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=DZy1sByRbPp81Fc4unsIfUDkM1speXohHbJEFLa+79Y=; b=dLr7ME3IHq3n/fTPMPlxwr5ZtqXX/r5S4M4NCv6iVkjedBam9ZOEIrCZNn9bWuJ03u eOTAdeKUlqH5yW+Z0C+s1l0SCRYGzlrkc8/X3KTStOUvaIrVlVvOz930g4QbykzESOqG /+HRWZ1T/L8xQWAD3ehOwgme8CjZpSQ2yA40W8RXaFng27sroj18zOHm/EbT3iiUf5tA 7Tclu/X22H0v+ZiRKNW/eDec3zTeGzjhGHd25p6ZNKfy2tTXjCMvFZxOWWaSPzpVTSap MCouTOhGPNMA5zzatU74z8bFSRHNFUqoIc2TspWTPl0Gm7ssceo9G9HMrCZXhtVr1H2S JA6Q== X-Gm-Message-State: APjAAAUe6QPm3SW+4cPGW2Csf+QPUAR5ju4DP0Za1TxM1qPoTfj8+YUV z7+5wMNa1tysqeSV9cAIk8M= X-Google-Smtp-Source: APXvYqxZv5pvU+COa+Z57bqd7TVlj3AKMVnWrlNSwtaonBLRwl6oAVA7CbZzWjXYXul1zP2Wc7+ZAQ== X-Received: by 2002:a05:6214:14b3:: with SMTP id bo19mr18216129qvb.93.1576972000657; Sat, 21 Dec 2019 15:46:40 -0800 (PST) Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id b7sm4323472qkh.106.2019.12.21.15.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Dec 2019 15:46:40 -0800 (PST) From: Arvind Sankar X-Google-Original-From: Arvind Sankar Date: Sat, 21 Dec 2019 18:46:37 -0500 To: Tom Murphy Subject: Re: [PATCH 1/8] iommu/vt-d: clean up 32bit si_domain assignment Message-ID: <20191221234635.GA99623@rani.riverdale.lan> References: <20191221150402.13868-1-murphyt7@tcd.ie> <20191221150402.13868-2-murphyt7@tcd.ie> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191221150402.13868-2-murphyt7@tcd.ie> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191221_154643_763109_2D4BEAF4 X-CRM114-Status: GOOD ( 19.38 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , kvm@vger.kernel.org, David Airlie , Joonas Lahtinen , dri-devel@lists.freedesktop.org, Bjorn Andersson , linux-tegra@vger.kernel.org, Julien Grall , Thierry Reding , Will Deacon , Marek Szyprowski , Jean-Philippe Brucker , linux-samsung-soc@vger.kernel.org, Marc Zyngier , Joerg Roedel , iommu@lists.linux-foundation.org, Krzysztof Kozlowski , Jonathan Hunter , linux-rockchip@lists.infradead.org, Andy Gross , linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Jani Nikula , Eric Auger , Alex Williamson , linux-mediatek@lists.infradead.org, Rodrigo Vivi , Matthias Brugger , Thomas Gleixner , virtualization@lists.linux-foundation.org, Gerald Schaefer , David Woodhouse , Cornelia Huck , linux-kernel@vger.kernel.org, Rob Clark , Kukjin Kim , Daniel Vetter , Robin Murphy , Lu Baolu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sat, Dec 21, 2019 at 03:03:53PM +0000, Tom Murphy wrote: > In the intel iommu driver devices which only support 32bit DMA can't be > direct mapped. The implementation of this is weird. Currently we assign > it a direct mapped domain and then remove the domain later and replace > it with a domain of type IOMMU_DOMAIN_IDENTITY. We should just assign it > a domain of type IOMMU_DOMAIN_IDENTITY from the begging rather than > needlessly swapping domains. > > Signed-off-by: Tom Murphy > --- > drivers/iommu/intel-iommu.c | 88 +++++++++++++------------------------ > 1 file changed, 31 insertions(+), 57 deletions(-) > > diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c > index 0c8d81f56a30..c1ea66467918 100644 > --- a/drivers/iommu/intel-iommu.c > +++ b/drivers/iommu/intel-iommu.c > @@ -5640,7 +5609,12 @@ static int intel_iommu_add_device(struct device *dev) > domain = iommu_get_domain_for_dev(dev); > dmar_domain = to_dmar_domain(domain); > if (domain->type == IOMMU_DOMAIN_DMA) { > - if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY) { > + /* > + * We check dma_mask >= dma_get_required_mask(dev) because > + * 32 bit DMA falls back to non-identity mapping. > + */ > + if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY && > + dma_mask >= dma_get_required_mask(dev)) { > ret = iommu_request_dm_for_dev(dev); > if (ret) { > dmar_remove_one_dev_info(dev); > -- > 2.20.1 > Should this be dma_direct_get_required_mask? dma_get_required_mask may return DMA_BIT_MASK(32) -- it callbacks into intel_get_required_mask, but I'm not sure what iommu_no_mapping(dev) will do at this point? _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek