From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71C3EC2BA19 for ; Mon, 6 Apr 2020 13:04:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4206E22273 for ; Mon, 6 Apr 2020 13:04:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IvvgsXuN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4206E22273 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OgQBZnGxjcZmPqC+22ZAeaDecnPlAVkVqa8doEWHOnk=; b=IvvgsXuNUJ6XpN 2L8CqLgiky3bQ9Ryrq7sPOIJCDTpYqu9apBPePtbExud58iFf+bC2JjtlVxzYu0eJYwTsNqxW0AV9 tereSKBn+g1KNy6VW+iRH9z9nbtdbGLYoXX+lDB/92lrzUI91QhfOr+hQYDA8Fnf3leJ/vTB21JmO abSSI01j4G1GC2P8/G4DQ2jGWZkmXUGGeMX8w/bmzeoOgmwdDuu3nY9irrg9oeL/S5hPVCar43A1w trEJHV9srXc2iDmduI4NDSUo30whNl8u2cq/20CvTw6MLJtqcmbGNTtL43GfaOQj4MHvZ/1XubdlT ljFcjnurJCP/Zq6DsMmw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLRQ7-0005fM-6l; Mon, 06 Apr 2020 13:04:07 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLRQ4-0005f0-NT for linux-mediatek@lists.infradead.org; Mon, 06 Apr 2020 13:04:05 +0000 IronPort-SDR: O4EBP1mjoP2WAqfZycYgZMvxc/wPkDmhvr7tanVYsJ8gYk5WUB/hCp30GevbDEkBkduipo7vqM xo6WgyhK5cGA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2020 06:04:03 -0700 IronPort-SDR: M1yeWc4dK0ciV2kr3dpLZnL49hrexu8/JdeW3lQVODOoJAXpSHu0mzrDSeCBWFBGHIqkApSY9t jtVqmRz9IVjQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,351,1580803200"; d="scan'208";a="424350736" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga005.jf.intel.com with ESMTP; 06 Apr 2020 06:03:59 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jLRQ1-00GBQE-Vd; Mon, 06 Apr 2020 16:04:01 +0300 Date: Mon, 6 Apr 2020 16:04:01 +0300 From: Andy Shevchenko To: Fengping yu Subject: Re: [PATCH v3] Add support for MediaTek keypad Message-ID: <20200406130401.GV3676135@smile.fi.intel.com> References: <20200405020114.14787-1-fengping.yu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200405020114.14787-1-fengping.yu@mediatek.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200406_060404_832134_164D7E4D X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yingjoe Chen , Dmitry Torokhov , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, wsd_upstream@mediatek.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sun, Apr 05, 2020 at 10:01:13AM +0800, Fengping yu wrote: > > This patchset add support to MediaTek matrix keypad. Seems it has not addressed comments I gave. > > Change since V2: > - remove extra space and redundant lines > - update keypad devicetree document debounce time unit > - change to use devm_platform_ioremap_resource() to simplify resource management > - use bitmap to store and check keypad state > > fengping.yu (2): > add dt-binding document for MediaTek Keypad > add MediaTek keypad driver > > .../devicetree/bindings/input/mtk-kpd.txt | 61 +++++ > arch/arm64/configs/defconfig | 1 + > drivers/input/keyboard/Kconfig | 7 + > drivers/input/keyboard/Makefile | 1 + > drivers/input/keyboard/mtk-kpd.c | 258 ++++++++++++++++++ > 5 files changed, 328 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.txt > create mode 100644 drivers/input/keyboard/mtk-kpd.c > > -- > 2.18.0 > -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek