From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40575C38A2A for ; Thu, 7 May 2020 11:13:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1538D208E4 for ; Thu, 7 May 2020 11:13:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h++uec8C"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="U0ZIgjbx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1538D208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XKOVFq2Of9/Kf7rKyVuGupcRcql1Fpi/YiSTdkZobRU=; b=h++uec8C4kDWRU q1lzfBCjWkr54uecxBA2W5DT63jFFjlcF9PVNBJW0yYq/6dXTQHzEYrGqxM1quTmAkciso/MJtxzz dfCvu1AoWL+vbpkj1bL4q9LWONPzZ53EgDvKIUkQIPkwMGaZrzQmZnWwK21xFUKx8lRDI5hHhFfbf 7eIqsrme7W0xx4z4W6glRQJiN/30OMENQxWubEQO7ZRp0nrR6cOs3SPdB+la2cJNzfzZyBU4oJitr y20GzgDaHWxJqPJfdaaI9NHo4oPLkafNwNv+qfiVOlogNxFao3zxD7x1SDk01L/8k3EbqB0Je1zI3 9jE+ePSNGjtpPAxEgrxg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWeSs-0006TF-BC; Thu, 07 May 2020 11:13:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWeSp-0006Sd-9Z for linux-mediatek@lists.infradead.org; Thu, 07 May 2020 11:13:16 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CF74E208E4; Thu, 7 May 2020 11:13:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588849994; bh=JpJwu3HzMRZiNarifyoKzt5DSF15LyA9t4q0RBYx/+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U0ZIgjbxbrUQp22xHRVXhrRyXYovhO9OcSbJLRCt06RzSv/mH0Mi/xwKnQhuqUAE5 bq6FwoI59EsiNC3tKiUsGN+5q7sqMFLPCdtlFoH6z0/XtKE9yLiprcbT//sCoJDkbK emJbjo8/AvGo/ULzVUqsZa9FJLI8MDche1ilHUnM= Date: Thu, 7 May 2020 13:13:12 +0200 From: Greg Kroah-Hartman To: Johan Hovold Subject: Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks Message-ID: <20200507111312.GA1497799@kroah.com> References: <1480357509-28074-1-git-send-email-johan@kernel.org> <1480357509-28074-12-git-send-email-johan@kernel.org> <20200507064412.GL2042@localhost> <20200507064734.GA798308@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200507064734.GA798308@kroah.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_041315_370593_943ABAA2 X-CRM114-Status: GOOD ( 18.69 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkft-triage@lists.linaro.org, Pantelis Antoniou , Frank Rowand , Sasha Levin , Felix Fietkau , Florian Fainelli , Naresh Kamboju , Claudiu Manoil , Li Yang , Mugunthan V N , Grygorii Strashko , linuxppc-dev@lists.ozlabs.org, Rob Herring , linux-mediatek@lists.infradead.org, Lars Persson , Matthias Brugger , linux-omap@vger.kernel.org, John Crispin , Thomas Petazzoni , Fugang Duan , Sergei Shtylyov , Vivien Didelot , Netdev , open list , linux- stable , linux-renesas-soc@vger.kernel.org, Vitaly Bordug , nios2-dev@lists.rocketboards.org, Vince Bridgers , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, May 07, 2020 at 08:47:34AM +0200, Greg Kroah-Hartman wrote: > On Thu, May 07, 2020 at 08:44:12AM +0200, Johan Hovold wrote: > > On Thu, May 07, 2020 at 12:27:53AM +0530, Naresh Kamboju wrote: > > > On Tue, 29 Nov 2016 at 00:00, Johan Hovold wrote: > > > > > > > > Make sure to deregister and free any fixed-link PHY registered using > > > > of_phy_register_fixed_link() on probe errors and on driver unbind. > > > > > > > > Fixes: 83895bedeee6 ("net: mvneta: add support for fixed links") > > > > Signed-off-by: Johan Hovold > > > > --- > > > > drivers/net/ethernet/marvell/mvneta.c | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > > > > index 0c0a45af950f..707bc4680b9b 100644 > > > > --- a/drivers/net/ethernet/marvell/mvneta.c > > > > +++ b/drivers/net/ethernet/marvell/mvneta.c > > > > @@ -4191,6 +4191,8 @@ static int mvneta_probe(struct platform_device *pdev) > > > > clk_disable_unprepare(pp->clk); > > > > err_put_phy_node: > > > > of_node_put(phy_node); > > > > + if (of_phy_is_fixed_link(dn)) > > > > + of_phy_deregister_fixed_link(dn); > > > > > > While building kernel Image for arm architecture on stable-rc 4.4 branch > > > the following build error found. > > > > > > drivers/net/ethernet/marvell/mvneta.c:3442:3: error: implicit > > > declaration of function 'of_phy_deregister_fixed_link'; did you mean > > > 'of_phy_register_fixed_link'? [-Werror=implicit-function-declaration] > > > | of_phy_deregister_fixed_link(dn); > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > | of_phy_register_fixed_link > > > > > > ref: > > > https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/541374729 > > > > Greg, 3f65047c853a ("of_mdio: add helper to deregister fixed-link > > PHYs") needs to be backported as well for these. > > > > Original series can be found here: > > > > https://lkml.kernel.org/r/1480357509-28074-1-git-send-email-johan@kernel.org > > Ah, thanks for that, I thought I dropped all of the ones that caused > build errors, but missed the above one. I'll go take the whole series > instead. This should now all be fixed up, thanks. greg k-h _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek