linux-mediatek.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org,
	Yingjoe Chen <yingjoe.chen@mediatek.com>,
	Fengping Yu <fengping.yu@mediatek.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH v11 2/3] drivers: input: keyboard: Add mtk keypad driver
Date: Thu, 28 May 2020 13:45:58 +0200	[thread overview]
Message-ID: <20200528114558.5decxsun2o65k2fr@pengutronix.de> (raw)
In-Reply-To: <20200528102730.GK1634618@smile.fi.intel.com>

Hi Andy,

On 20-05-28 13:27, Andy Shevchenko wrote:
> On Thu, May 28, 2020 at 05:01:47PM +0800, Fengping Yu wrote:
> > From: "fengping.yu" <fengping.yu@mediatek.com>
> > 
> > This adds matrix keypad support for Mediatek SoCs.
> 
> ...
> 
> > +config KEYBOARD_MTK_KPD
> > +	tristate "MediaTek Keypad Support"
> > +	depends on ARCH_MEDIATEK || COMPILE_TEST
> 
> > +	select CONFIG_REGMAP_MMIO
> 
> This is wrong.

Why is this wrong? The driver uses the rmap-mmio functions.

Thanks for the explanation =)
  Marco

> 
> > +	select INPUT_MATRIXKMAP
> 
> ...
> 
> > +	ret = devm_add_action_or_reset(&pdev->dev, kpd_clk_disable,
> > +				       keypad->clk);
> 
> I would leave on one line (only 81 characters).
> 
> > +	if (ret)
> > +		return ret;
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  reply	other threads:[~2020-05-28 11:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28  9:01 [RESEND PATCH v11] Add matrix keypad driver support for Mediatek SoCs Fengping Yu
2020-05-28  9:01 ` [RESEND PATCH v11 1/3] dt-bindings: Add keypad devicetree documentation Fengping Yu
2020-05-28  9:01 ` [RESEND PATCH v11 2/3] drivers: input: keyboard: Add mtk keypad driver Fengping Yu
2020-05-28 10:27   ` Andy Shevchenko
2020-05-28 11:45     ` Marco Felsch [this message]
2020-05-28 12:22       ` Andy Shevchenko
2020-05-28 12:33         ` Marco Felsch
2020-05-28  9:01 ` [RESEND PATCH v11 3/3] configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=m Fengping Yu
2020-05-28 10:24 ` [RESEND PATCH v11] Add matrix keypad driver support for Mediatek SoCs Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200528114558.5decxsun2o65k2fr@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=fengping.yu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).