From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] usb: mtu3: disable USB2 LPM
Date: Mon, 29 Jun 2020 10:10:47 +0200 [thread overview]
Message-ID: <20200629081047.GB1221843@kroah.com> (raw)
In-Reply-To: <af16d716-8bb3-ea1f-e410-b27443f74c31@web.de>
On Mon, Jun 29, 2020 at 09:30:58AM +0200, Markus Elfring wrote:
> > A SuperSpeed device shall include the USB 2.0 extension descriptor
> > and shall support LPM when operating in USB 2.0 HS mode(see usb3.2
> > spec9.6.2.1). But we always don't support it, so disable it by
> > default, otherwise device will enter LPM suspend mode when
> > connected to Win10 system.
>
> How do you think about a wording variant like the following?
>
> Change description:
> A SuperSpeed device shall include the USB 2.0 extension descriptor
> and shall support Link Power Management when operating in USB 2.0
> High Speed mode. (See also: USB 3.2 specification 9.6.2.1)
> But we do not support it generally. Thus disable this functionality
> by default.
> Otherwise, the device will enter LPM suspend mode when connected
> to Win10 system.
>
>
> Would you like to add the tag “Fixes” to the commit message?
>
> Regards,
> Markus
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-06-29 8:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 6:00 [PATCH 1/2] usb: mtu3: disable USB2 LPM Chunfeng Yun
2020-06-29 6:00 ` [PATCH 2/2] usb: mtu3: fix NULL pointer dereference Chunfeng Yun
2020-06-29 8:00 ` Markus Elfring
2020-06-29 8:10 ` Greg Kroah-Hartman
2020-06-30 7:28 ` Chunfeng Yun
2020-06-29 16:19 ` Searching for initialisation of variables by function calls before null pointer checks Markus Elfring
2020-06-29 7:30 ` [PATCH 1/2] usb: mtu3: disable USB2 LPM Markus Elfring
2020-06-29 8:10 ` Greg Kroah-Hartman [this message]
2020-06-29 7:37 ` Peter Chen
2020-06-30 7:03 ` Chunfeng Yun
2020-06-29 8:15 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629081047.GB1221843@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Markus.Elfring@web.de \
--cc=chunfeng.yun@mediatek.com \
--cc=felipe.balbi@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).