From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Dongchun Zhu <dongchun.zhu@mediatek.com>
Cc: mark.rutland@arm.com, drinkcat@chromium.org,
andriy.shevchenko@linux.intel.com, srv_heupstream@mediatek.com,
devicetree@vger.kernel.org, shengnan.wang@mediatek.com,
tfiga@chromium.org, louis.kuo@mediatek.com,
sj.huang@mediatek.com, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
bingbu.cao@intel.com, mchehab@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v15 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings
Date: Wed, 14 Oct 2020 11:31:39 +0300 [thread overview]
Message-ID: <20201014083139.GG13341@paasikivi.fi.intel.com> (raw)
In-Reply-To: <1602641418.4733.80.camel@mhfsdcap03>
On Wed, Oct 14, 2020 at 10:10:18AM +0800, Dongchun Zhu wrote:
> Hello Sakari,
>
> Thanks for your timely review.
>
> On Tue, 2020-10-13 at 19:19 +0300, Sakari Ailus wrote:
> > Hi Dongchun,
> >
> > On Tue, Oct 13, 2020 at 09:05:02PM +0800, Dongchun Zhu wrote:
> > > Add YAML device tree binding for OV02A10 CMOS image sensor, and the
> > > relevant MAINTAINERS entries.
> > >
> > > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> > > ---
> > > .../bindings/media/i2c/ovti,ov02a10.yaml | 162 +++++++++++++++++++++
> > > MAINTAINERS | 7 +
> > > 2 files changed, 169 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml
> > >
>
> [snip]...
>
> > > + ovti,mipi-clock-voltage:
> > > + description:
> > > + An array of 2-tuples items, and each item consists of link frequency and
> > > + MIPI clock voltage unit like <freq-kHz volt-unit>. Clock voltage unit is
> > > + dependent upon link speed, indicating MIPI transmission speed select that
> > > + controls D-PHY timing setting by adjusting MIPI clock voltage to improve
> > > + the clock driver capability.
> > > + $ref: "/schemas/types.yaml#/definitions/uint32-array"
> > > + minItems: 2
> > > + default: [390000, 4]
> >
> > Why do you have the link frequency here as well?
> >
> > In principle this does belong to the endpoint as link frequencies are
> > specific to that, but I don't mind; there's just a single port anyway.
> >
>
> This is an optional property which we model as an array of <link speed,
> clock voltage> pairs. An example to have all link speeds up to 390MHz
> use the value 4 for current driver. If one wants to select different
> voltage for different link, they could do so as well.
If you think you'd need that, then you need to put this to the endpoint.
--
Sakari Ailus
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-10-14 8:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 13:05 [PATCH v15 0/2] media: i2c: Add support for OV02A10 sensor Dongchun Zhu
2020-10-13 13:05 ` [PATCH v15 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings Dongchun Zhu
2020-10-13 16:19 ` Sakari Ailus
2020-10-14 2:10 ` Dongchun Zhu
2020-10-14 8:31 ` Sakari Ailus [this message]
2020-10-14 11:48 ` Tomasz Figa
2020-10-16 17:21 ` Rob Herring
2020-10-19 8:27 ` Sakari Ailus
2020-10-19 19:20 ` Tomasz Figa
2020-10-26 22:25 ` Tomasz Figa
2020-10-30 16:27 ` Sakari Ailus
2020-11-19 12:58 ` Dongchun Zhu
2020-10-16 17:21 ` Rob Herring
2020-10-13 13:05 ` [PATCH v15 2/2] media: i2c: Add OV02A10 image sensor driver Dongchun Zhu
2020-10-23 14:31 ` Andy Shevchenko
2020-11-19 13:06 ` Dongchun Zhu
2020-11-19 13:57 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014083139.GG13341@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dongchun.zhu@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=shengnan.wang@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).