From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: Gene Chen <gene_chen@richtek.com>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
sre@kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: power: Add bindings document for Charger support on MT6360 PMIC
Date: Fri, 16 Oct 2020 17:38:23 +0200 [thread overview]
Message-ID: <20201016153823.GA9890@kozik-lap> (raw)
In-Reply-To: <1600859910-15855-1-git-send-email-gene.chen.richtek@gmail.com>
On Wed, Sep 23, 2020 at 07:18:29PM +0800, Gene Chen wrote:
> From: Gene Chen <gene_chen@richtek.com>
>
> Add bindings document for Charger support on MT6360 PMIC
>
> Signed-off-by: Gene Chen <gene_chen@richtek.com>
> ---
> .../bindings/power/supply/mt6360_charger.yaml | 44 ++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml b/Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml
> new file mode 100644
> index 0000000..711fc19
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/mt6360_charger.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Battery charger driver for MT6360 PMIC from MediaTek Integrated.
> +
> +maintainers:
> + - Gene Chen <gene_chen@richtek.com>
> +
> +description: |
> + This module is part of the MT6360 MFD device.
> + Provides Battery Charger, Boost for OTG devices and BC1.2 detection.
> +
> +properties:
> + compatible:
> + const: mediatek,mt6360-chg
> +
> + vinovp:
> + description:
> + Maximum CHGIN regulation voltage.
1. You need to describe the type.
2. Use proper unit suffix (see property-units.txt).
3. Is this a custom property? If yes, it misses vendor prefix. If not,
most likely there is already such property. Reuse.
> +
> + usb-otg-vbus:
> + $ref: /schemas/regulator/regulator.yaml#
1. Wrong indentation.
2. Name should be more or less generic, so maybe
"usb-otg-vbus-regulator".
> +
> +required:
> + - compatible
No address/reg? How does it bind?
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + mt6360_chg: chg {
s/chg/charger/
> + compatible = "mediatek,mt6360-chg";
> + vinovp = <14500000>;
Empty line break
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-10-16 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 11:18 [PATCH 1/2] dt-bindings: power: Add bindings document for Charger support on MT6360 PMIC Gene Chen
2020-09-23 11:18 ` [PATCH 2/2] power: supply: mt6360_charger: add MT6360 charger support Gene Chen
2020-10-14 2:34 ` Gene Chen
2020-10-16 15:52 ` Krzysztof Kozlowski
2020-10-26 6:45 ` Gene Chen
2020-10-27 20:13 ` Krzysztof Kozlowski
2020-10-16 15:38 ` Krzysztof Kozlowski [this message]
2020-10-20 9:03 ` [PATCH 1/2] dt-bindings: power: Add bindings document for Charger support on MT6360 PMIC Gene Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016153823.GA9890@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).