From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AD52C55178 for ; Fri, 30 Oct 2020 17:09:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0E1C20731 for ; Fri, 30 Oct 2020 17:09:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nbzYmhuY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0E1C20731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MGP/wvncouHrOrF1G7kmUPVssBtIFqRnlAFf9m2aidg=; b=nbzYmhuYgXJKmsgnGwc2Omk3t 3rQIDJt9/w0BiGwLZ1xnwaPVb904/3sJLEo6V0ooD+77F2vC79E1tCszZRPAJwQqQEEH2/0nEB6rk 1tYPENJOnjdeT2j+61+RwDyHkeTWi3T1SjhIQpMiPKEN+S+AePbacEA3Nk7bcFo7Ha82Y3AMhd8wC 8kGabLVRdBtS8w9EoiDmXvlRa7UtDjPEDxh2TOi+GBO6E5N3Hyd5lfj/H6hSydWSEDEnIvIofItvF v4Diq2lrPfFSc0oS/EG5dfY/S31CswG4ppDjSzlSw70Vxc9HQ384uQPU8C699dHADoEptNl8b681P KFQ6U88lA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYXu8-0002K7-1E; Fri, 30 Oct 2020 17:09:32 +0000 Received: from mga11.intel.com ([192.55.52.93]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYXu1-0002Gx-MZ; Fri, 30 Oct 2020 17:09:27 +0000 IronPort-SDR: xVXodWRkv+QDakZ7VbulZSrb13gQ7BrNGNdiShca+jp8ego0UUURgqNauBhOPLEy3BF/6sc2r/ Ro1OJpiciSjA== X-IronPort-AV: E=McAfee;i="6000,8403,9790"; a="165139496" X-IronPort-AV: E=Sophos;i="5.77,434,1596524400"; d="scan'208";a="165139496" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 10:09:21 -0700 IronPort-SDR: ws0AqHa+sfBSJMWZTmlC/P4vwPmOIJTN6GqcPVJPQA6N2F3meXhAevZDbLaMQoghfLO+k1rVnM PGExSGNFJgsw== X-IronPort-AV: E=Sophos;i="5.77,434,1596524400"; d="scan'208";a="469582751" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 10:09:17 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 2F86C20AA6; Fri, 30 Oct 2020 18:27:56 +0200 (EET) Date: Fri, 30 Oct 2020 18:27:56 +0200 From: Sakari Ailus To: Tomasz Figa Subject: Re: [PATCH v15 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings Message-ID: <20201030162756.GR26150@paasikivi.fi.intel.com> References: <20201013130503.2412-1-dongchun.zhu@mediatek.com> <20201013130503.2412-2-dongchun.zhu@mediatek.com> <20201013161938.GE13341@paasikivi.fi.intel.com> <1602641418.4733.80.camel@mhfsdcap03> <20201014083139.GG13341@paasikivi.fi.intel.com> <20201019082759.GL13341@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201030_130925_892235_A63F28C9 X-CRM114-Status: GOOD ( 47.47 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Andy Shevchenko , srv_heupstream , linux-devicetree , Shengnan Wang =?utf-8?B?KOeOi+Wco+eUtyk=?= , Louis Kuo , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Dongchun Zhu , Matthias Brugger , Cao Bing Bu , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Tomasz, Dongchun, On Mon, Oct 19, 2020 at 09:20:15PM +0200, Tomasz Figa wrote: > On Mon, Oct 19, 2020 at 10:28 AM Sakari Ailus > wrote: > > > > On Wed, Oct 14, 2020 at 01:48:00PM +0200, Tomasz Figa wrote: > > > On Wed, Oct 14, 2020 at 10:31 AM Sakari Ailus > > > wrote: > > > > > > > > On Wed, Oct 14, 2020 at 10:10:18AM +0800, Dongchun Zhu wrote: > > > > > Hello Sakari, > > > > > > > > > > Thanks for your timely review. > > > > > > > > > > On Tue, 2020-10-13 at 19:19 +0300, Sakari Ailus wrote: > > > > > > Hi Dongchun, > > > > > > > > > > > > On Tue, Oct 13, 2020 at 09:05:02PM +0800, Dongchun Zhu wrote: > > > > > > > Add YAML device tree binding for OV02A10 CMOS image sensor, and the > > > > > > > relevant MAINTAINERS entries. > > > > > > > > > > > > > > Signed-off-by: Dongchun Zhu > > > > > > > --- > > > > > > > .../bindings/media/i2c/ovti,ov02a10.yaml | 162 +++++++++++++++++++++ > > > > > > > MAINTAINERS | 7 + > > > > > > > 2 files changed, 169 insertions(+) > > > > > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > > > > > > > > > > > > [snip]... > > > > > > > > > > > > + ovti,mipi-clock-voltage: > > > > > > > + description: > > > > > > > + An array of 2-tuples items, and each item consists of link frequency and > > > > > > > + MIPI clock voltage unit like . Clock voltage unit is > > > > > > > + dependent upon link speed, indicating MIPI transmission speed select that > > > > > > > + controls D-PHY timing setting by adjusting MIPI clock voltage to improve > > > > > > > + the clock driver capability. > > > > > > > + $ref: "/schemas/types.yaml#/definitions/uint32-array" > > > > > > > + minItems: 2 > > > > > > > + default: [390000, 4] > > > > > > > > > > > > Why do you have the link frequency here as well? > > > > > > > > > > > > In principle this does belong to the endpoint as link frequencies are > > > > > > specific to that, but I don't mind; there's just a single port anyway. > > > > > > > > > > > > > > > > This is an optional property which we model as an array of > > > > clock voltage> pairs. An example to have all link speeds up to 390MHz > > > > > use the value 4 for current driver. If one wants to select different > > > > > voltage for different link, they could do so as well. > > > > > > > > If you think you'd need that, then you need to put this to the endpoint. > > > > > > The mipi-clock-voltage property is not a property of the endpoint. The > > > link frequency there does not set the link frequency - it only > > > specifies which link frequency the given voltage should be used for. > > > > If it is not bound to the endpoint --- that specifies the properties of the > > link --- then you could just put it to the driver, couldn't you? > > > > But earlier on, we established that this is specific to a given board, or a > > given link. Endpoints are used to describe connections that a device may > > have to other devices. Therefore their properties are different. > > > > The graph bindings allow for several endpoints on a single physical port, > > some may be disabled in that case. This is admittedly mostly done with > > CSI-2 receivers. > > > > Either way, putting this property to the device may affect how DT source is > > arranged for boards that have this device. Any similar configuration on > > other devices with multiple transmitters or receivers would be in endpoints > > anyway --- because they have to, so I don't see why bindings for this > > device should be different. > > > > If you put it to endpoint, the driver also doesn't need to match the link > > frequencies in kHz and Hz between the two properties, but just use the same > > index for both. > > I agree in general, but I think in this case this is a device-specific > property and the sensor only has 1 CSI-2 interface, so maybe it > doesn't really matter? > > Specifying frequency, voltage pairs is a common practice in other > bindings, such as the OPP bindings, by the way. > > That said, if you insist, I'm fine with this being moved to the > endpoint node too. Please, unless there are sound technical reasons to do otherwise. -- Sakari Ailus _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek