From: John Allen <john.allen@amd.com>
To: Allen Pais <allen.lkml@gmail.com>
Cc: giovanni.cabiddu@intel.com, alexandre.belloni@bootlin.com,
aymen.sghaier@nxp.com, heiko@sntech.de, qat-linux@intel.com,
jamie@jamieiles.com, jesper.nilsson@axis.com,
linux-samsung-soc@vger.kernel.org, herbert@gondor.apana.org.au,
horia.geanta@nxp.com, k.konieczny@samsung.com,
schalla@marvell.com, krzk@kernel.org,
linux-rockchip@lists.infradead.org,
ludovic.desroches@microchip.com, thomas.lendacky@amd.com,
arno@natisbad.org, vz@mleia.com, gilad@benyossef.com,
gcherian@marvell.com, linux-mediatek@lists.infradead.org,
lars.persson@axis.com, matthias.bgg@gmail.com,
Allen Pais <apais@linux.microsoft.com>,
bbrezillon@kernel.org, nicolas.ferre@microchip.com,
linux-crypto@vger.kernel.org,
Romain Perier <romain.perier@gmail.com>,
davem@davemloft.net
Subject: Re: [PATCH v3 06/19] crypto: ccp: convert tasklets to use new tasklet_setup() API
Date: Wed, 13 Jan 2021 10:17:34 -0600 [thread overview]
Message-ID: <20210113161734.GA31464@theseus> (raw)
In-Reply-To: <20210112014650.10887-7-allen.lkml@gmail.com>
On Tue, Jan 12, 2021 at 07:16:37AM +0530, Allen Pais wrote:
> From: Allen Pais <apais@linux.microsoft.com>
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> Signed-off-by: Allen Pais <apais@linux.microsoft.com>
Acked-by: John Allen <john.allen@amd.com>
> ---
> drivers/crypto/ccp/ccp-dev-v3.c | 9 ++++-----
> drivers/crypto/ccp/ccp-dev-v5.c | 9 ++++-----
> drivers/crypto/ccp/ccp-dmaengine.c | 7 +++----
> 3 files changed, 11 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp-dev-v3.c b/drivers/crypto/ccp/ccp-dev-v3.c
> index 0d5576f6ad21..858566867fa3 100644
> --- a/drivers/crypto/ccp/ccp-dev-v3.c
> +++ b/drivers/crypto/ccp/ccp-dev-v3.c
> @@ -321,9 +321,9 @@ static void ccp_enable_queue_interrupts(struct ccp_device *ccp)
> iowrite32(ccp->qim, ccp->io_regs + IRQ_MASK_REG);
> }
>
> -static void ccp_irq_bh(unsigned long data)
> +static void ccp_irq_bh(struct tasklet_struct *t)
> {
> - struct ccp_device *ccp = (struct ccp_device *)data;
> + struct ccp_device *ccp = from_tasklet(ccp, t, irq_tasklet);
> struct ccp_cmd_queue *cmd_q;
> u32 q_int, status;
> unsigned int i;
> @@ -361,7 +361,7 @@ static irqreturn_t ccp_irq_handler(int irq, void *data)
> if (ccp->use_tasklet)
> tasklet_schedule(&ccp->irq_tasklet);
> else
> - ccp_irq_bh((unsigned long)ccp);
> + ccp_irq_bh(&ccp->irq_tasklet);
>
> return IRQ_HANDLED;
> }
> @@ -457,8 +457,7 @@ static int ccp_init(struct ccp_device *ccp)
>
> /* Initialize the ISR tasklet? */
> if (ccp->use_tasklet)
> - tasklet_init(&ccp->irq_tasklet, ccp_irq_bh,
> - (unsigned long)ccp);
> + tasklet_setup(&ccp->irq_tasklet, ccp_irq_bh);
>
> dev_dbg(dev, "Starting threads...\n");
> /* Create a kthread for each queue */
> diff --git a/drivers/crypto/ccp/ccp-dev-v5.c b/drivers/crypto/ccp/ccp-dev-v5.c
> index 7838f63bab32..e68b05a3169b 100644
> --- a/drivers/crypto/ccp/ccp-dev-v5.c
> +++ b/drivers/crypto/ccp/ccp-dev-v5.c
> @@ -733,9 +733,9 @@ static void ccp5_enable_queue_interrupts(struct ccp_device *ccp)
> iowrite32(SUPPORTED_INTERRUPTS, ccp->cmd_q[i].reg_int_enable);
> }
>
> -static void ccp5_irq_bh(unsigned long data)
> +static void ccp5_irq_bh(struct tasklet_struct *t)
> {
> - struct ccp_device *ccp = (struct ccp_device *)data;
> + struct ccp_device *ccp = from_tasklet(ccp, t, irq_tasklet);
> u32 status;
> unsigned int i;
>
> @@ -772,7 +772,7 @@ static irqreturn_t ccp5_irq_handler(int irq, void *data)
> if (ccp->use_tasklet)
> tasklet_schedule(&ccp->irq_tasklet);
> else
> - ccp5_irq_bh((unsigned long)ccp);
> + ccp5_irq_bh(&ccp->irq_tasklet);
> return IRQ_HANDLED;
> }
>
> @@ -894,8 +894,7 @@ static int ccp5_init(struct ccp_device *ccp)
> }
> /* Initialize the ISR tasklet */
> if (ccp->use_tasklet)
> - tasklet_init(&ccp->irq_tasklet, ccp5_irq_bh,
> - (unsigned long)ccp);
> + tasklet_setup(&ccp->irq_tasklet, ccp5_irq_bh);
>
> dev_dbg(dev, "Loading LSB map...\n");
> /* Copy the private LSB mask to the public registers */
> diff --git a/drivers/crypto/ccp/ccp-dmaengine.c b/drivers/crypto/ccp/ccp-dmaengine.c
> index 0770a83bf1a5..a85690866b05 100644
> --- a/drivers/crypto/ccp/ccp-dmaengine.c
> +++ b/drivers/crypto/ccp/ccp-dmaengine.c
> @@ -121,9 +121,9 @@ static void ccp_cleanup_desc_resources(struct ccp_device *ccp,
> }
> }
>
> -static void ccp_do_cleanup(unsigned long data)
> +static void ccp_do_cleanup(struct tasklet_struct *t)
> {
> - struct ccp_dma_chan *chan = (struct ccp_dma_chan *)data;
> + struct ccp_dma_chan *chan = from_tasklet(chan, t, cleanup_tasklet);
> unsigned long flags;
>
> dev_dbg(chan->ccp->dev, "%s - chan=%s\n", __func__,
> @@ -712,8 +712,7 @@ int ccp_dmaengine_register(struct ccp_device *ccp)
> INIT_LIST_HEAD(&chan->active);
> INIT_LIST_HEAD(&chan->complete);
>
> - tasklet_init(&chan->cleanup_tasklet, ccp_do_cleanup,
> - (unsigned long)chan);
> + tasklet_setup(&chan->cleanup_tasklet, ccp_do_cleanup);
>
> dma_chan->device = dma_dev;
> dma_cookie_init(dma_chan);
> --
> 2.25.1
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-01-13 16:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 1:46 [PATCH v3 00/19]crypto: convert tasklets to use new tasklet_setup API() Allen Pais
2021-01-12 1:46 ` [PATCH v3 01/19] crypto: amcc: convert tasklets to use new tasklet_setup() API Allen Pais
2021-01-12 1:46 ` [PATCH v3 02/19] crypto: atmel: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 03/19] crypto: axis: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 04/19] crypto: caam: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 05/19] crypto: cavium: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 06/19] crypto: ccp: " Allen Pais
2021-01-13 16:17 ` John Allen [this message]
2021-01-12 1:46 ` [PATCH v3 07/19] crypto: ccree: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 08/19] crypto: hifn_795x: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 09/19] crypto: img-hash: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 10/19] crypto: ixp4xx: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 11/19] crypto: mediatek: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 12/19] crypto: omap: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 13/19] crypto: picoxcell: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 14/19] crypto: qat: " Allen Pais
2021-01-14 17:51 ` Giovanni Cabiddu
2021-01-18 7:11 ` Allen Pais
2021-01-12 1:46 ` [PATCH v3 15/19] crypto: qce: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 16/19] crypto: rockchip: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 17/19] crypto: s5p: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 18/19] crypto: talitos: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 19/19] crypto: octeontx: " Allen Pais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113161734.GA31464@theseus \
--to=john.allen@amd.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allen.lkml@gmail.com \
--cc=apais@linux.microsoft.com \
--cc=arno@natisbad.org \
--cc=aymen.sghaier@nxp.com \
--cc=bbrezillon@kernel.org \
--cc=davem@davemloft.net \
--cc=gcherian@marvell.com \
--cc=gilad@benyossef.com \
--cc=giovanni.cabiddu@intel.com \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=jamie@jamieiles.com \
--cc=jesper.nilsson@axis.com \
--cc=k.konieczny@samsung.com \
--cc=krzk@kernel.org \
--cc=lars.persson@axis.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=matthias.bgg@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=qat-linux@intel.com \
--cc=romain.perier@gmail.com \
--cc=schalla@marvell.com \
--cc=thomas.lendacky@amd.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).