linux-mediatek.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Allen Pais <allen.lkml@gmail.com>
To: herbert@gondor.apana.org.au
Cc: giovanni.cabiddu@intel.com, alexandre.belloni@bootlin.com,
	aymen.sghaier@nxp.com, heiko@sntech.de, qat-linux@intel.com,
	jamie@jamieiles.com, jesper.nilsson@axis.com,
	linux-samsung-soc@vger.kernel.org, horia.geanta@nxp.com,
	k.konieczny@samsung.com, schalla@marvell.com, krzk@kernel.org,
	linux-rockchip@lists.infradead.org,
	ludovic.desroches@microchip.com, thomas.lendacky@amd.com,
	arno@natisbad.org, vz@mleia.com, gilad@benyossef.com,
	gcherian@marvell.com, linux-mediatek@lists.infradead.org,
	lars.persson@axis.com, matthias.bgg@gmail.com,
	Allen Pais <apais@linux.microsoft.com>,
	john.allen@amd.com, bbrezillon@kernel.org,
	nicolas.ferre@microchip.com, linux-crypto@vger.kernel.org,
	Romain Perier <romain.perier@gmail.com>,
	davem@davemloft.net
Subject: [PATCH v4 04/19] crypto: caam: convert tasklets to use new tasklet_setup() API
Date: Thu, 21 Jan 2021 10:11:11 +0530	[thread overview]
Message-ID: <20210121044126.152274-5-allen.lkml@gmail.com> (raw)
In-Reply-To: <20210121044126.152274-1-allen.lkml@gmail.com>

From: Allen Pais <apais@linux.microsoft.com>

In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.

Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
Signed-off-by: Romain Perier <romain.perier@gmail.com>
Signed-off-by: Allen Pais <apais@linux.microsoft.com>
---
 drivers/crypto/caam/jr.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index 7f2b1101f567..2903e1af0a56 100644
--- a/drivers/crypto/caam/jr.c
+++ b/drivers/crypto/caam/jr.c
@@ -9,6 +9,7 @@
 
 #include <linux/of_irq.h>
 #include <linux/of_address.h>
+#include <linux/interrupt.h>
 
 #include "compat.h"
 #include "ctrl.h"
@@ -201,11 +202,11 @@ static irqreturn_t caam_jr_interrupt(int irq, void *st_dev)
 }
 
 /* Deferred service handler, run as interrupt-fired tasklet */
-static void caam_jr_dequeue(unsigned long devarg)
+static void caam_jr_dequeue(struct tasklet_struct *t)
 {
 	int hw_idx, sw_idx, i, head, tail;
-	struct device *dev = (struct device *)devarg;
-	struct caam_drv_private_jr *jrp = dev_get_drvdata(dev);
+	struct caam_drv_private_jr *jrp = from_tasklet(jrp, t, irqtask);
+	struct device *dev = jrp->dev;
 	void (*usercall)(struct device *dev, u32 *desc, u32 status, void *arg);
 	u32 *userdesc, userstatus;
 	void *userarg;
@@ -483,7 +484,7 @@ static int caam_jr_init(struct device *dev)
 		      (JOBR_INTC_COUNT_THLD << JRCFG_ICDCT_SHIFT) |
 		      (JOBR_INTC_TIME_THLD << JRCFG_ICTT_SHIFT));
 
-	tasklet_init(&jrp->irqtask, caam_jr_dequeue, (unsigned long)dev);
+	tasklet_setup(&jrp->irqtask, caam_jr_dequeue);
 
 	/* Connect job ring interrupt handler. */
 	error = devm_request_irq(dev, jrp->irq, caam_jr_interrupt, IRQF_SHARED,
-- 
2.25.1


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  parent reply	other threads:[~2021-01-21  4:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21  4:41 [PATCH v4 00/19]crypto: convert tasklets to use new tasklet_setup API() Allen Pais
2021-01-21  4:41 ` [PATCH v4 01/19] crypto: amcc: convert tasklets to use new tasklet_setup() API Allen Pais
2021-01-29  5:05   ` Herbert Xu
2021-01-29  9:08     ` Allen Pais
2021-01-21  4:41 ` [PATCH v4 02/19] crypto: atmel: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 03/19] crypto: axis: " Allen Pais
2021-01-21  4:41 ` Allen Pais [this message]
2021-01-21  4:41 ` [PATCH v4 05/19] crypto: cavium: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 06/19] crypto: ccp: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 07/19] crypto: ccree: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 08/19] crypto: hifn_795x: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 09/19] crypto: img-hash: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 10/19] crypto: ixp4xx: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 11/19] crypto: mediatek: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 12/19] crypto: omap: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 13/19] crypto: picoxcell: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 14/19] crypto: qat: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 15/19] crypto: qce: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 16/19] crypto: rockchip: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 17/19] crypto: s5p: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 18/19] crypto: talitos: " Allen Pais
2021-01-21  4:41 ` [PATCH v4 19/19] crypto: octeontx: " Allen Pais

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121044126.152274-5-allen.lkml@gmail.com \
    --to=allen.lkml@gmail.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=apais@linux.microsoft.com \
    --cc=arno@natisbad.org \
    --cc=aymen.sghaier@nxp.com \
    --cc=bbrezillon@kernel.org \
    --cc=davem@davemloft.net \
    --cc=gcherian@marvell.com \
    --cc=gilad@benyossef.com \
    --cc=giovanni.cabiddu@intel.com \
    --cc=heiko@sntech.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=jamie@jamieiles.com \
    --cc=jesper.nilsson@axis.com \
    --cc=john.allen@amd.com \
    --cc=k.konieczny@samsung.com \
    --cc=krzk@kernel.org \
    --cc=lars.persson@axis.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=matthias.bgg@gmail.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=qat-linux@intel.com \
    --cc=romain.perier@gmail.com \
    --cc=schalla@marvell.com \
    --cc=thomas.lendacky@amd.com \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).