From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: zhaoxiao <long870912@gmail.com>
Cc: thierry.reding@gmail.com, lee.jones@linaro.org,
matthias.bgg@gmail.com, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] pwm: mediatek: Simplify using devm_pwmchip_add()
Date: Tue, 7 Sep 2021 11:17:35 +0200 [thread overview]
Message-ID: <20210907091735.wfuevpu5a6k4pmlj@pengutronix.de> (raw)
In-Reply-To: <20210906093030.459-1-long870912@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2054 bytes --]
Hello,
On Mon, Sep 06, 2021 at 05:30:30PM +0800, zhaoxiao wrote:
> With devm_pwmchip_add() we can drop pwmchip_remove() from the device
> remove callback. The latter can then go away, too and as this is the
> only user of platform_get_drvdata(), the respective call to
> platform_set_drvdata() can go, too.
>
> Signed-off-by: zhaoxiao <long870912@gmail.com>
> ---
> drivers/pwm/pwm-mediatek.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
> index b4a31060bcd7..0d4dd80e9f07 100644
> --- a/drivers/pwm/pwm-mediatek.c
> +++ b/drivers/pwm/pwm-mediatek.c
> @@ -253,13 +253,11 @@ static int pwm_mediatek_probe(struct platform_device *pdev)
> }
> }
>
> - platform_set_drvdata(pdev, pc);
> -
> pc->chip.dev = &pdev->dev;
> pc->chip.ops = &pwm_mediatek_ops;
> pc->chip.npwm = pc->soc->num_pwms;
>
> - ret = pwmchip_add(&pc->chip);
> + ret = devm_pwmchip_add(&pdev->dev, &pc->chip);
> if (ret < 0) {
> dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret);
> return ret;
> @@ -268,13 +266,6 @@ static int pwm_mediatek_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int pwm_mediatek_remove(struct platform_device *pdev)
> -{
> - struct pwm_mediatek_chip *pc = platform_get_drvdata(pdev);
> -
> - return pwmchip_remove(&pc->chip);
> -}
> -
> static const struct pwm_mediatek_of_data mt2712_pwm_data = {
> .num_pwms = 8,
> .pwm45_fixup = false,
> @@ -335,7 +326,6 @@ static struct platform_driver pwm_mediatek_driver = {
> .of_match_table = pwm_mediatek_of_match,
> },
> .probe = pwm_mediatek_probe,
> - .remove = pwm_mediatek_remove,
> };
> module_platform_driver(pwm_mediatek_driver);
A patch like this is already in next, see e0150252a6437d12de3db84bb3af12bd5aa5cc70
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2021-09-07 9:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 9:30 [PATCH] pwm: mediatek: Simplify using devm_pwmchip_add() zhaoxiao
2021-09-07 9:17 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907091735.wfuevpu5a6k4pmlj@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=long870912@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).