From: Markus Schneider-Pargmann <msp@baylibre.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/6] dt-bindings: mediatek,dpi: Add mt8195 dpintf
Date: Thu, 9 Sep 2021 14:49:53 +0200 [thread overview]
Message-ID: <20210909124953.635bvnizczabk2ii@blmsp> (raw)
In-Reply-To: <YTZ2jf0xynvvZM2s@ravnborg.org>
Hi Sam,
On Mon, Sep 06, 2021 at 10:14:05PM +0200, Sam Ravnborg wrote:
> Hi Markus,
>
> On Mon, Sep 06, 2021 at 09:35:24PM +0200, Markus Schneider-Pargmann wrote:
> > DP_INTF is similar to the actual dpi. They differ in some points
> > regarding registers and what needs to be set but the function blocks
> > itself are similar in design.
> >
> > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
>
> I fail to see why they share the same dt-schema as the main content in
> the schema is the clocks and they differ.
>
> A new mediatek,dpintf schema seems more appropriate.
Good idea, I will do that. Thank you.
Best,
Markus
>
> I recall I though so when reading the RFC variant but failed to comment on it.
>
> Sam
>
> > ---
> > .../display/mediatek/mediatek,dpi.yaml | 43 ++++++++++++++++---
> > 1 file changed, 37 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > index dd2896a40ff0..1a158b719ce6 100644
> > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > @@ -4,7 +4,7 @@
> > $id: http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml#
> > $schema: http://devicetree.org/meta-schemas/core.yaml#
> >
> > -title: mediatek DPI Controller Device Tree Bindings
> > +title: mediatek DPI/DP_INTF Controller Device Tree Bindings
> >
> > maintainers:
> > - CK Hu <ck.hu@mediatek.com>
> > @@ -13,7 +13,8 @@ maintainers:
> > description: |
> > The Mediatek DPI function block is a sink of the display subsystem and
> > provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422 pixel data on a parallel
> > - output bus.
> > + output bus. The Mediatek DP_INTF is a similar function block that is
> > + connected to the (embedded) display port function block.
> >
> > properties:
> > compatible:
> > @@ -23,6 +24,7 @@ properties:
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > - mediatek,mt8192-dpi
> > + - mediatek,mt8195-dpintf
> >
> > reg:
> > maxItems: 1
> > @@ -37,10 +39,11 @@ properties:
> > - description: DPI PLL
> >
> > clock-names:
> > - items:
> > - - const: pixel
> > - - const: engine
> > - - const: pll
> > + description:
> > + For dpi clocks pixel, engine and pll are required. For dpintf pixel,
> > + hf_fmm and hf_fdp are required.
> > + minItems: 3
> > + maxItems: 3
> >
> > pinctrl-0: true
> > pinctrl-1: true
> > @@ -64,6 +67,34 @@ required:
> > - clock-names
> > - port
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - mediatek,mt8195-dpintf
> > + then:
> > + properties:
> > + clocks:
> > + minItems: 3
> > + maxItems: 3
> > + clock-names:
> > + items:
> > + - const: pixel
> > + - const: hf_fmm
> > + - const: hf_fdp
> > + else:
> > + properties:
> > + clocks:
> > + minItems: 3
> > + maxItems: 3
> > + clock-names:
> > + items:
> > + - const: pixel
> > + - const: engine
> > + - const: pll
> > +
> > additionalProperties: false
> >
> > examples:
> > --
> > 2.33.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-09-09 13:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 19:35 [PATCH v1 0/6] drm/mediatek: Add mt8195 DisplayPort driver Markus Schneider-Pargmann
2021-09-06 19:35 ` [PATCH v1 1/6] dt-bindings: mediatek,dpi: Add mt8195 dpintf Markus Schneider-Pargmann
2021-09-06 20:14 ` Sam Ravnborg
2021-09-09 12:49 ` Markus Schneider-Pargmann [this message]
2021-09-06 19:35 ` [PATCH v1 2/6] dt-bindings: mediatek,dp: Add Display Port binding Markus Schneider-Pargmann
2021-09-06 19:35 ` [PATCH v1 3/6] drm/edid: Add cea_sad helpers for freq/length Markus Schneider-Pargmann
2021-09-06 20:19 ` Sam Ravnborg
2021-09-07 7:38 ` Markus Schneider-Pargmann
2021-09-06 19:35 ` [PATCH v1 4/6] video/hdmi: Add audio_infoframe packing for DP Markus Schneider-Pargmann
2021-09-06 20:30 ` Sam Ravnborg
2021-09-07 8:59 ` Markus Schneider-Pargmann
2021-09-06 19:35 ` [PATCH v1 5/6] drm/mediatek: dpi: Add dpintf support Markus Schneider-Pargmann
2021-09-06 19:35 ` [PATCH v1 6/6] drm/mediatek: Add mt8195 DisplayPort driver Markus Schneider-Pargmann
2021-09-06 20:39 ` Sam Ravnborg
2021-09-09 12:45 ` Markus Schneider-Pargmann
2021-09-07 8:47 ` Philipp Zabel
2021-09-09 9:16 ` Markus Schneider-Pargmann
2021-09-09 23:37 ` Chun-Kuang Hu
2021-09-10 5:36 ` Markus Schneider-Pargmann
2021-09-13 23:25 ` Chun-Kuang Hu
2021-09-17 13:33 ` Markus Schneider-Pargmann
2021-09-17 14:36 ` Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909124953.635bvnizczabk2ii@blmsp \
--to=msp@baylibre.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).