From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: iommu@lists.linux-foundation.org, Yong Wu <yong.wu@mediatek.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org (moderated list:MEDIATEK
IOMMU DRIVER),
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/Mediatek SoC support),
linux-kernel@vger.kernel.org (open list),
dafna.hirschfeld@collabora.com, kernel@collabora.com,
linux-media@vger.kernel.org, sebastian.reichel@collabora.com
Subject: [PATCH v2 3/5] iommu/mediatek: Remove the power status checking in tlb flush all
Date: Wed, 8 Dec 2021 14:07:42 +0200 [thread overview]
Message-ID: <20211208120744.2415-4-dafna.hirschfeld@collabora.com> (raw)
In-Reply-To: <20211208120744.2415-1-dafna.hirschfeld@collabora.com>
From: Yong Wu <yong.wu@mediatek.com>
To simplify the code, Remove the power status checking in the
tlb_flush_all, remove this:
if (pm_runtime_get_if_in_use(data->dev) <= 0)
continue;
The mtk_iommu_tlb_flush_all is called from
a) isr
b) tlb flush range fail case
c) iommu_create_device_direct_mappings
In first two cases, the power and clock are always enabled.
In the third case tlb flush is unnecessary because in a later patch
in the series a full flush from the pm_runtime_resume callback is added.
In addition, writing the tlb control register when the iommu is not resumed
is ok and the write is ignored.
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
[refactor commit log]
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
drivers/iommu/mtk_iommu.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index dd2c08c54df4..e30ac68fab48 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -210,15 +210,10 @@ static struct mtk_iommu_domain *to_mtk_domain(struct iommu_domain *dom)
static void mtk_iommu_tlb_flush_all(struct mtk_iommu_data *data)
{
- if (pm_runtime_get_if_in_use(data->dev) <= 0)
- return;
-
writel_relaxed(F_INVLD_EN1 | F_INVLD_EN0,
data->base + data->plat_data->inv_sel_reg);
writel_relaxed(F_ALL_INVLD, data->base + REG_MMU_INVALIDATE);
wmb(); /* Make sure the tlb flush all done */
-
- pm_runtime_put(data->dev);
}
static void mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size,
--
2.17.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-12-08 12:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 12:07 [PATCH v2 0/5] iommu/mediatek: Fix tlb flush logic Dafna Hirschfeld
2021-12-08 12:07 ` [PATCH v2 1/5] iommu/mediatek: Remove for_each_m4u in tlb_sync_all Dafna Hirschfeld
2022-01-10 11:42 ` AngeloGioacchino Del Regno
2021-12-08 12:07 ` [PATCH v2 2/5] iommu/mediatek: Always check runtime PM status in tlb flush range callback Dafna Hirschfeld
2021-12-13 7:53 ` Yong Wu
2022-01-10 11:43 ` AngeloGioacchino Del Regno
2021-12-08 12:07 ` Dafna Hirschfeld [this message]
2022-01-10 11:43 ` [PATCH v2 3/5] iommu/mediatek: Remove the power status checking in tlb flush all AngeloGioacchino Del Regno
2021-12-08 12:07 ` [PATCH v2 4/5] iommu/mediatek: Add tlb_lock in tlb_flush_all Dafna Hirschfeld
2022-01-10 11:44 ` AngeloGioacchino Del Regno
2021-12-08 12:07 ` [PATCH v2 5/5] iommu/mediatek: Always tlb_flush_all when each PM resume Dafna Hirschfeld
2022-01-10 11:44 ` AngeloGioacchino Del Regno
2022-03-04 10:05 ` [PATCH v2 0/5] iommu/mediatek: Fix tlb flush logic Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208120744.2415-4-dafna.hirschfeld@collabora.com \
--to=dafna.hirschfeld@collabora.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sebastian.reichel@collabora.com \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).