From: Stephen Boyd <sboyd@kernel.org>
To: Matthias Brugger <matthias.bgg@gmail.com>,
Miles Chen <miles.chen@mediatek.com>
Cc: chun-jie.chen@mediatek.com, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, miles.chen@mediatek.com,
mturquette@baylibre.com, wenst@chromium.org
Subject: Re: [PATCH 3/3] clk: mediatek: support COMMON_CLK_MT8192 module build
Date: Fri, 14 Jan 2022 14:19:28 -0800 [thread overview]
Message-ID: <20220114221930.660B5C36AE9@smtp.kernel.org> (raw)
In-Reply-To: <20220114083511.18906-1-miles.chen@mediatek.com>
Quoting Miles Chen (2022-01-14 00:35:10)
> Hi,
>
> >Have you tried removing the modules? And then reloading them? I also see
>
> Thanks for the comment.
> I did not try it because we do not unload our clk modules.
> After testing I understand that the clock driver does not unregister clks so
> we cannot remove then unload it.
>
> I think I have to add some unregister logic to these drivers.
Yes
>
> >that mtk_clk_simple_probe() doesn't actually unregister anything, it
> >just frees some allocations. Please fix this before making these
> >modules.
>
> You meant that mtk_clk_simple_probe() has no unregister logic in error path?
>
Yes
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2022-01-14 22:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 17:09 clk: mediatek: support COMMON_CLK_MT8192 module build Miles Chen
2022-01-10 17:09 ` [PATCH 1/3] clk: mediatek: export mtk_clk_simple_probe Miles Chen
2022-01-14 2:12 ` Stephen Boyd
2022-01-14 8:36 ` Miles Chen
2022-01-10 17:09 ` [PATCH 2/3] clk: mediatek: clk-mt8192: drop CLK_OF_DECLARE_DRIVER Miles Chen
2022-01-10 17:09 ` [PATCH 3/3] clk: mediatek: support COMMON_CLK_MT8192 module build Miles Chen
2022-01-14 2:11 ` Stephen Boyd
2022-01-14 8:35 ` Miles Chen
2022-01-14 22:19 ` Stephen Boyd [this message]
2022-01-17 9:18 ` Miles Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220114221930.660B5C36AE9@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=chun-jie.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=mturquette@baylibre.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).