From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yong Wu <yong.wu@mediatek.com>
Cc: Joerg Roedel <joro@8bytes.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux.dev, iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
mingyuan.ma@mediatek.com, yf.wang@mediatek.com,
libo.kang@mediatek.com, chengci.xu@mediatek.com,
youlin.pei@mediatek.com, anan.sun@mediatek.com,
xueqi.zhang@mediatek.com, Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH v4 3/6] iommu/mediatek: Add error path for loop of mm_dts_parse
Date: Tue, 30 Aug 2022 11:32:07 +0300 [thread overview]
Message-ID: <20220830083206.GT2030@kadam> (raw)
In-Reply-To: <20220824064306.21495-4-yong.wu@mediatek.com>
On Wed, Aug 24, 2022 at 02:43:03PM +0800, Yong Wu wrote:
> The mtk_iommu_mm_dts_parse will parse the smi larbs nodes. if the i+1
> larb is parsed fail, we should put_device for the 0..i larbs.
>
> There are two places need to comment:
> 1) The larbid may be not linear mapping, we should loop whole
> the array in the error path.
> 2) I move this line position: "data->larb_imu[id].dev = &plarbdev->dev;"
> That means set data->larb_imu[id].dev before the error path.
> then we don't need "platform_device_put(plarbdev)" again while
> probe_defer case. All depend on "put_device" in the error path in error
> cases.
I don't understand what you're saying here. There is still a
platform_device_put(plarbdev) on the success path after
component_match_add().
So if we fail when i == 2 then we do:
put_device(data->larb_imu[2].dev);
But for the previous iterations has both platform_device_put()
and put_device() called for them.
regards,
dan carpenter
next prev parent reply other threads:[~2022-08-30 8:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 6:43 [PATCH v4 0/6] iommu/mediatek: Improve safety from invalid dts input Yong Wu
2022-08-24 6:43 ` [PATCH v4 1/6] iommu/mediatek: Add platform_device_put for recovering the device refcnt Yong Wu
2022-08-30 8:16 ` AngeloGioacchino Del Regno
2022-08-24 6:43 ` [PATCH v4 2/6] iommu/mediatek: Use component_match_add Yong Wu
2022-08-24 6:43 ` [PATCH v4 3/6] iommu/mediatek: Add error path for loop of mm_dts_parse Yong Wu
2022-08-30 8:14 ` AngeloGioacchino Del Regno
2022-09-07 3:08 ` Yong Wu
2022-08-30 8:32 ` Dan Carpenter [this message]
2022-09-07 3:10 ` Yong Wu
2022-08-24 6:43 ` [PATCH v4 4/6] iommu/mediatek: Validate number of phandles associated with "mediatek,larbs" Yong Wu
2022-08-24 6:43 ` [PATCH v4 5/6] iommu/mediatek: Improve safety for mediatek,smi property in larb nodes Yong Wu
2022-08-30 8:16 ` AngeloGioacchino Del Regno
2022-08-24 6:43 ` [PATCH v4 6/6] iommu/mediatek: Remove unused "mapping" member from mtk_iommu_data Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220830083206.GT2030@kadam \
--to=dan.carpenter@oracle.com \
--cc=anan.sun@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chengci.xu@mediatek.com \
--cc=groeck@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=libo.kang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mingyuan.ma@mediatek.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=xueqi.zhang@mediatek.com \
--cc=yf.wang@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).