* [PATCH] scsi: ufs-mediatek: add dependency for RESET_CONTROLLER
@ 2023-06-02 2:39 Randy Dunlap
2023-06-07 17:17 ` Bart Van Assche
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-06-02 2:39 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Stanley Chu, Peter Wang,
Paul Gazzillo, Necip Fazil Yildiran, linux-scsi,
linux-arm-kernel, linux-mediatek, James E.J. Bottomley,
Martin K. Petersen
When RESET_CONTROLLER is not set, kconfig complains about missing
dependencies for RESET_TI_SYSCON, so add the missing dependency
just as is done above for SCSI_UFS_QCOM.
Silences this kconfig warning:
WARNING: unmet direct dependencies detected for RESET_TI_SYSCON
Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y]
Selected by [m]:
- SCSI_UFS_MEDIATEK [=m] && SCSI_UFSHCD [=y] && SCSI_UFSHCD_PLATFORM [=y] && ARCH_MEDIATEK [=y]
Fixes: de48898d0cb6 ("scsi: ufs-mediatek: Create reset control device_link")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Link: lore.kernel.org/r/202306020859.1wHg9AaT-lkp@intel.com
Cc: Stanley Chu <stanley.chu@mediatek.com>
Cc: Peter Wang <peter.wang@mediatek.com>
Cc: Paul Gazzillo <paul@pgazz.com>
Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Cc: linux-scsi@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-mediatek@lists.infradead.org
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
---
drivers/ufs/host/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/ufs/host/Kconfig b/drivers/ufs/host/Kconfig
--- a/drivers/ufs/host/Kconfig
+++ b/drivers/ufs/host/Kconfig
@@ -72,6 +72,7 @@ config SCSI_UFS_QCOM
config SCSI_UFS_MEDIATEK
tristate "Mediatek specific hooks to UFS controller platform driver"
depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK
+ depends on RESET_CONTROLLER
select PHY_MTK_UFS
select RESET_TI_SYSCON
help
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: ufs-mediatek: add dependency for RESET_CONTROLLER
2023-06-02 2:39 [PATCH] scsi: ufs-mediatek: add dependency for RESET_CONTROLLER Randy Dunlap
@ 2023-06-07 17:17 ` Bart Van Assche
0 siblings, 0 replies; 2+ messages in thread
From: Bart Van Assche @ 2023-06-07 17:17 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: kernel test robot, Stanley Chu, Peter Wang, Paul Gazzillo,
Necip Fazil Yildiran, linux-scsi, linux-arm-kernel,
linux-mediatek, James E.J. Bottomley, Martin K. Petersen
On 6/1/23 19:39, Randy Dunlap wrote:
> When RESET_CONTROLLER is not set, kconfig complains about missing
> dependencies for RESET_TI_SYSCON, so add the missing dependency
> just as is done above for SCSI_UFS_QCOM.
>
> Silences this kconfig warning:
>
> WARNING: unmet direct dependencies detected for RESET_TI_SYSCON
> Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y]
> Selected by [m]:
> - SCSI_UFS_MEDIATEK [=m] && SCSI_UFSHCD [=y] && SCSI_UFSHCD_PLATFORM [=y] && ARCH_MEDIATEK [=y]
>
> Fixes: de48898d0cb6 ("scsi: ufs-mediatek: Create reset control device_link")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: lore.kernel.org/r/202306020859.1wHg9AaT-lkp@intel.com
> Cc: Stanley Chu <stanley.chu@mediatek.com>
> Cc: Peter Wang <peter.wang@mediatek.com>
> Cc: Paul Gazzillo <paul@pgazz.com>
> Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com>
> Cc: linux-scsi@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-mediatek@lists.infradead.org
> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> ---
> drivers/ufs/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/ufs/host/Kconfig b/drivers/ufs/host/Kconfig
> --- a/drivers/ufs/host/Kconfig
> +++ b/drivers/ufs/host/Kconfig
> @@ -72,6 +72,7 @@ config SCSI_UFS_QCOM
> config SCSI_UFS_MEDIATEK
> tristate "Mediatek specific hooks to UFS controller platform driver"
> depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK
> + depends on RESET_CONTROLLER
> select PHY_MTK_UFS
> select RESET_TI_SYSCON
> help
Hmm ... is the above patch complete? Shouldn't a similar dependency be
added to the ufs-hisi and ufs-sprd drivers? See also the following git
grep output:
$ git grep -nH 'include.*linux/reset.h' */ufs
drivers/ufs/host/ufs-hisi.c:16:#include <linux/reset.h>
drivers/ufs/host/ufs-mediatek.c:21:#include <linux/reset.h>
drivers/ufs/host/ufs-qcom.h:9:#include <linux/reset.h>
drivers/ufs/host/ufs-sprd.c:14:#include <linux/reset.h>
Thanks,
Bart.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-07 17:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-02 2:39 [PATCH] scsi: ufs-mediatek: add dependency for RESET_CONTROLLER Randy Dunlap
2023-06-07 17:17 ` Bart Van Assche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).