From: Matthias Brugger <matthias.bgg@gmail.com>
To: Qii Wang <qii.wang@mediatek.com>, wsa@the-dreams.de
Cc: qiangming.xia@mediatek.com, devicetree@vger.kernel.org,
srv_heupstream@mediatek.com, leilk.liu@mediatek.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] i2c: mediatek: Add access to more than 8GB dram in i2c driver
Date: Wed, 29 Jul 2020 09:59:44 +0200 [thread overview]
Message-ID: <25ff4899-5e7d-f6e5-599c-4bf368a731e1@gmail.com> (raw)
In-Reply-To: <1595939446-5484-3-git-send-email-qii.wang@mediatek.com>
On 28/07/2020 14:30, Qii Wang wrote:
> Newer MTK chip support more than 8GB of dram. Replace support_33bits
> with more general dma_max_support and remove mtk_i2c_set_4g_mode.
>
> Signed-off-by: Qii Wang <qii.wang@mediatek.com>
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 38 +++++++++++++++++---------------------
> 1 file changed, 17 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index e6b984a..49777a6 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -204,11 +204,11 @@ struct mtk_i2c_compatible {
> unsigned char dcm: 1;
> unsigned char auto_restart: 1;
> unsigned char aux_len_reg: 1;
> - unsigned char support_33bits: 1;
> unsigned char timing_adjust: 1;
> unsigned char dma_sync: 1;
> unsigned char ltiming_adjust: 1;
> unsigned char apdma_sync: 1;
> + unsigned char max_dma_support;
> };
>
> struct mtk_i2c_ac_timing {
> @@ -311,11 +311,11 @@ struct i2c_spec_values {
> .dcm = 1,
> .auto_restart = 1,
> .aux_len_reg = 1,
> - .support_33bits = 1,
> .timing_adjust = 1,
> .dma_sync = 0,
> .ltiming_adjust = 0,
> .apdma_sync = 0,
> + .max_dma_support = 33,
> };
>
> static const struct mtk_i2c_compatible mt6577_compat = {
> @@ -325,11 +325,11 @@ struct i2c_spec_values {
> .dcm = 1,
> .auto_restart = 0,
> .aux_len_reg = 0,
> - .support_33bits = 0,
> .timing_adjust = 0,
> .dma_sync = 0,
> .ltiming_adjust = 0,
> .apdma_sync = 0,
> + .max_dma_support = 32,
> };
>
> static const struct mtk_i2c_compatible mt6589_compat = {
> @@ -339,11 +339,11 @@ struct i2c_spec_values {
> .dcm = 0,
> .auto_restart = 0,
> .aux_len_reg = 0,
> - .support_33bits = 0,
> .timing_adjust = 0,
> .dma_sync = 0,
> .ltiming_adjust = 0,
> .apdma_sync = 0,
> + .max_dma_support = 32,
> };
>
> static const struct mtk_i2c_compatible mt7622_compat = {
> @@ -353,11 +353,11 @@ struct i2c_spec_values {
> .dcm = 1,
> .auto_restart = 1,
> .aux_len_reg = 1,
> - .support_33bits = 0,
> .timing_adjust = 0,
> .dma_sync = 0,
> .ltiming_adjust = 0,
> .apdma_sync = 0,
> + .max_dma_support = 32,
> };
>
> static const struct mtk_i2c_compatible mt8173_compat = {
> @@ -366,11 +366,11 @@ struct i2c_spec_values {
> .dcm = 1,
> .auto_restart = 1,
> .aux_len_reg = 1,
> - .support_33bits = 1,
> .timing_adjust = 0,
> .dma_sync = 0,
> .ltiming_adjust = 0,
> .apdma_sync = 0,
> + .max_dma_support = 33,
> };
>
> static const struct mtk_i2c_compatible mt8183_compat = {
> @@ -380,11 +380,11 @@ struct i2c_spec_values {
> .dcm = 0,
> .auto_restart = 1,
> .aux_len_reg = 1,
> - .support_33bits = 1,
> .timing_adjust = 1,
> .dma_sync = 1,
> .ltiming_adjust = 1,
> .apdma_sync = 0,
> + .max_dma_support = 33,
> };
>
> static const struct of_device_id mtk_i2c_of_match[] = {
> @@ -796,11 +796,6 @@ static int mtk_i2c_set_speed(struct mtk_i2c *i2c, unsigned int parent_clk)
> return 0;
> }
>
> -static inline u32 mtk_i2c_set_4g_mode(dma_addr_t addr)
> -{
> - return (addr & BIT_ULL(32)) ? I2C_DMA_4G_MODE : I2C_DMA_CLR_FLAG;
I think you missed my comment in the last version:
I2C_DMA_4G_MODE is no longer needed, you can delete it.
Regards,
Matthias
> -}
> -
> static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
> int num, int left_num)
> {
> @@ -885,8 +880,8 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
> return -ENOMEM;
> }
>
> - if (i2c->dev_comp->support_33bits) {
> - reg_4g_mode = mtk_i2c_set_4g_mode(rpaddr);
> + if (i2c->dev_comp->max_dma_support > 32) {
> + reg_4g_mode = upper_32_bits(rpaddr);
> writel(reg_4g_mode, i2c->pdmabase + OFFSET_RX_4G_MODE);
> }
>
> @@ -908,8 +903,8 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
> return -ENOMEM;
> }
>
> - if (i2c->dev_comp->support_33bits) {
> - reg_4g_mode = mtk_i2c_set_4g_mode(wpaddr);
> + if (i2c->dev_comp->max_dma_support > 32) {
> + reg_4g_mode = upper_32_bits(wpaddr);
> writel(reg_4g_mode, i2c->pdmabase + OFFSET_TX_4G_MODE);
> }
>
> @@ -954,11 +949,11 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
> return -ENOMEM;
> }
>
> - if (i2c->dev_comp->support_33bits) {
> - reg_4g_mode = mtk_i2c_set_4g_mode(wpaddr);
> + if (i2c->dev_comp->max_dma_support > 32) {
> + reg_4g_mode = upper_32_bits(wpaddr);
> writel(reg_4g_mode, i2c->pdmabase + OFFSET_TX_4G_MODE);
>
> - reg_4g_mode = mtk_i2c_set_4g_mode(rpaddr);
> + reg_4g_mode = upper_32_bits(rpaddr);
> writel(reg_4g_mode, i2c->pdmabase + OFFSET_RX_4G_MODE);
> }
>
> @@ -1232,8 +1227,9 @@ static int mtk_i2c_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> - if (i2c->dev_comp->support_33bits) {
> - ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(33));
> + if (i2c->dev_comp->max_dma_support > 32) {
> + ret = dma_set_mask(&pdev->dev,
> + DMA_BIT_MASK(i2c->dev_comp->max_dma_support));
> if (ret) {
> dev_err(&pdev->dev, "dma_set_mask return error.\n");
> return ret;
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-07-29 8:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 12:30 [PATCH v2 0/4] add i2c support for mt8192 Qii Wang
2020-07-28 12:30 ` [PATCH v2 1/4] i2c: mediatek: Add apdma sync in i2c driver Qii Wang
2020-07-28 12:30 ` [PATCH v2 2/4] i2c: mediatek: Add access to more than 8GB dram " Qii Wang
2020-07-29 7:59 ` Matthias Brugger [this message]
2020-07-29 8:14 ` Qii Wang
2020-08-05 8:56 ` wsa
2020-07-30 2:39 ` Yingjoe Chen
2020-07-28 12:30 ` [PATCH v2 3/4] dt-bindings: i2c: update bindings for MT8192 SoC Qii Wang
2020-07-28 12:30 ` [PATCH v2 4/4] i2c: mediatek: Add i2c compatible for MediaTek MT8192 Qii Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25ff4899-5e7d-f6e5-599c-4bf368a731e1@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=qiangming.xia@mediatek.com \
--cc=qii.wang@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).