From: Can Guo <cang@codeaurora.org>
To: Stanley Chu <stanley.chu@mediatek.com>
Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
andy.teng@mediatek.com, jejb@linux.ibm.com,
chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
linux-kernel@vger.kernel.org, avri.altman@wdc.com,
linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
alim.akhtar@samsung.com, matthias.bgg@gmail.com,
asutoshd@codeaurora.org, bvanassche@acm.org,
linux-arm-kernel@lists.infradead.org, beanhuo@micron.com
Subject: Re: [PATCH v1 2/4] scsi: ufs: use an enum for host capabilities
Date: Thu, 05 Mar 2020 13:44:39 +0800 [thread overview]
Message-ID: <2f7c30cab1abf458930ac4253ff17ee1@codeaurora.org> (raw)
In-Reply-To: <20200305040704.10645-3-stanley.chu@mediatek.com>
Hi Stanley,
On 2020-03-05 12:07, Stanley Chu wrote:
> Use an enum to specify the host capabilities instead of #defines inside
> the
> structure definition.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Can Guo <cang@codeaurora.org>
> ---
> drivers/scsi/ufs/ufshcd.h | 65 ++++++++++++++++++++++-----------------
> 1 file changed, 37 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 4e235cef99bc..49ade1bfd085 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -510,6 +510,43 @@ enum ufshcd_quirks {
> UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION = 1 << 5,
> };
>
> +enum ufshcd_caps {
> + /* Allow dynamic clk gating */
> + UFSHCD_CAP_CLK_GATING = 1 << 0,
> +
> + /* Allow hiberb8 with clk gating */
> + UFSHCD_CAP_HIBERN8_WITH_CLK_GATING = 1 << 1,
> +
> + /* Allow dynamic clk scaling */
> + UFSHCD_CAP_CLK_SCALING = 1 << 2,
> +
> + /* Allow auto bkops to enabled during runtime suspend */
> + UFSHCD_CAP_AUTO_BKOPS_SUSPEND = 1 << 3,
> +
> + /*
> + * This capability allows host controller driver to use the UFS HCI's
> + * interrupt aggregation capability.
> + * CAUTION: Enabling this might reduce overall UFS throughput.
> + */
> + UFSHCD_CAP_INTR_AGGR = 1 << 4,
> +
> + /*
> + * This capability allows the device auto-bkops to be always enabled
> + * except during suspend (both runtime and suspend).
> + * Enabling this capability means that device will always be allowed
> + * to do background operation when it's active but it might degrade
> + * the performance of ongoing read/write operations.
> + */
> + UFSHCD_CAP_KEEP_AUTO_BKOPS_ENABLED_EXCEPT_SUSPEND = 1 << 5,
> +
> + /*
> + * This capability allows host controller driver to automatically
> + * enable runtime power management by itself instead of waiting
> + * for userspace to control the power management.
> + */
> + UFSHCD_CAP_RPM_AUTOSUSPEND = 1 << 6,
> +};
> +
> /**
> * struct ufs_hba - per adapter private structure
> * @mmio_base: UFSHCI base register address
> @@ -662,34 +699,6 @@ struct ufs_hba {
> struct ufs_clk_gating clk_gating;
> /* Control to enable/disable host capabilities */
> u32 caps;
> - /* Allow dynamic clk gating */
> -#define UFSHCD_CAP_CLK_GATING (1 << 0)
> - /* Allow hiberb8 with clk gating */
> -#define UFSHCD_CAP_HIBERN8_WITH_CLK_GATING (1 << 1)
> - /* Allow dynamic clk scaling */
> -#define UFSHCD_CAP_CLK_SCALING (1 << 2)
> - /* Allow auto bkops to enabled during runtime suspend */
> -#define UFSHCD_CAP_AUTO_BKOPS_SUSPEND (1 << 3)
> - /*
> - * This capability allows host controller driver to use the UFS HCI's
> - * interrupt aggregation capability.
> - * CAUTION: Enabling this might reduce overall UFS throughput.
> - */
> -#define UFSHCD_CAP_INTR_AGGR (1 << 4)
> - /*
> - * This capability allows the device auto-bkops to be always enabled
> - * except during suspend (both runtime and suspend).
> - * Enabling this capability means that device will always be allowed
> - * to do background operation when it's active but it might degrade
> - * the performance of ongoing read/write operations.
> - */
> -#define UFSHCD_CAP_KEEP_AUTO_BKOPS_ENABLED_EXCEPT_SUSPEND (1 << 5)
> - /*
> - * This capability allows host controller driver to automatically
> - * enable runtime power management by itself instead of waiting
> - * for userspace to control the power management.
> - */
> -#define UFSHCD_CAP_RPM_AUTOSUSPEND (1 << 6)
>
> struct devfreq *devfreq;
> struct ufs_clk_scaling clk_scaling;
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-03-05 5:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 4:07 [PATCH v1 0/4] scsi: ufs: some cleanups and make the delay for host enabling customizable Stanley Chu
2020-03-05 4:07 ` [PATCH v1 1/4] scsi: ufs: remove init_prefetch_data in struct ufs_hba Stanley Chu
2020-03-05 4:07 ` [PATCH v1 2/4] scsi: ufs: use an enum for host capabilities Stanley Chu
2020-03-05 5:44 ` Can Guo [this message]
2020-03-05 4:07 ` [PATCH v1 3/4] scsi: ufs: allow customized delay for host enabling Stanley Chu
2020-03-05 5:45 ` Can Guo
2020-03-05 4:07 ` [PATCH v1 4/4] scsi: ufs-mediatek: remove " Stanley Chu
2020-03-05 13:14 ` Avri Altman
2020-03-05 13:25 ` Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f7c30cab1abf458930ac4253ff17ee1@codeaurora.org \
--to=cang@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).