From: Matthias Brugger <matthias.bgg@gmail.com>
To: Sam Shih <sam.shih@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND,v2,1/1] arm: dts: mediatek: add mt7629 pwm support
Date: Wed, 12 Feb 2020 11:15:37 +0100 [thread overview]
Message-ID: <38f2cdcf-2908-33a1-a99f-b5d748c78d82@gmail.com> (raw)
In-Reply-To: <1581474926-28633-2-git-send-email-sam.shih@mediatek.com>
On 12/02/2020 03:35, Sam Shih wrote:
> This adds pwm support for MT7629.
The information below should not be part of the commit message, the next time
please put it below the line "---".
> Used:
> https://patchwork.kernel.org/patch/11160851/
>
> Change since v1:
> remove unused property num-pwm
>
> Signed-off-by: Sam Shih <sam.shih@mediatek.com>
> ---
> arch/arm/boot/dts/mt7629.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi
> index 867b88103b9d..ce2a30a24017 100644
> --- a/arch/arm/boot/dts/mt7629.dtsi
> +++ b/arch/arm/boot/dts/mt7629.dtsi
> @@ -241,6 +241,20 @@
> status = "disabled";
> };
>
> + pwm: pwm@11006000 {
> + compatible = "mediatek,mt7629-pwm";
> + reg = <0x11006000 0x1000>;
> + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&topckgen CLK_TOP_PWM_SEL>,
> + <&pericfg CLK_PERI_PWM_PD>,
> + <&pericfg CLK_PERI_PWM1_PD>;
> + clock-names = "top", "main", "pwm1";
> + assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
> + assigned-clock-parents =
> + <&topckgen CLK_TOP_UNIVPLL2_D4>;
> + status = "disabled";
> + };
> +
This does not match the binding description.
Please fix that.
> i2c: i2c@11007000 {
> compatible = "mediatek,mt7629-i2c",
> "mediatek,mt2712-i2c";
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-02-12 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 2:35 [RESEND,v2,0/1] Add mt7629 pwm support Sam Shih
2020-02-12 2:35 ` [RESEND,v2,1/1] arm: dts: mediatek: add " Sam Shih
2020-02-12 10:15 ` Matthias Brugger [this message]
2020-05-16 15:37 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38f2cdcf-2908-33a1-a99f-b5d748c78d82@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sam.shih@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).